* [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
@ 2010-08-11 18:16 ` Cam Macdonell
0 siblings, 0 replies; 20+ messages in thread
From: Cam Macdonell @ 2010-08-11 18:16 UTC (permalink / raw)
To: qemu-devel; +Cc: Cam Macdonell, kvm
---
kvm-stub.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/kvm-stub.c b/kvm-stub.c
index 3378bd3..d45f9fa 100644
--- a/kvm-stub.c
+++ b/kvm-stub.c
@@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr, uint16_t val, bool assign)
{
return -ENOSYS;
}
+
+int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool assign)
+{
+ return -ENOSYS;
+}
--
1.6.2.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH 2/2] Disable build of ivshmem on non-KVM systems
2010-08-11 18:16 ` [Qemu-devel] " Cam Macdonell
@ 2010-08-11 18:16 ` Cam Macdonell
-1 siblings, 0 replies; 20+ messages in thread
From: Cam Macdonell @ 2010-08-11 18:16 UTC (permalink / raw)
To: qemu-devel; +Cc: kvm, Cam Macdonell
---
Makefile.target | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile.target b/Makefile.target
index b791492..c8281e9 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -191,7 +191,7 @@ obj-y += rtl8139.o
obj-y += e1000.o
# Inter-VM PCI shared memory
-obj-y += ivshmem.o
+obj-$(CONFIG_KVM) += ivshmem.o
# Hardware support
obj-i386-y += vga.o
--
1.6.2.5
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
2010-08-11 18:16 ` [Qemu-devel] " Cam Macdonell
(?)
(?)
@ 2010-08-11 18:28 ` Stefan Weil
2010-08-11 18:32 ` Cam Macdonell
-1 siblings, 1 reply; 20+ messages in thread
From: Stefan Weil @ 2010-08-11 18:28 UTC (permalink / raw)
To: Cam Macdonell; +Cc: qemu-devel, kvm
Am 11.08.2010 20:16, schrieb Cam Macdonell:
> ---
> kvm-stub.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/kvm-stub.c b/kvm-stub.c
> index 3378bd3..d45f9fa 100644
> --- a/kvm-stub.c
> +++ b/kvm-stub.c
> @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t
> addr, uint16_t val, bool assign)
> {
> return -ENOSYS;
> }
> +
> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val,
> bool assign)
> +{
> + return -ENOSYS;
> +}
Your 2nd patch disables build of ivshmem.o on non-kvm systems.
Only ivshmem.c was using kvm_set_ioeventfd_mmio_long, so
up to now, no dummy function in kvm-stub.c is needed.
Regards
Stefan
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
2010-08-11 18:28 ` [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for " Stefan Weil
@ 2010-08-11 18:32 ` Cam Macdonell
2010-08-11 22:07 ` Paolo Bonzini
0 siblings, 1 reply; 20+ messages in thread
From: Cam Macdonell @ 2010-08-11 18:32 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-devel, kvm
On Wed, Aug 11, 2010 at 2:28 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> Am 11.08.2010 20:16, schrieb Cam Macdonell:
>>
>> ---
>> kvm-stub.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/kvm-stub.c b/kvm-stub.c
>> index 3378bd3..d45f9fa 100644
>> --- a/kvm-stub.c
>> +++ b/kvm-stub.c
>> @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr,
>> uint16_t val, bool assign)
>> {
>> return -ENOSYS;
>> }
>> +
>> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool
>> assign)
>> +{
>> + return -ENOSYS;
>> +}
>
> Your 2nd patch disables build of ivshmem.o on non-kvm systems.
> Only ivshmem.c was using kvm_set_ioeventfd_mmio_long, so
> up to now, no dummy function in kvm-stub.c is needed.
Right. It can be left out for now if that's preferred.
Cam
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
2010-08-11 18:32 ` Cam Macdonell
@ 2010-08-11 22:07 ` Paolo Bonzini
0 siblings, 0 replies; 20+ messages in thread
From: Paolo Bonzini @ 2010-08-11 22:07 UTC (permalink / raw)
To: Cam Macdonell; +Cc: Stefan Weil, qemu-devel, kvm
On 08/11/2010 02:32 PM, Cam Macdonell wrote:
> On Wed, Aug 11, 2010 at 2:28 PM, Stefan Weil<weil@mail.berlios.de> wrote:
>> Am 11.08.2010 20:16, schrieb Cam Macdonell:
>>>
>>> ---
>>> kvm-stub.c | 5 +++++
>>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/kvm-stub.c b/kvm-stub.c
>>> index 3378bd3..d45f9fa 100644
>>> --- a/kvm-stub.c
>>> +++ b/kvm-stub.c
>>> @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr,
>>> uint16_t val, bool assign)
>>> {
>>> return -ENOSYS;
>>> }
>>> +
>>> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool
>>> assign)
>>> +{
>>> + return -ENOSYS;
>>> +}
>>
>> Your 2nd patch disables build of ivshmem.o on non-kvm systems.
>> Only ivshmem.c was using kvm_set_ioeventfd_mmio_long, so
>> up to now, no dummy function in kvm-stub.c is needed.
>
> Right. It can be left out for now if that's preferred.
No, your patch is correct. If kvm-stub.c is not complete, the build
will break the next time someone uses one of those functions.
Paolo
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
@ 2010-08-11 22:07 ` Paolo Bonzini
0 siblings, 0 replies; 20+ messages in thread
From: Paolo Bonzini @ 2010-08-11 22:07 UTC (permalink / raw)
To: Cam Macdonell; +Cc: qemu-devel, kvm
On 08/11/2010 02:32 PM, Cam Macdonell wrote:
> On Wed, Aug 11, 2010 at 2:28 PM, Stefan Weil<weil@mail.berlios.de> wrote:
>> Am 11.08.2010 20:16, schrieb Cam Macdonell:
>>>
>>> ---
>>> kvm-stub.c | 5 +++++
>>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/kvm-stub.c b/kvm-stub.c
>>> index 3378bd3..d45f9fa 100644
>>> --- a/kvm-stub.c
>>> +++ b/kvm-stub.c
>>> @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr,
>>> uint16_t val, bool assign)
>>> {
>>> return -ENOSYS;
>>> }
>>> +
>>> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool
>>> assign)
>>> +{
>>> + return -ENOSYS;
>>> +}
>>
>> Your 2nd patch disables build of ivshmem.o on non-kvm systems.
>> Only ivshmem.c was using kvm_set_ioeventfd_mmio_long, so
>> up to now, no dummy function in kvm-stub.c is needed.
>
> Right. It can be left out for now if that's preferred.
No, your patch is correct. If kvm-stub.c is not complete, the build
will break the next time someone uses one of those functions.
Paolo
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
2010-08-11 18:16 ` [Qemu-devel] " Cam Macdonell
@ 2010-08-14 17:24 ` Andreas Färber
-1 siblings, 0 replies; 20+ messages in thread
From: Andreas Färber @ 2010-08-14 17:24 UTC (permalink / raw)
To: Cam Macdonell; +Cc: QEMU Developers, kvm, Stefan Weil
Am 11.08.2010 um 20:16 schrieb Cam Macdonell:
> ---
> kvm-stub.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/kvm-stub.c b/kvm-stub.c
> index 3378bd3..d45f9fa 100644
> --- a/kvm-stub.c
> +++ b/kvm-stub.c
> @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t
> addr, uint16_t val, bool assign)
> {
> return -ENOSYS;
> }
> +
> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val,
> bool assign)
> +{
> + return -ENOSYS;
> +}
> --
> 1.6.2.5
Acked-by: Andreas Färber <andreas.faerber@web.de>
This fixes linking [1] on Mac OS X.
The patch is missing a Signed-off-by though, same for 2/2.
Andreas
[1]
LINK i386-softmmu/qemu
Undefined symbols:
"_kvm_set_ioeventfd_mmio_long", referenced from:
_ivshmem_read in ivshmem.o
_ivshmem_read in ivshmem.o
_ivshmem_mmio_map in ivshmem.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[1]: *** [qemu] Error 1
make: *** [subdir-i386-softmmu] Error 2
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
@ 2010-08-14 17:24 ` Andreas Färber
0 siblings, 0 replies; 20+ messages in thread
From: Andreas Färber @ 2010-08-14 17:24 UTC (permalink / raw)
To: Cam Macdonell; +Cc: QEMU Developers, kvm
Am 11.08.2010 um 20:16 schrieb Cam Macdonell:
> ---
> kvm-stub.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/kvm-stub.c b/kvm-stub.c
> index 3378bd3..d45f9fa 100644
> --- a/kvm-stub.c
> +++ b/kvm-stub.c
> @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t
> addr, uint16_t val, bool assign)
> {
> return -ENOSYS;
> }
> +
> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val,
> bool assign)
> +{
> + return -ENOSYS;
> +}
> --
> 1.6.2.5
Acked-by: Andreas Färber <andreas.faerber@web.de>
This fixes linking [1] on Mac OS X.
The patch is missing a Signed-off-by though, same for 2/2.
Andreas
[1]
LINK i386-softmmu/qemu
Undefined symbols:
"_kvm_set_ioeventfd_mmio_long", referenced from:
_ivshmem_read in ivshmem.o
_ivshmem_read in ivshmem.o
_ivshmem_mmio_map in ivshmem.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[1]: *** [qemu] Error 1
make: *** [subdir-i386-softmmu] Error 2
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCH 1/2] RESEND: Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
2010-08-14 17:24 ` Andreas Färber
@ 2010-08-14 23:47 ` Cam Macdonell
-1 siblings, 0 replies; 20+ messages in thread
From: Cam Macdonell @ 2010-08-14 23:47 UTC (permalink / raw)
To: qemu-devel; +Cc: kvm, Cam Macdonell
Signed-off-by: Cam Macdonell <cam@cs.ualberta.ca>
---
kvm-stub.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/kvm-stub.c b/kvm-stub.c
index 3378bd3..d45f9fa 100644
--- a/kvm-stub.c
+++ b/kvm-stub.c
@@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr, uint16_t val, bool assign)
{
return -ENOSYS;
}
+
+int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool assign)
+{
+ return -ENOSYS;
+}
--
1.6.2.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* [Qemu-devel] [PATCH 1/2] RESEND: Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
@ 2010-08-14 23:47 ` Cam Macdonell
0 siblings, 0 replies; 20+ messages in thread
From: Cam Macdonell @ 2010-08-14 23:47 UTC (permalink / raw)
To: qemu-devel; +Cc: Cam Macdonell, kvm
Signed-off-by: Cam Macdonell <cam@cs.ualberta.ca>
---
kvm-stub.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/kvm-stub.c b/kvm-stub.c
index 3378bd3..d45f9fa 100644
--- a/kvm-stub.c
+++ b/kvm-stub.c
@@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr, uint16_t val, bool assign)
{
return -ENOSYS;
}
+
+int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool assign)
+{
+ return -ENOSYS;
+}
--
1.6.2.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH 2/2] RESEND: Disable build of ivshmem on non-KVM systems
2010-08-14 23:47 ` [Qemu-devel] " Cam Macdonell
@ 2010-08-14 23:47 ` Cam Macdonell
-1 siblings, 0 replies; 20+ messages in thread
From: Cam Macdonell @ 2010-08-14 23:47 UTC (permalink / raw)
To: qemu-devel; +Cc: kvm, Cam Macdonell
Signed-off-by: Cam Macdonell <cam@cs.ualberta.ca>
---
Makefile.target | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile.target b/Makefile.target
index b791492..c8281e9 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -191,7 +191,7 @@ obj-y += rtl8139.o
obj-y += e1000.o
# Inter-VM PCI shared memory
-obj-y += ivshmem.o
+obj-$(CONFIG_KVM) += ivshmem.o
# Hardware support
obj-i386-y += vga.o
--
1.6.2.5
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [Qemu-devel] [PATCH 2/2] RESEND: Disable build of ivshmem on non-KVM systems
@ 2010-08-14 23:47 ` Cam Macdonell
0 siblings, 0 replies; 20+ messages in thread
From: Cam Macdonell @ 2010-08-14 23:47 UTC (permalink / raw)
To: qemu-devel; +Cc: Cam Macdonell, kvm
Signed-off-by: Cam Macdonell <cam@cs.ualberta.ca>
---
Makefile.target | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile.target b/Makefile.target
index b791492..c8281e9 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -191,7 +191,7 @@ obj-y += rtl8139.o
obj-y += e1000.o
# Inter-VM PCI shared memory
-obj-y += ivshmem.o
+obj-$(CONFIG_KVM) += ivshmem.o
# Hardware support
obj-i386-y += vga.o
--
1.6.2.5
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] RESEND: Disable build of ivshmem on non-KVM systems
2010-08-14 23:47 ` [Qemu-devel] " Cam Macdonell
@ 2010-08-15 9:47 ` Blue Swirl
-1 siblings, 0 replies; 20+ messages in thread
From: Blue Swirl @ 2010-08-15 9:47 UTC (permalink / raw)
To: Cam Macdonell; +Cc: qemu-devel, kvm
Thanks, applied.
On Sat, Aug 14, 2010 at 11:47 PM, Cam Macdonell <cam@cs.ualberta.ca> wrote:
> Signed-off-by: Cam Macdonell <cam@cs.ualberta.ca>
> ---
> Makefile.target | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index b791492..c8281e9 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -191,7 +191,7 @@ obj-y += rtl8139.o
> obj-y += e1000.o
>
> # Inter-VM PCI shared memory
> -obj-y += ivshmem.o
> +obj-$(CONFIG_KVM) += ivshmem.o
>
> # Hardware support
> obj-i386-y += vga.o
> --
> 1.6.2.5
>
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] RESEND: Disable build of ivshmem on non-KVM systems
@ 2010-08-15 9:47 ` Blue Swirl
0 siblings, 0 replies; 20+ messages in thread
From: Blue Swirl @ 2010-08-15 9:47 UTC (permalink / raw)
To: Cam Macdonell; +Cc: qemu-devel, kvm
Thanks, applied.
On Sat, Aug 14, 2010 at 11:47 PM, Cam Macdonell <cam@cs.ualberta.ca> wrote:
> Signed-off-by: Cam Macdonell <cam@cs.ualberta.ca>
> ---
> Makefile.target | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index b791492..c8281e9 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -191,7 +191,7 @@ obj-y += rtl8139.o
> obj-y += e1000.o
>
> # Inter-VM PCI shared memory
> -obj-y += ivshmem.o
> +obj-$(CONFIG_KVM) += ivshmem.o
>
> # Hardware support
> obj-i386-y += vga.o
> --
> 1.6.2.5
>
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] RESEND: Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
2010-08-14 23:47 ` [Qemu-devel] " Cam Macdonell
@ 2010-08-15 9:47 ` Blue Swirl
-1 siblings, 0 replies; 20+ messages in thread
From: Blue Swirl @ 2010-08-15 9:47 UTC (permalink / raw)
To: Cam Macdonell; +Cc: qemu-devel, kvm
Thanks, applied.
On Sat, Aug 14, 2010 at 11:47 PM, Cam Macdonell <cam@cs.ualberta.ca> wrote:
> Signed-off-by: Cam Macdonell <cam@cs.ualberta.ca>
> ---
> kvm-stub.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/kvm-stub.c b/kvm-stub.c
> index 3378bd3..d45f9fa 100644
> --- a/kvm-stub.c
> +++ b/kvm-stub.c
> @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr, uint16_t val, bool assign)
> {
> return -ENOSYS;
> }
> +
> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool assign)
> +{
> + return -ENOSYS;
> +}
> --
> 1.6.2.5
>
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [Qemu-devel] [PATCH 1/2] RESEND: Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
@ 2010-08-15 9:47 ` Blue Swirl
0 siblings, 0 replies; 20+ messages in thread
From: Blue Swirl @ 2010-08-15 9:47 UTC (permalink / raw)
To: Cam Macdonell; +Cc: qemu-devel, kvm
Thanks, applied.
On Sat, Aug 14, 2010 at 11:47 PM, Cam Macdonell <cam@cs.ualberta.ca> wrote:
> Signed-off-by: Cam Macdonell <cam@cs.ualberta.ca>
> ---
> kvm-stub.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/kvm-stub.c b/kvm-stub.c
> index 3378bd3..d45f9fa 100644
> --- a/kvm-stub.c
> +++ b/kvm-stub.c
> @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr, uint16_t val, bool assign)
> {
> return -ENOSYS;
> }
> +
> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool assign)
> +{
> + return -ENOSYS;
> +}
> --
> 1.6.2.5
>
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
2010-08-14 17:24 ` Andreas Färber
@ 2010-08-14 23:56 ` Cam Macdonell
-1 siblings, 0 replies; 20+ messages in thread
From: Cam Macdonell @ 2010-08-14 23:56 UTC (permalink / raw)
To: Andreas Färber; +Cc: QEMU Developers, kvm, Stefan Weil
On Sat, Aug 14, 2010 at 11:24 AM, Andreas Färber <andreas.faerber@web.de> wrote:
> Am 11.08.2010 um 20:16 schrieb Cam Macdonell:
>
>> ---
>> kvm-stub.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/kvm-stub.c b/kvm-stub.c
>> index 3378bd3..d45f9fa 100644
>> --- a/kvm-stub.c
>> +++ b/kvm-stub.c
>> @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr,
>> uint16_t val, bool assign)
>> {
>> return -ENOSYS;
>> }
>> +
>> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool
>> assign)
>> +{
>> + return -ENOSYS;
>> +}
>> --
>> 1.6.2.5
>
> Acked-by: Andreas Färber <andreas.faerber@web.de>
>
> This fixes linking [1] on Mac OS X.
>
> The patch is missing a Signed-off-by though, same for 2/2.
I've re-sent with the sign-off.
Cam
>
> Andreas
>
> [1]
> LINK i386-softmmu/qemu
> Undefined symbols:
> "_kvm_set_ioeventfd_mmio_long", referenced from:
> _ivshmem_read in ivshmem.o
> _ivshmem_read in ivshmem.o
> _ivshmem_mmio_map in ivshmem.o
> ld: symbol(s) not found
> collect2: ld returned 1 exit status
> make[1]: *** [qemu] Error 1
> make: *** [subdir-i386-softmmu] Error 2
>
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems
@ 2010-08-14 23:56 ` Cam Macdonell
0 siblings, 0 replies; 20+ messages in thread
From: Cam Macdonell @ 2010-08-14 23:56 UTC (permalink / raw)
To: Andreas Färber; +Cc: QEMU Developers, kvm
On Sat, Aug 14, 2010 at 11:24 AM, Andreas Färber <andreas.faerber@web.de> wrote:
> Am 11.08.2010 um 20:16 schrieb Cam Macdonell:
>
>> ---
>> kvm-stub.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/kvm-stub.c b/kvm-stub.c
>> index 3378bd3..d45f9fa 100644
>> --- a/kvm-stub.c
>> +++ b/kvm-stub.c
>> @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr,
>> uint16_t val, bool assign)
>> {
>> return -ENOSYS;
>> }
>> +
>> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool
>> assign)
>> +{
>> + return -ENOSYS;
>> +}
>> --
>> 1.6.2.5
>
> Acked-by: Andreas Färber <andreas.faerber@web.de>
>
> This fixes linking [1] on Mac OS X.
>
> The patch is missing a Signed-off-by though, same for 2/2.
I've re-sent with the sign-off.
Cam
>
> Andreas
>
> [1]
> LINK i386-softmmu/qemu
> Undefined symbols:
> "_kvm_set_ioeventfd_mmio_long", referenced from:
> _ivshmem_read in ivshmem.o
> _ivshmem_read in ivshmem.o
> _ivshmem_mmio_map in ivshmem.o
> ld: symbol(s) not found
> collect2: ld returned 1 exit status
> make[1]: *** [qemu] Error 1
> make: *** [subdir-i386-softmmu] Error 2
>
^ permalink raw reply [flat|nested] 20+ messages in thread