From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org, gcosta@redhat.com, lenb@kernel.org,
mingo@elte.hu, tglx@linutronix.de, ying.huang@intel.com
Subject: Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work-on-i386.patch added to -mm tree
Date: Wed, 11 Aug 2010 18:35:43 -0700 [thread overview]
Message-ID: <4C634FEF.1040503@zytor.com> (raw)
In-Reply-To: <20100811173327.3ae325ff.akpm@linux-foundation.org>
On 08/11/2010 05:33 PM, Andrew Morton wrote:
>
> Not very well.
>
> + rc = copy_from_user(&record_id, (void __user *)arg,
> + sizeof(u64));
>
> better to use sizeof(record_id).
>
> Where's Len??
>
> Anyway, this should be fixed in x86 core, I suspect.
Agreed. Looking at it now.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-08-12 1:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 23:06 + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work-on-i386.patch added to -mm tree akpm
2010-08-11 23:43 ` Randy Dunlap
2010-08-12 0:33 ` Andrew Morton
2010-08-12 0:42 ` Huang Ying
2010-08-12 1:35 ` H. Peter Anvin [this message]
2010-08-12 4:22 ` H. Peter Anvin
2010-08-12 4:30 ` Andrew Morton
2010-08-12 4:42 ` H. Peter Anvin
2010-08-12 5:06 ` H. Peter Anvin
2010-08-12 6:03 ` Andrew Morton
2010-08-12 6:10 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C634FEF.1040503@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=gcosta@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.