From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org, gcosta@redhat.com, lenb@kernel.org,
mingo@elte.hu, tglx@linutronix.de, ying.huang@intel.com,
Linux Arch Mailing List <linux-arch@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work-on-i386.patch added to -mm tree
Date: Wed, 11 Aug 2010 22:06:08 -0700 [thread overview]
Message-ID: <4C638140.1080202@zytor.com> (raw)
In-Reply-To: <20100811213013.ab501c6e.akpm@linux-foundation.org>
On 08/11/2010 09:30 PM, Andrew Morton wrote:
>
> It occurs so rarely that it's probably not worth bothering about, IMO.
>
I think the real question is if we want people to convert:
if (copy_from_user(foo, bar, sizeof *foo))
return -EFAULT;
... into ...
if (get_user(*foo, bar))
return -EFAULT;
... or ...
rv = get_user(*foo, bar);
if (rv)
return rv;
... where *foo is a structure type. It does have the advantage that a
single API does everything, simple or not, but has the disadvantage that
the partial-access semantics are now less explicit.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-08-12 5:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 23:06 + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work-on-i386.patch added to -mm tree akpm
2010-08-11 23:43 ` Randy Dunlap
2010-08-12 0:33 ` Andrew Morton
2010-08-12 0:42 ` Huang Ying
2010-08-12 1:35 ` H. Peter Anvin
2010-08-12 4:22 ` H. Peter Anvin
2010-08-12 4:30 ` Andrew Morton
2010-08-12 4:42 ` H. Peter Anvin
2010-08-12 5:06 ` H. Peter Anvin [this message]
2010-08-12 6:03 ` Andrew Morton
2010-08-12 6:10 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C638140.1080202@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=gcosta@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.