From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org, gcosta@redhat.com, lenb@kernel.org,
mingo@elte.hu, tglx@linutronix.de, ying.huang@intel.com,
Linux Arch Mailing List <linux-arch@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work-on-i386.patch added to -mm tree
Date: Wed, 11 Aug 2010 23:10:43 -0700 [thread overview]
Message-ID: <4C639063.6050505@zytor.com> (raw)
In-Reply-To: <20100811230353.6cb87afd.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
On 08/11/2010 11:03 PM, Andrew Morton wrote:
> <I suspect you can do get_user() on a 4-byte or 8-byte struct right now
> and it'll work>
Not so:
/home/hpa/kernel/linux-2.6-tip.urgent/arch/x86/lib/testuser.c:12: error:
conversion to non-scalar type requested
-hpa
[-- Attachment #2: testuser.c --]
[-- Type: text/x-csrc, Size: 194 bytes --]
#include <linux/types.h>
#include <linux/uaccess.h>
struct foo {
u16 a, b;
};
int bluttan(struct foo *foo)
{
struct foo bar;
if (get_user(bar, foo))
return -1;
return bar.a + bar.b;
}
prev parent reply other threads:[~2010-08-12 6:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 23:06 + drivers-acpi-apei-erst-dbgc-get_useru64-doesnt-work-on-i386.patch added to -mm tree akpm
2010-08-11 23:43 ` Randy Dunlap
2010-08-12 0:33 ` Andrew Morton
2010-08-12 0:42 ` Huang Ying
2010-08-12 1:35 ` H. Peter Anvin
2010-08-12 4:22 ` H. Peter Anvin
2010-08-12 4:30 ` Andrew Morton
2010-08-12 4:42 ` H. Peter Anvin
2010-08-12 5:06 ` H. Peter Anvin
2010-08-12 6:03 ` Andrew Morton
2010-08-12 6:10 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C639063.6050505@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=gcosta@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.