From: Rogan Dawes <rogan@dawes.za.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MTD: Cleanup jffs2/mtdpart headers
Date: Thu, 12 Aug 2010 13:52:19 +0200 [thread overview]
Message-ID: <4C63E073.9040701@dawes.za.net> (raw)
In-Reply-To: <1281613417-19585-1-git-send-email-sr@denx.de>
On 2010/08/12 1:43 PM, Stefan Roese wrote:
> This patch moves some MTD related defines and prototypes from a jffs2
> header to an MTD header. This makes it possible to remove this jffs2
> header inclusion from some files without jffs2 relevance.
>
> Signed-off-by: Stefan Roese<sr@denx.de>
> Cc: Alexander Stein<alexander.stein@systec-electronic.com>
Just two comments.
> +struct part_info {
> + struct list_head link;
> + char *name; /* partition name */
> + u8 auto_name; /* set to 1 for generated name */
> + u32 size; /* total size of the partition */
> + u32 offset; /* offset within device */
> + void *jffs2_priv; /* used internaly by jffs2 */
Should this really be in here? Seems we are mixing things up still.
> /* XXX U-BOOT XXX */
> #if 0
> struct mtd_notifier {
What's up with "#if 0" code in the src?
Rogan
prev parent reply other threads:[~2010-08-12 11:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 11:43 [U-Boot] [PATCH] MTD: Cleanup jffs2/mtdpart headers Stefan Roese
2010-08-12 11:52 ` Rogan Dawes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C63E073.9040701@dawes.za.net \
--to=rogan@dawes.za.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.