* RS485: ioctls defined twice ?
@ 2010-08-15 14:22 ` Claudio Scordino
0 siblings, 0 replies; 5+ messages in thread
From: Claudio Scordino @ 2010-08-15 14:22 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Rick Bronson, Nicolas Ferre, Linux Kernel, Alan Cox, linux-serial
Hi all,
is there any reason why ioctls TIOCGRS485 and TIOCSRS485 are defined (with the same values) in both include/asm-generic/ioctls.h and arch/arm/include/asm/ioctls.h ?
The same happens also for avr32, powerpc and cris (which, however, defines a different value for TIOCSRS485).
Is it duplicated code ?
Or should these values stay in both asm/ioctls.h and asm-generic/ioctls.h ?
Many thanks,
Claudio
^ permalink raw reply [flat|nested] 5+ messages in thread
* RS485: ioctls defined twice ?
@ 2010-08-15 14:22 ` Claudio Scordino
0 siblings, 0 replies; 5+ messages in thread
From: Claudio Scordino @ 2010-08-15 14:22 UTC (permalink / raw)
To: linux-arm-kernel
Hi all,
is there any reason why ioctls TIOCGRS485 and TIOCSRS485 are defined (with the same values) in both include/asm-generic/ioctls.h and arch/arm/include/asm/ioctls.h ?
The same happens also for avr32, powerpc and cris (which, however, defines a different value for TIOCSRS485).
Is it duplicated code ?
Or should these values stay in both asm/ioctls.h and asm-generic/ioctls.h ?
Many thanks,
Claudio
^ permalink raw reply [flat|nested] 5+ messages in thread
* RS485: ioctls defined twice ?
@ 2010-08-15 14:22 ` Claudio Scordino
0 siblings, 0 replies; 5+ messages in thread
From: Claudio Scordino @ 2010-08-15 14:22 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Linux Kernel, Nicolas Ferre, Alan Cox, Rick Bronson, linux-serial
Hi all,
is there any reason why ioctls TIOCGRS485 and TIOCSRS485 are defined (with the same values) in both include/asm-generic/ioctls.h and arch/arm/include/asm/ioctls.h ?
The same happens also for avr32, powerpc and cris (which, however, defines a different value for TIOCSRS485).
Is it duplicated code ?
Or should these values stay in both asm/ioctls.h and asm-generic/ioctls.h ?
Many thanks,
Claudio
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: RS485: ioctls defined twice ?
2010-08-15 14:22 ` Claudio Scordino
@ 2010-08-15 15:38 ` Russell King - ARM Linux
-1 siblings, 0 replies; 5+ messages in thread
From: Russell King - ARM Linux @ 2010-08-15 15:38 UTC (permalink / raw)
To: Claudio Scordino
Cc: linux-arm-kernel, Rick Bronson, Nicolas Ferre, Linux Kernel,
Alan Cox, linux-serial
On Sun, Aug 15, 2010 at 04:22:13PM +0200, Claudio Scordino wrote:
> Hi all,
>
> is there any reason why ioctls TIOCGRS485 and TIOCSRS485 are defined
Please wrap your message sensibly so I can see it while replying to you.
> The same happens also for avr32, powerpc and cris (which, however, defines
>
> Is it duplicated code ?
>
> Or should these values stay in both asm/ioctls.h and asm-generic/ioctls.h ?
As an exercise to help you answer your own question, please research
how asm-generic/ioctls.h get included on an avr32, powerpc, cris or
ARM kernel build.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RS485: ioctls defined twice ?
@ 2010-08-15 15:38 ` Russell King - ARM Linux
0 siblings, 0 replies; 5+ messages in thread
From: Russell King - ARM Linux @ 2010-08-15 15:38 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Aug 15, 2010 at 04:22:13PM +0200, Claudio Scordino wrote:
> Hi all,
>
> is there any reason why ioctls TIOCGRS485 and TIOCSRS485 are defined
Please wrap your message sensibly so I can see it while replying to you.
> The same happens also for avr32, powerpc and cris (which, however, defines
>
> Is it duplicated code ?
>
> Or should these values stay in both asm/ioctls.h and asm-generic/ioctls.h ?
As an exercise to help you answer your own question, please research
how asm-generic/ioctls.h get included on an avr32, powerpc, cris or
ARM kernel build.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-08-15 16:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-15 14:22 RS485: ioctls defined twice ? Claudio Scordino
2010-08-15 14:22 ` Claudio Scordino
2010-08-15 14:22 ` Claudio Scordino
2010-08-15 15:38 ` Russell King - ARM Linux
2010-08-15 15:38 ` Russell King - ARM Linux
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.