[Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup

[Jan Kiszka <jan.kiszka@siemens.com>]

Anthony Liguori wrote:
> On 08/19/2010 03:09 PM, Blue Swirl wrote:
>> On Thu, Aug 19, 2010 at 7:33 PM, Anthony
>> Liguori<anthony@codemonkey.ws>  wrote:
>>   
>>> On 06/12/2010 04:14 PM, Blue Swirl wrote:
>>>     
>>>> Clean up APIC and IOAPIC. Convert both devices to qdev.
>>>>
>>>> v1->v2:
>>>> Remove apic.h reorganization.
>>>> Add IOAPIC and APIC qdev conversions.
>>>> Use CPUState also in 5/7. However on 6/7 we have to again use void *
>>>> because of VMState limitations. VMState gurus, please comment.
>>>>
>>>>        
>>> I'm late to the game here, but I'm not sure converting the APIC to qdev
>>> makes a lot of sense conceptually.
>>>      
>> Very late. I think it makes tons of sense, for example with 'info
>> qtree' you now see most of the QEMU devices. The CPUs are still
>> missing.
>>    
> 
> Should CPUs appear in the QEMU device tree?

Yes, we want to browse/display the whole virtual machine (one day). QMP
could then avoid an equivalent of "info registers" and expose the CPU
state via dumping qdev devices.

And note the the APIC was not part of the CPU core before Pentiums, and
we support that model as well.

Therefore, I like the idea of having a hotplug-capable (where
appropriate) CPU bus.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux