From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>,
stefanha@gmail.com, mjt@tls.msk.ru, qemu-devel@nongnu.org,
hch@lst.de
Subject: [Qemu-devel] Re: [RFC][STABLE 0.13] Revert "qcow2: Use bdrv_(p)write_sync for metadata writes"
Date: Tue, 24 Aug 2010 16:44:43 +0300 [thread overview]
Message-ID: <4C73CCCB.6050704@redhat.com> (raw)
In-Reply-To: <4C73CBD6.7000900@codemonkey.ws>
On 08/24/2010 04:40 PM, Anthony Liguori wrote:
>> 1. Allocate a cluster (increase refcount table)
>>
>> 2. Link cluster to L2 table
>>
>> 3. Second operation makes it to disk; first still in pagecache
>>
>> 4. Crash
>>
>> 5. Dangling pointer from L2 to freed cluster
>
>
> Yes, having this discussion in IRC.
>
> The problem is that we maintain a refcount table.
Are you sure that's the only issue?
> If we didn't do internal disk snapshots, we wouldn't have this
> problem. IOW, VMDK doesn't have this problem so the answer to my very
> first question is that qcow2 is too difficult a format to get right.
One doesn't follow from the other (though I'm no fan of internal
snapshots, myself).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-08-24 13:44 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 10:40 [Qemu-devel] [RFC][STABLE 0.13] Revert "qcow2: Use bdrv_(p)write_sync for metadata writes" Kevin Wolf
2010-08-24 11:02 ` [Qemu-devel] " Stefan Hajnoczi
2010-08-24 11:06 ` Michael Tokarev
2010-08-24 11:40 ` Kevin Wolf
2010-08-24 11:56 ` Alexander Graf
2010-08-24 12:10 ` Kevin Wolf
2010-08-24 12:12 ` Alexander Graf
2010-08-24 12:18 ` Avi Kivity
2010-08-24 12:21 ` Alexander Graf
2010-08-24 12:27 ` Avi Kivity
2010-08-24 12:35 ` Kevin Wolf
2010-08-24 12:39 ` Avi Kivity
2010-08-24 12:53 ` Kevin Wolf
2010-08-24 12:21 ` Stefan Hajnoczi
2010-08-24 12:23 ` Michael Tokarev
2010-08-24 12:48 ` Juan Quintela
2010-08-24 13:01 ` Anthony Liguori
2010-08-24 13:16 ` Kevin Wolf
2010-08-24 13:29 ` Anthony Liguori
2010-08-24 13:31 ` Avi Kivity
2010-08-24 13:35 ` Anthony Liguori
2010-08-24 13:39 ` Avi Kivity
2010-08-24 13:40 ` Anthony Liguori
2010-08-24 13:44 ` Avi Kivity [this message]
2010-08-24 13:56 ` Anthony Liguori
2010-08-25 7:14 ` Avi Kivity
2010-08-25 12:46 ` Anthony Liguori
2010-08-25 13:07 ` Avi Kivity
2010-08-25 13:37 ` Anthony Liguori
2010-08-25 13:23 ` Avi Kivity
2010-08-25 13:42 ` Anthony Liguori
2010-08-25 14:00 ` Avi Kivity
2010-08-25 14:14 ` Anthony Liguori
2010-08-25 14:36 ` Avi Kivity
2010-08-25 15:06 ` Anthony Liguori
2010-08-25 15:15 ` Avi Kivity
2010-08-25 15:21 ` Anthony Liguori
2010-08-25 13:46 ` Anthony Liguori
2010-08-25 14:03 ` Avi Kivity
2010-08-25 14:19 ` Christoph Hellwig
2010-08-25 14:37 ` Avi Kivity
2010-08-25 14:18 ` Christoph Hellwig
2010-08-25 14:26 ` Anthony Liguori
2010-08-25 14:49 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C73CCCB.6050704@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.