All of lore.kernel.org
 help / color / mirror / Atom feed
* [refpolicy] roles_dbadm.patch
@ 2010-02-23 19:38 Daniel J Walsh
  2010-03-04 14:26 ` Christopher J. PeBenito
  0 siblings, 1 reply; 6+ messages in thread
From: Daniel J Walsh @ 2010-02-23 19:38 UTC (permalink / raw)
  To: refpolicy

http://people.fedoraproject.org/~dwalsh/SELinux/F13/roles_dbadm.patch

typo in dbadm.if

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [refpolicy] roles_dbadm.patch
  2010-02-23 19:38 Daniel J Walsh
@ 2010-03-04 14:26 ` Christopher J. PeBenito
  0 siblings, 0 replies; 6+ messages in thread
From: Christopher J. PeBenito @ 2010-03-04 14:26 UTC (permalink / raw)
  To: refpolicy

On Tue, 2010-02-23 at 14:38 -0500, Daniel J Walsh wrote:
> http://people.fedoraproject.org/~dwalsh/SELinux/F13/roles_dbadm.patch
> 
> typo in dbadm.if

Merged.

-- 
Chris PeBenito
Tresys Technology, LLC
(410) 290-1411 x150

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [refpolicy] roles_dbadm.patch
@ 2010-08-26 22:31 Daniel J Walsh
  2010-08-27  7:31 ` KaiGai Kohei
  0 siblings, 1 reply; 6+ messages in thread
From: Daniel J Walsh @ 2010-08-26 22:31 UTC (permalink / raw)
  To: refpolicy

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

http://people.fedoraproject.org/~dwalsh/SELinux/F14/roles_dbadm.patch

Add sudo for transition from staff.

I think this should not be a login domain.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkx26z4ACgkQrlYvE4MpobO3MACdEJvxr8B2Wq6ukvZ6O3yNVR3g
Ux8An1Sr318SZEbxPX9aWmiakKWnSlgO
=OUZK
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [refpolicy] roles_dbadm.patch
  2010-08-26 22:31 [refpolicy] roles_dbadm.patch Daniel J Walsh
@ 2010-08-27  7:31 ` KaiGai Kohei
  2010-08-27 13:24   ` Daniel J Walsh
  0 siblings, 1 reply; 6+ messages in thread
From: KaiGai Kohei @ 2010-08-27  7:31 UTC (permalink / raw)
  To: refpolicy

(2010/08/27 7:31), Daniel J Walsh wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> http://people.fedoraproject.org/~dwalsh/SELinux/F14/roles_dbadm.patch
> 
> Add sudo for transition from staff.
> 
> I think this should not be a login domain.

| --- a/policy/modules/roles/dbadm.te
| +++ b/policy/modules/roles/dbadm.te
| @@ -21,7 +21,7 @@ gen_tunable(dbadm_read_user_files, false)
|
|  role dbadm_r;
|
| -userdom_base_user_template(dbadm)
| +userdom_unpriv_user_template(dbadm)
|
|  ########################################
|  #

The userdom_unpriv_user_template() contains userdom_login_user_template()
which allows dbadm_t performs as a login domain.
It is not what you intend, is it?

In the latest refpolicy, dbadm is declared with userdom_base_user_template().

| @@ -58,3 +58,7 @@ optional_policy(`
|  optional_policy(`
|  	postgresql_admin(dbadm_t, dbadm_r)
|  ')
| +
| +optional_policy(`
| +	sudo_role_template(dbadm, dbadm_r, dbadm_t)
| +')
| diff --git a/policy/modules/roles/guest.te b/policy/modules/roles/guest.te
| index 531c616..321e5a7 100644

Also, it was already merged in the latest refpolicy.

BTW, could you add the dbadm.pp into selinux-policy package?
IIRC, you concerned about dbadm_t is declared as login domain.

Thanks,
-- 
KaiGai Kohei <kaigai@ak.jp.nec.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [refpolicy] roles_dbadm.patch
  2010-08-27  7:31 ` KaiGai Kohei
@ 2010-08-27 13:24   ` Daniel J Walsh
  2010-08-27 13:27     ` Dominick Grift
  0 siblings, 1 reply; 6+ messages in thread
From: Daniel J Walsh @ 2010-08-27 13:24 UTC (permalink / raw)
  To: refpolicy

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/27/2010 03:31 AM, KaiGai Kohei wrote:
> (2010/08/27 7:31), Daniel J Walsh wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> http://people.fedoraproject.org/~dwalsh/SELinux/F14/roles_dbadm.patch
>>
>> Add sudo for transition from staff.
>>
>> I think this should not be a login domain.
> 
> | --- a/policy/modules/roles/dbadm.te
> | +++ b/policy/modules/roles/dbadm.te
> | @@ -21,7 +21,7 @@ gen_tunable(dbadm_read_user_files, false)
> |
> |  role dbadm_r;
> |
> | -userdom_base_user_template(dbadm)
> | +userdom_unpriv_user_template(dbadm)
> |
> |  ########################################
> |  #
> 
> The userdom_unpriv_user_template() contains userdom_login_user_template()
> which allows dbadm_t performs as a login domain.
> It is not what you intend, is it?
> 
No my mistake.  I reversed the patch.  It should be

userdom_base_user_template(dbadm)
> In the latest refpolicy, dbadm is declared with userdom_base_user_template().
> 
> | @@ -58,3 +58,7 @@ optional_policy(`
> |  optional_policy(`
> |  	postgresql_admin(dbadm_t, dbadm_r)
> |  ')
> | +
> | +optional_policy(`
> | +	sudo_role_template(dbadm, dbadm_r, dbadm_t)
> | +')
> | diff --git a/policy/modules/roles/guest.te b/policy/modules/roles/guest.te
> | index 531c616..321e5a7 100644
> 
> Also, it was already merged in the latest refpolicy.
> 
Not in the refpolicy I am looking at.
> BTW, could you add the dbadm.pp into selinux-policy package?
> IIRC, you concerned about dbadm_t is declared as login domain.
> 
> Thanks,

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkx3vJEACgkQrlYvE4MpobNNdACg0A2PnKxkWKw1g8c/+9CRgfDD
DIUAnjhKbG2F60UQ3V23FZrbalzLl0Sl
=knMn
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [refpolicy] roles_dbadm.patch
  2010-08-27 13:24   ` Daniel J Walsh
@ 2010-08-27 13:27     ` Dominick Grift
  0 siblings, 0 replies; 6+ messages in thread
From: Dominick Grift @ 2010-08-27 13:27 UTC (permalink / raw)
  To: refpolicy

On 08/27/2010 03:24 PM, Daniel J Walsh wrote:
> On 08/27/2010 03:31 AM, KaiGai Kohei wrote:
>> (2010/08/27 7:31), Daniel J Walsh wrote:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> http://people.fedoraproject.org/~dwalsh/SELinux/F14/roles_dbadm.patch
>>>
>>> Add sudo for transition from staff.
>>>
>>> I think this should not be a login domain.
> 
>> | --- a/policy/modules/roles/dbadm.te
>> | +++ b/policy/modules/roles/dbadm.te
>> | @@ -21,7 +21,7 @@ gen_tunable(dbadm_read_user_files, false)
>> |
>> |  role dbadm_r;
>> |
>> | -userdom_base_user_template(dbadm)
>> | +userdom_unpriv_user_template(dbadm)
>> |
>> |  ########################################
>> |  #
> 
>> The userdom_unpriv_user_template() contains userdom_login_user_template()
>> which allows dbadm_t performs as a login domain.
>> It is not what you intend, is it?
> 
> No my mistake.  I reversed the patch.  It should be
> 
> userdom_base_user_template(dbadm)
>> In the latest refpolicy, dbadm is declared with userdom_base_user_template().
> 
>> | @@ -58,3 +58,7 @@ optional_policy(`
>> |  optional_policy(`
>> |  	postgresql_admin(dbadm_t, dbadm_r)
>> |  ')
>> | +
>> | +optional_policy(`
>> | +	sudo_role_template(dbadm, dbadm_r, dbadm_t)
>> | +')
>> | diff --git a/policy/modules/roles/guest.te b/policy/modules/roles/guest.te
>> | index 531c616..321e5a7 100644
> 
>> Also, it was already merged in the latest refpolicy.
> 
> Not in the refpolicy I am looking at.

http://oss.tresys.com/projects/refpolicy/changeset/c62f1bef77c839295b49bdddc7bfd13df780bf4e


>> BTW, could you add the dbadm.pp into selinux-policy package?
>> IIRC, you concerned about dbadm_t is declared as login domain.
> 
>> Thanks,
> 
_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
Url : http://oss.tresys.com/pipermail/refpolicy/attachments/20100827/f6f0a76e/attachment-0001.bin 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-08-27 13:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-26 22:31 [refpolicy] roles_dbadm.patch Daniel J Walsh
2010-08-27  7:31 ` KaiGai Kohei
2010-08-27 13:24   ` Daniel J Walsh
2010-08-27 13:27     ` Dominick Grift
  -- strict thread matches above, loose matches on Subject: below --
2010-02-23 19:38 Daniel J Walsh
2010-03-04 14:26 ` Christopher J. PeBenito

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.