linux-omap-psp-2.6.32 breaks iscsi-target

linux-omap-psp-2.6.32 breaks iscsi-target

[Frans Meulenbroeks]

The current beagleboard angstrom and minimal distro's (and maybe
others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.

This one says:
# This is the v2.6.32_OMAPPSP_03.00.01.06 branch
SRCREV = "a6bad4464f985fdd3bed72e1b82dcbfc004d7869"

# The main PR is now using MACHINE_KERNEL_PR, for omap3 see
conf/machine/include/omap3.inc
MACHINE_KERNEL_PR_append = "+gitr${SRCREV}"

SRC_URI = "git://arago-project.org/git/people/sriram/ti-psp-omap.git;protocol=git;branch=master
\

Building it creates:
linux-omap-psp-2.6.32-r88+gitra6bad4464f985fdd3bed72e1b82dcbfc004d7869

However this is not a sound 2.6.32 tree. It contains this patch
http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=commit;h=c720c7e8383aff1cb219bddf474ed89d850336e3
which was not in the mainstream kernel in 2.6.32

(compare
http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=blob;f=include/net/inet_sock.h;hb=c720c7e8383aff1cb219bddf474ed89d850336e3
with
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=blob;f=include/net/inet_sock.h;h=47004f35cc7eaf6f2b3cac2779ea7b7ccd5d9c1f;hb=HEAD
).

The patch mentioned above was integrated in a 2.6.33 rc version.

iscsi-utils uses the inet_sock struct, and contains code to access the
daddr field of this struct. For versions <= .32 daddr is used. for
higher versions inet_daddr is used.
However the omap-psp kernel from arago does contain this patch  but
reports as a .32 kernel causing a compiler errir when compiling
iscsi_target (as the name the recipe expects is not there).

Not sure how to fix it. Changing the test in iscsi-target is not an
option as then it does not work for official .32 kernels.
Probably the best way to fix this is to use the above patch to revert
the change.

anyone a better solution?

Frans

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[Philip Balister]

On 08/30/2010 01:47 PM, Frans Meulenbroeks wrote:
> The current beagleboard angstrom and minimal distro's (and maybe
> others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.

What is iscsi and why would I need it on the Beagleboard?

Philip

>
> This one says:
> # This is the v2.6.32_OMAPPSP_03.00.01.06 branch
> SRCREV = "a6bad4464f985fdd3bed72e1b82dcbfc004d7869"
>
> # The main PR is now using MACHINE_KERNEL_PR, for omap3 see
> conf/machine/include/omap3.inc
> MACHINE_KERNEL_PR_append = "+gitr${SRCREV}"
>
> SRC_URI = "git://arago-project.org/git/people/sriram/ti-psp-omap.git;protocol=git;branch=master
> \
>
> Building it creates:
> linux-omap-psp-2.6.32-r88+gitra6bad4464f985fdd3bed72e1b82dcbfc004d7869
>
> However this is not a sound 2.6.32 tree. It contains this patch
> http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=commit;h=c720c7e8383aff1cb219bddf474ed89d850336e3
> which was not in the mainstream kernel in 2.6.32
>
> (compare
> http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=blob;f=include/net/inet_sock.h;hb=c720c7e8383aff1cb219bddf474ed89d850336e3
> with
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=blob;f=include/net/inet_sock.h;h=47004f35cc7eaf6f2b3cac2779ea7b7ccd5d9c1f;hb=HEAD
> ).
>
> The patch mentioned above was integrated in a 2.6.33 rc version.
>
> iscsi-utils uses the inet_sock struct, and contains code to access the
> daddr field of this struct. For versions<= .32 daddr is used. for
> higher versions inet_daddr is used.
> However the omap-psp kernel from arago does contain this patch  but
> reports as a .32 kernel causing a compiler errir when compiling
> iscsi_target (as the name the recipe expects is not there).
>
> Not sure how to fix it. Changing the test in iscsi-target is not an
> option as then it does not work for official .32 kernels.
> Probably the best way to fix this is to use the above patch to revert
> the change.
>
> anyone a better solution?
>
> Frans
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[Frans Meulenbroeks]

2010/8/30 Philip Balister <philip@balister.org>:
> On 08/30/2010 01:47 PM, Frans Meulenbroeks wrote:
>>
>> The current beagleboard angstrom and minimal distro's (and maybe
>> others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.
>
> What is iscsi and why would I need it on the Beagleboard?

http://stgt.sourceforge.net/

the pacakge is from
http://iscsitarget.sourceforge.net/
It is used by tgt (http://stgt.sourceforge.net/)

with it you can e.g. mount an iscsi disk.
iscsi is for instance also supported by windows 7 and by various NAS-es.
Its throughput is better than Samba or NFS.

So for beagle it could act as mechanism to e.g. retrieve content from a NAS.

Frans.

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[Philip Balister]

On 08/30/2010 02:35 PM, Frans Meulenbroeks wrote:
> 2010/8/30 Philip Balister<philip@balister.org>:
>> On 08/30/2010 01:47 PM, Frans Meulenbroeks wrote:
>>>
>>> The current beagleboard angstrom and minimal distro's (and maybe
>>> others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.
>>
>> What is iscsi and why would I need it on the Beagleboard?
>
> http://stgt.sourceforge.net/
>
> the pacakge is from
> http://iscsitarget.sourceforge.net/
> It is used by tgt (http://stgt.sourceforge.net/)
>
> with it you can e.g. mount an iscsi disk.
> iscsi is for instance also supported by windows 7 and by various NAS-es.
> Its throughput is better than Samba or NFS.
>
> So for beagle it could act as mechanism to e.g. retrieve content from a NAS.

So the trade off is a kernel that has the best chance of fully 
supporting the OMAP3 peripherals, or attaching to a NAS that is windows 
centric.

The point I am trying to make is we can't expect all packages to build 
for every MACHINE/DISTRO combination. People have to make tradeoffs.

Philip

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[J. L.]

Why is it bad to expect all packages build for all the machine/distro
? I would think that would be a more "ideal" situation especially if
its a supported machine and distro



On Mon, Aug 30, 2010 at 11:40 AM, Philip Balister <philip@balister.org> wrote:
> On 08/30/2010 02:35 PM, Frans Meulenbroeks wrote:
>>
>> 2010/8/30 Philip Balister<philip@balister.org>:
>>>
>>> On 08/30/2010 01:47 PM, Frans Meulenbroeks wrote:
>>>>
>>>> The current beagleboard angstrom and minimal distro's (and maybe
>>>> others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.
>>>
>>> What is iscsi and why would I need it on the Beagleboard?
>>
>> http://stgt.sourceforge.net/
>>
>> the pacakge is from
>> http://iscsitarget.sourceforge.net/
>> It is used by tgt (http://stgt.sourceforge.net/)
>>
>> with it you can e.g. mount an iscsi disk.
>> iscsi is for instance also supported by windows 7 and by various NAS-es.
>> Its throughput is better than Samba or NFS.
>>
>> So for beagle it could act as mechanism to e.g. retrieve content from a
>> NAS.
>
> So the trade off is a kernel that has the best chance of fully supporting
> the OMAP3 peripherals, or attaching to a NAS that is windows centric.
>
> The point I am trying to make is we can't expect all packages to build for
> every MACHINE/DISTRO combination. People have to make tradeoffs.
>
> Philip
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[Philip Balister]

On 08/30/2010 02:49 PM, J. L. wrote:
> Why is it bad to expect all packages build for all the machine/distro
> ? I would think that would be a more "ideal" situation especially if
> its a supported machine and distro

It is not bad. But we have a lot of packages and the people maintaining 
stuff have limited time. Hopefully the TI kernel guys can find a way to 
fix the issue Frans pointed out.

Philip

>
>
>
> On Mon, Aug 30, 2010 at 11:40 AM, Philip Balister<philip@balister.org>  wrote:
>> On 08/30/2010 02:35 PM, Frans Meulenbroeks wrote:
>>>
>>> 2010/8/30 Philip Balister<philip@balister.org>:
>>>>
>>>> On 08/30/2010 01:47 PM, Frans Meulenbroeks wrote:
>>>>>
>>>>> The current beagleboard angstrom and minimal distro's (and maybe
>>>>> others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.
>>>>
>>>> What is iscsi and why would I need it on the Beagleboard?
>>>
>>> http://stgt.sourceforge.net/
>>>
>>> the pacakge is from
>>> http://iscsitarget.sourceforge.net/
>>> It is used by tgt (http://stgt.sourceforge.net/)
>>>
>>> with it you can e.g. mount an iscsi disk.
>>> iscsi is for instance also supported by windows 7 and by various NAS-es.
>>> Its throughput is better than Samba or NFS.
>>>
>>> So for beagle it could act as mechanism to e.g. retrieve content from a
>>> NAS.
>>
>> So the trade off is a kernel that has the best chance of fully supporting
>> the OMAP3 peripherals, or attaching to a NAS that is windows centric.
>>
>> The point I am trying to make is we can't expect all packages to build for
>> every MACHINE/DISTRO combination. People have to make tradeoffs.
>>
>> Philip
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[J. L.]

Got ya thanks for taking the time to explain it.

On Mon, Aug 30, 2010 at 12:23 PM, Philip Balister <philip@balister.org> wrote:
> On 08/30/2010 02:49 PM, J. L. wrote:
>>
>> Why is it bad to expect all packages build for all the machine/distro
>> ? I would think that would be a more "ideal" situation especially if
>> its a supported machine and distro
>
> It is not bad. But we have a lot of packages and the people maintaining
> stuff have limited time. Hopefully the TI kernel guys can find a way to fix
> the issue Frans pointed out.
>
> Philip
>
>>
>>
>>
>> On Mon, Aug 30, 2010 at 11:40 AM, Philip Balister<philip@balister.org>
>>  wrote:
>>>
>>> On 08/30/2010 02:35 PM, Frans Meulenbroeks wrote:
>>>>
>>>> 2010/8/30 Philip Balister<philip@balister.org>:
>>>>>
>>>>> On 08/30/2010 01:47 PM, Frans Meulenbroeks wrote:
>>>>>>
>>>>>> The current beagleboard angstrom and minimal distro's (and maybe
>>>>>> others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.
>>>>>
>>>>> What is iscsi and why would I need it on the Beagleboard?
>>>>
>>>> http://stgt.sourceforge.net/
>>>>
>>>> the pacakge is from
>>>> http://iscsitarget.sourceforge.net/
>>>> It is used by tgt (http://stgt.sourceforge.net/)
>>>>
>>>> with it you can e.g. mount an iscsi disk.
>>>> iscsi is for instance also supported by windows 7 and by various NAS-es.
>>>> Its throughput is better than Samba or NFS.
>>>>
>>>> So for beagle it could act as mechanism to e.g. retrieve content from a
>>>> NAS.
>>>
>>> So the trade off is a kernel that has the best chance of fully supporting
>>> the OMAP3 peripherals, or attaching to a NAS that is windows centric.
>>>
>>> The point I am trying to make is we can't expect all packages to build
>>> for
>>> every MACHINE/DISTRO combination. People have to make tradeoffs.
>>>
>>> Philip
>>>
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[Frans Meulenbroeks]

2010/8/30 Philip Balister <philip@balister.org>:
> On 08/30/2010 02:49 PM, J. L. wrote:
>>
>> Why is it bad to expect all packages build for all the machine/distro
>> ? I would think that would be a more "ideal" situation especially if
>> its a supported machine and distro
>
> It is not bad. But we have a lot of packages and the people maintaining
> stuff have limited time. Hopefully the TI kernel guys can find a way to fix
> the issue Frans pointed out.
>
> Philip

I understand that people have limited time.

What happened is that I bumped into a problem, I analyzed it and I
reported my findings, and suggested a way to fix it.
I can develop a patch if needed, but before investing time in that, I
would like to learn if there are better/more desirable solutions, and
whether a patch has a fair chance on getting accepted.
(btw I can see some other options, .e.g. maybe a #define could be
added in the .h file, but that is probably less desirable. there are
probably more alternatives)

Frans

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[Frans Meulenbroeks]

2010/8/30 Philip Balister <philip@balister.org>:
> On 08/30/2010 02:35 PM, Frans Meulenbroeks wrote:
>>
>> 2010/8/30 Philip Balister<philip@balister.org>:
>>>
>>> On 08/30/2010 01:47 PM, Frans Meulenbroeks wrote:
>>>>
>>>> The current beagleboard angstrom and minimal distro's (and maybe
>>>> others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.
>>>
>>> What is iscsi and why would I need it on the Beagleboard?
>>
>> http://stgt.sourceforge.net/
>>
>> the pacakge is from
>> http://iscsitarget.sourceforge.net/
>> It is used by tgt (http://stgt.sourceforge.net/)
>>
>> with it you can e.g. mount an iscsi disk.
>> iscsi is for instance also supported by windows 7 and by various NAS-es.
>> Its throughput is better than Samba or NFS.
>>
>> So for beagle it could act as mechanism to e.g. retrieve content from a
>> NAS.
>
> So the trade off is a kernel that has the best chance of fully supporting
> the OMAP3 peripherals, or attaching to a NAS that is windows centric.

If you had taken the time to read the links I gave you would know it
is absolutely not windows centric. Far from that.
And I am not saying we should change the kernel. Probably the best
solution is to have a patch that undoes the effects from the .33 patch
that crept into the kernel.
Another option could be to give the kernel a different version number.
It is not a real .32 kernel, but probably making it .33 rc1 is not a
good choice either.

Btw I have no idea what other packages are broken due to this.
>
> The point I am trying to make is we can't expect all packages to build for
> every MACHINE/DISTRO combination. People have to make tradeoffs.
>
Yes, and if fixes are possible then why not repair things.
I think being able to access an iscsi nas could be beneficial.
(e.g. when using the beagle as a mythtv frontend)

Frans

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[Tom Rini]

Frans Meulenbroeks wrote:
> 2010/8/30 Philip Balister <philip@balister.org>:
>> On 08/30/2010 02:35 PM, Frans Meulenbroeks wrote:
>>> 2010/8/30 Philip Balister<philip@balister.org>:
>>>> On 08/30/2010 01:47 PM, Frans Meulenbroeks wrote:
>>>>> The current beagleboard angstrom and minimal distro's (and maybe
>>>>> others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.
>>>> What is iscsi and why would I need it on the Beagleboard?
>>> http://stgt.sourceforge.net/
>>>
>>> the pacakge is from
>>> http://iscsitarget.sourceforge.net/
>>> It is used by tgt (http://stgt.sourceforge.net/)
>>>
>>> with it you can e.g. mount an iscsi disk.
>>> iscsi is for instance also supported by windows 7 and by various NAS-es.
>>> Its throughput is better than Samba or NFS.
>>>
>>> So for beagle it could act as mechanism to e.g. retrieve content from a
>>> NAS.
>> So the trade off is a kernel that has the best chance of fully supporting
>> the OMAP3 peripherals, or attaching to a NAS that is windows centric.
> 
> If you had taken the time to read the links I gave you would know it
> is absolutely not windows centric. Far from that.
> And I am not saying we should change the kernel. Probably the best
> solution is to have a patch that undoes the effects from the .33 patch
> that crept into the kernel.
> Another option could be to give the kernel a different version number.
> It is not a real .32 kernel, but probably making it .33 rc1 is not a
> good choice either.

In other words we have the very real problem of when you use a -rc 
kernel, internal APIs aren't consistent with the real world and someone 
should strongly re-evaluate what the best kernel revision to use here is 
given that it's not .32 and not .33 but .33-rc1 or so.  Maybe it 
shouldn't be D_P = 1 until it's based on a release kernel version?

-- 
Tom Rini
Mentor Graphics Corporation

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 30-08-10 19:47, Frans Meulenbroeks wrote:
> The current beagleboard angstrom and minimal distro's (and maybe
> others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.
> 
> This one says:
> # This is the v2.6.32_OMAPPSP_03.00.01.06 branch
> SRCREV = "a6bad4464f985fdd3bed72e1b82dcbfc004d7869"
> 
> # The main PR is now using MACHINE_KERNEL_PR, for omap3 see
> conf/machine/include/omap3.inc
> MACHINE_KERNEL_PR_append = "+gitr${SRCREV}"
> 
> SRC_URI = "git://arago-project.org/git/people/sriram/ti-psp-omap.git;protocol=git;branch=master
> \
> 
> Building it creates:
> linux-omap-psp-2.6.32-r88+gitra6bad4464f985fdd3bed72e1b82dcbfc004d7869
> 
> However this is not a sound 2.6.32 tree. It contains this patch
> http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=commit;h=c720c7e8383aff1cb219bddf474ed89d850336e3
> which was not in the mainstream kernel in 2.6.32

What a surprise, a vendor kernel has patches that aren't in mainline linux!

> (compare
> http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=blob;f=include/net/inet_sock.h;hb=c720c7e8383aff1cb219bddf474ed89d850336e3
> with
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=blob;f=include/net/inet_sock.h;h=47004f35cc7eaf6f2b3cac2779ea7b7ccd5d9c1f;hb=HEAD
> ).
> 
> The patch mentioned above was integrated in a 2.6.33 rc version.
> 
> iscsi-utils uses the inet_sock struct, and contains code to access the
> daddr field of this struct. For versions <= .32 daddr is used. for
> higher versions inet_daddr is used.
> However the omap-psp kernel from arago does contain this patch  but
> reports as a .32 kernel causing a compiler errir when compiling
> iscsi_target (as the name the recipe expects is not there).
> 
> Not sure how to fix it. Changing the test in iscsi-target is not an
> option as then it does not work for official .32 kernels.
> Probably the best way to fix this is to use the above patch to revert
> the change.
> 
> anyone a better solution?

I can tell you right now that patching the psp kernel will not be
accepted, so patching the iscsi recipe is the way to go.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMfL2iMkyGM64RGpERAnaBAJ4glYrqGU/BeU7lh2TjOzBwkXF8ewCeNqyI
4wpc1emvnlEv5xsgE6HhqLY=
=H4DQ
-----END PGP SIGNATURE-----

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[Frans Meulenbroeks]

2010/8/31 Koen Kooi <k.kooi@student.utwente.nl>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 30-08-10 19:47, Frans Meulenbroeks wrote:
>> The current beagleboard angstrom and minimal distro's (and maybe
>> others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.
>>
>> This one says:
>> # This is the v2.6.32_OMAPPSP_03.00.01.06 branch
>> SRCREV = "a6bad4464f985fdd3bed72e1b82dcbfc004d7869"
>>
>> # The main PR is now using MACHINE_KERNEL_PR, for omap3 see
>> conf/machine/include/omap3.inc
>> MACHINE_KERNEL_PR_append = "+gitr${SRCREV}"
>>
>> SRC_URI = "git://arago-project.org/git/people/sriram/ti-psp-omap.git;protocol=git;branch=master
>> \
>>
>> Building it creates:
>> linux-omap-psp-2.6.32-r88+gitra6bad4464f985fdd3bed72e1b82dcbfc004d7869
>>
>> However this is not a sound 2.6.32 tree. It contains this patch
>> http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=commit;h=c720c7e8383aff1cb219bddf474ed89d850336e3
>> which was not in the mainstream kernel in 2.6.32
>
> What a surprise, a vendor kernel has patches that aren't in mainline linux.

Well the surprise is not that a vendor kernel has patches that are not
mainlined. Actually I expect vendor specific patches in such a kernel.
The surprise is that this kernel advertises itself as 2.6.32, yet has
2.6.33 patches integrated that are non-vendor related at all.

And surprise or no surprise, what happened is that I encountered a
problem in a recipe I maintain in conjunction with a platform that
used to support this.
(actually both the iscsi-target package and the tgt package appear on
the angstrom feed for armv7a)

I've analysed the problem, figured that there is no good way to
resolve this in the package and that the root cause is a kernel that
advertises itself as 2.6.32 but is not compliant with it.
Therefore I report the problem. I actually offered to work on a patch.

However, instead of appreciating the fact that someone reports an
incompatibility so that it is known, some people seem to prefer to
shoot the messenger. :-(
Great piece of teamwork!

>
>> (compare
>> http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=blob;f=include/net/inet_sock.h;hb=c720c7e8383aff1cb219bddf474ed89d850336e3
>> with
>> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=blob;f=include/net/inet_sock.h;h=47004f35cc7eaf6f2b3cac2779ea7b7ccd5d9c1f;hb=HEAD
>> ).
>>
>> The patch mentioned above was integrated in a 2.6.33 rc version.
>>
>> iscsi-utils uses the inet_sock struct, and contains code to access the
>> daddr field of this struct. For versions <= .32 daddr is used. for
>> higher versions inet_daddr is used.
>> However the omap-psp kernel from arago does contain this patch  but
>> reports as a .32 kernel causing a compiler errir when compiling
>> iscsi_target (as the name the recipe expects is not there).
>>
>> Not sure how to fix it. Changing the test in iscsi-target is not an
>> option as then it does not work for official .32 kernels.
>> Probably the best way to fix this is to use the above patch to revert
>> the change.
>>
>> anyone a better solution?
>
> I can tell you right now that patching the psp kernel will not be
> accepted, so patching the iscsi recipe is the way to go.

iscsi-target cannot fix this in a reasonable way. If I saw a decent
fix (which does not break things for other .32 kernels), I would have
done it.
A patch for the psp kernel would be very simple. We're only talking
about a patch (which could be in oe, not in arago) to give the struct
fields the name that they should have according to 2.6.32).
Functionally this is a zero-impact patch.

Then again, the flexibility, open-minded-ness and customer
friendliness of some of our developers is already known to me, so I
kind-a expected this reaction (which is also why I posted this before
spending time to develop a patch).

Anyway, I already lost interest in resolving this. I can make it work
locally for me, no problem with that, and I'll add DP of -1 for
beagleboard to the iscsi-target recipe with an explanatory note.

Have a nice day.
Frans

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[Graeme Gregory]

 On 31/08/10 10:17, Frans Meulenbroeks wrote:
> 2010/8/31 Koen Kooi <k.kooi@student.utwente.nl>:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 30-08-10 19:47, Frans Meulenbroeks wrote:
>>> The current beagleboard angstrom and minimal distro's (and maybe
>>> others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.
>>>
>>> This one says:
>>> # This is the v2.6.32_OMAPPSP_03.00.01.06 branch
>>> SRCREV = "a6bad4464f985fdd3bed72e1b82dcbfc004d7869"
>>>
>>> # The main PR is now using MACHINE_KERNEL_PR, for omap3 see
>>> conf/machine/include/omap3.inc
>>> MACHINE_KERNEL_PR_append = "+gitr${SRCREV}"
>>>
>>> SRC_URI = "git://arago-project.org/git/people/sriram/ti-psp-omap.git;protocol=git;branch=master
>>> \
>>>
>>> Building it creates:
>>> linux-omap-psp-2.6.32-r88+gitra6bad4464f985fdd3bed72e1b82dcbfc004d7869
>>>
>>> However this is not a sound 2.6.32 tree. It contains this patch
>>> http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=commit;h=c720c7e8383aff1cb219bddf474ed89d850336e3
>>> which was not in the mainstream kernel in 2.6.32
>> What a surprise, a vendor kernel has patches that aren't in mainline linux.
> Well the surprise is not that a vendor kernel has patches that are not
> mainlined. Actually I expect vendor specific patches in such a kernel.
> The surprise is that this kernel advertises itself as 2.6.32, yet has
> 2.6.33 patches integrated that are non-vendor related at all.
>
> And surprise or no surprise, what happened is that I encountered a
> problem in a recipe I maintain in conjunction with a platform that
> used to support this.
> (actually both the iscsi-target package and the tgt package appear on
> the angstrom feed for armv7a)
>
> I've analysed the problem, figured that there is no good way to
> resolve this in the package and that the root cause is a kernel that
> advertises itself as 2.6.32 but is not compliant with it.
> Therefore I report the problem. I actually offered to work on a patch.
>
> However, instead of appreciating the fact that someone reports an
> incompatibility so that it is known, some people seem to prefer to
> shoot the messenger. :-(
> Great piece of teamwork!
>
>>> (compare
>>> http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=blob;f=include/net/inet_sock.h;hb=c720c7e8383aff1cb219bddf474ed89d850336e3
>>> with
>>> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=blob;f=include/net/inet_sock.h;h=47004f35cc7eaf6f2b3cac2779ea7b7ccd5d9c1f;hb=HEAD
>>> ).
>>>
>>> The patch mentioned above was integrated in a 2.6.33 rc version.
>>>
>>> iscsi-utils uses the inet_sock struct, and contains code to access the
>>> daddr field of this struct. For versions <= .32 daddr is used. for
>>> higher versions inet_daddr is used.
>>> However the omap-psp kernel from arago does contain this patch  but
>>> reports as a .32 kernel causing a compiler errir when compiling
>>> iscsi_target (as the name the recipe expects is not there).
>>>
>>> Not sure how to fix it. Changing the test in iscsi-target is not an
>>> option as then it does not work for official .32 kernels.
>>> Probably the best way to fix this is to use the above patch to revert
>>> the change.
>>>
>>> anyone a better solution?
>> I can tell you right now that patching the psp kernel will not be
>> accepted, so patching the iscsi recipe is the way to go.
> iscsi-target cannot fix this in a reasonable way. If I saw a decent
> fix (which does not break things for other .32 kernels), I would have
> done it.
> A patch for the psp kernel would be very simple. We're only talking
> about a patch (which could be in oe, not in arago) to give the struct
> fields the name that they should have according to 2.6.32).
> Functionally this is a zero-impact patch.
>
> Then again, the flexibility, open-minded-ness and customer
> friendliness of some of our developers is already known to me, so I
> kind-a expected this reaction (which is also why I posted this before
> spending time to develop a patch).
>
> Anyway, I already lost interest in resolving this. I can make it work
> locally for me, no problem with that, and I'll add DP of -1 for
> beagleboard to the iscsi-target recipe with an explanatory note.
>
There is no such thing as a stable kernel anymore, all 2.6.XX releases
are classed as unstable, it is upto vendors to stabalise and select API/ABI.

Graeme

Re: linux-omap-psp-2.6.32 breaks iscsi-target

[Raffaele Recalcati]

> There is no such thing as a stable kernel anymore, all 2.6.XX releases
> are classed as unstable, it is upto vendors to stabalise and select API/ABI.

I hope there can be a good teamwork on this difficult integration.
I'm not informed about

>> http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=blob;f=include/net/inet_sock.h;hb=c720c7e8383aff1cb219bddf474ed89d850336e3
>> with
>> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=blob;f=include/net/inet_sock.h;h=47004f35cc7eaf6f2b3cac2779ea7b7ccd5d9c1f;hb=HEAD

comparison.

But, similarly, with DaVinci kernel we have the Kevin Hilman tree
(really close to mainline)
[1] http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-davinci.git
and the Arago one (compatible with DVDSK)
[2] http://arago-project.org/git/projects/linux-davinci.git

Ti accepts patches for Kevin Hilman tree,
instead Ti guarantuees for Arago tree.
So I'm also interested in this topic.
By now [2] is good enough for my needs.

Raffaele