* [xen-4.0-testing test] 2061: regressions - FAIL
@ 2010-09-03 4:05 xen.org
2010-09-03 17:13 ` Ian Jackson
0 siblings, 1 reply; 12+ messages in thread
From: xen.org @ 2010-09-03 4:05 UTC (permalink / raw)
To: xen-devel; +Cc: ian.jackson
flight 2061 xen-4.0-testing real
http://www.chiark.greenend.org.uk/~xensrcts/logs/2061/
Regressions :-(
tests which did not succeed:
build-i386-oldkern 1 xen-build fail REGR. vs. 2055
test-amd64-amd64-pair 12 guest-migrate/src_host/dst_host fail never pass
test-amd64-amd64-pv 7 guest-start fail like 2057
test-amd64-amd64-xl 10 guest-stop fail never pass
test-amd64-i386-pair 11 guest-start fail like 2057
test-amd64-i386-pv 7 guest-start fail like 2057
test-amd64-i386-xl 10 guest-stop fail never pass
test-amd64-xcpkern-i386-xl 10 guest-stop fail never pass
test-i386-i386-pair 12 guest-migrate/src_host/dst_host fail never pass
test-i386-i386-xl 10 guest-stop fail never pass
test-i386-xcpkern-i386-pair 12 guest-migrate/src_host/dst_host fail blocked in 2057
test-i386-xcpkern-i386-xl 10 guest-stop fail never pass
version targeted for testing:
xen 16867267ac12
baseline version:
xen 993458f6c5a0
jobs:
build-amd64 pass
build-amd64-oldkern pass
build-i386 pass
build-i386-oldkern fail
build-i386-xcpkern pass
test-amd64-amd64-pair fail
test-amd64-amd64-pv fail
test-amd64-amd64-win pass
test-amd64-amd64-xl fail
test-amd64-i386-pair fail
test-amd64-i386-pv fail
test-amd64-i386-win pass
test-amd64-i386-xl fail
test-amd64-xcpkern-i386-pair pass
test-amd64-xcpkern-i386-pv pass
test-amd64-xcpkern-i386-win pass
test-amd64-xcpkern-i386-xl fail
test-i386-i386-pair fail
test-i386-i386-pv pass
test-i386-i386-win pass
test-i386-i386-xl fail
test-i386-xcpkern-i386-pair fail
test-i386-xcpkern-i386-pv pass
test-i386-xcpkern-i386-win pass
test-i386-xcpkern-i386-xl fail
-------------------------------------------------------------------------------
build-amd64:
1 host-install(1) pass
2 host-build-prep pass
3 xen-build pass
linux 2968b258b1ca6bd16d75
qemu 0a940d892e90c820567c
xen 21336:16867267ac12
-------------------------------------------------------------------------------
build-amd64-oldkern:
1 xen-build pass
linux 1029:9b1adfb8b0b3
qemu 0a940d892e90c820567c
xen 21336:16867267ac12
-------------------------------------------------------------------------------
build-i386:
1 host-install(1) pass
2 host-build-prep pass
3 xen-build pass
linux 2968b258b1ca6bd16d75
qemu 0a940d892e90c820567c
xen 21336:16867267ac12
-------------------------------------------------------------------------------
build-i386-oldkern:
1 xen-build fail
linux 1029:9b1adfb8b0b3
qemu 0a940d892e90c820567c
xen 21336:16867267ac12
-------------------------------------------------------------------------------
build-i386-xcpkern:
1 kernel-build pass
linux 110879:32fc6955a6a5
pq_linux 154:61499f9e9a87
-------------------------------------------------------------------------------
test-amd64-amd64-pair:
1 xen-build-check(1) pass
2 host-install/src_host(2) pass
3 host-install/dst_host(3) pass
4 xen-install/src_host pass
5 xen-install/dst_host pass
6 xen-boot/src_host pass
7 xen-boot/dst_host pass
8 debian-install/dst_host pass
9 debian-fixup/dst_host pass
10 guests-nbd-mirror pass
11 guest-start pass
12 guest-migrate/src_host/dst_host fail
13 capture-logs/src_host(13) pass
14 capture-logs/dst_host(14) pass
-------------------------------------------------------------------------------
test-amd64-amd64-pv:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 debian-install pass
6 debian-fixup pass
7 guest-start fail
8 capture-logs(8) pass
-------------------------------------------------------------------------------
test-amd64-amd64-win:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 windows-install pass
6 guest-saverestore pass
7 guest-localmigrate pass
8 guest-stop pass
9 capture-logs(9) pass
-------------------------------------------------------------------------------
test-amd64-amd64-xl:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 debian-install pass
6 debian-fixup pass
7 guest-start pass
8 guest-saverestore pass
9 guest-localmigrate pass
10 guest-stop fail
11 capture-logs(11) pass
-------------------------------------------------------------------------------
test-amd64-i386-pair:
1 xen-build-check(1) pass
2 host-install/src_host(2) pass
3 host-install/dst_host(3) pass
4 xen-install/src_host pass
5 xen-install/dst_host pass
6 xen-boot/src_host pass
7 xen-boot/dst_host pass
8 debian-install/dst_host pass
9 debian-fixup/dst_host pass
10 guests-nbd-mirror pass
11 guest-start fail
12 capture-logs/src_host(12) pass
13 capture-logs/dst_host(13) pass
-------------------------------------------------------------------------------
test-amd64-i386-pv:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 debian-install pass
6 debian-fixup pass
7 guest-start fail
8 capture-logs(8) pass
-------------------------------------------------------------------------------
test-amd64-i386-win:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 windows-install pass
6 guest-saverestore pass
7 guest-localmigrate pass
8 guest-stop pass
9 capture-logs(9) pass
-------------------------------------------------------------------------------
test-amd64-i386-xl:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 debian-install pass
6 debian-fixup pass
7 guest-start pass
8 guest-saverestore pass
9 guest-localmigrate pass
10 guest-stop fail
11 capture-logs(11) pass
-------------------------------------------------------------------------------
test-amd64-xcpkern-i386-pair:
1 xen-build-check(1) pass
2 host-install/src_host(2) pass
3 host-install/dst_host(3) pass
4 xen-install/src_host pass
5 xen-install/dst_host pass
6 xen-boot/src_host pass
7 xen-boot/dst_host pass
8 debian-install/dst_host pass
9 debian-fixup/dst_host pass
10 guests-nbd-mirror pass
11 guest-start pass
12 guest-migrate/src_host/dst_host pass
13 guest-migrate/dst_host/src_host pass
14 capture-logs/src_host(14) pass
15 capture-logs/dst_host(15) pass
-------------------------------------------------------------------------------
test-amd64-xcpkern-i386-pv:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 debian-install pass
6 debian-fixup pass
7 guest-start pass
8 guest-saverestore pass
9 guest-localmigrate pass
10 guest-stop pass
11 capture-logs(11) pass
-------------------------------------------------------------------------------
test-amd64-xcpkern-i386-win:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 windows-install pass
6 guest-saverestore pass
7 guest-localmigrate pass
8 guest-stop pass
9 capture-logs(9) pass
-------------------------------------------------------------------------------
test-amd64-xcpkern-i386-xl:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 debian-install pass
6 debian-fixup pass
7 guest-start pass
8 guest-saverestore pass
9 guest-localmigrate pass
10 guest-stop fail
11 capture-logs(11) pass
-------------------------------------------------------------------------------
test-i386-i386-pair:
1 xen-build-check(1) pass
2 host-install/src_host(2) pass
3 host-install/dst_host(3) pass
4 xen-install/src_host pass
5 xen-install/dst_host pass
6 xen-boot/src_host pass
7 xen-boot/dst_host pass
8 debian-install/dst_host pass
9 debian-fixup/dst_host pass
10 guests-nbd-mirror pass
11 guest-start pass
12 guest-migrate/src_host/dst_host fail
13 capture-logs/src_host(13) pass
14 capture-logs/dst_host(14) pass
-------------------------------------------------------------------------------
test-i386-i386-pv:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 debian-install pass
6 debian-fixup pass
7 guest-start pass
8 guest-saverestore pass
9 guest-localmigrate pass
10 guest-stop pass
11 capture-logs(11) pass
-------------------------------------------------------------------------------
test-i386-i386-win:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 windows-install pass
6 guest-saverestore pass
7 guest-localmigrate pass
8 guest-stop pass
9 capture-logs(9) pass
-------------------------------------------------------------------------------
test-i386-i386-xl:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 debian-install pass
6 debian-fixup pass
7 guest-start pass
8 guest-saverestore pass
9 guest-localmigrate pass
10 guest-stop fail
11 capture-logs(11) pass
-------------------------------------------------------------------------------
test-i386-xcpkern-i386-pair:
1 xen-build-check(1) pass
2 host-install/src_host(2) pass
3 host-install/dst_host(3) pass
4 xen-install/src_host pass
5 xen-install/dst_host pass
6 xen-boot/src_host pass
7 xen-boot/dst_host pass
8 debian-install/dst_host pass
9 debian-fixup/dst_host pass
10 guests-nbd-mirror pass
11 guest-start pass
12 guest-migrate/src_host/dst_host fail
13 capture-logs/src_host(13) pass
14 capture-logs/dst_host(14) pass
-------------------------------------------------------------------------------
test-i386-xcpkern-i386-pv:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 debian-install pass
6 debian-fixup pass
7 guest-start pass
8 guest-saverestore pass
9 guest-localmigrate pass
10 guest-stop pass
11 capture-logs(11) pass
-------------------------------------------------------------------------------
test-i386-xcpkern-i386-win:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 windows-install pass
6 guest-saverestore pass
7 guest-localmigrate pass
8 guest-stop pass
9 capture-logs(9) pass
-------------------------------------------------------------------------------
test-i386-xcpkern-i386-xl:
1 xen-build-check(1) pass
2 host-install(2) pass
3 xen-install pass
4 xen-boot pass
5 debian-install pass
6 debian-fixup pass
7 guest-start pass
8 guest-saverestore pass
9 guest-localmigrate pass
10 guest-stop fail
11 capture-logs(11) pass
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
Not pushing.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [xen-4.0-testing test] 2061: regressions - FAIL
2010-09-03 4:05 [xen-4.0-testing test] 2061: regressions - FAIL xen.org
@ 2010-09-03 17:13 ` Ian Jackson
2010-09-03 17:17 ` Brendan Cully
0 siblings, 1 reply; 12+ messages in thread
From: Ian Jackson @ 2010-09-03 17:13 UTC (permalink / raw)
To: xen-devel; +Cc: Brendan Cully
xen.org writes ("[Xen-devel] [xen-4.0-testing test] 2061: regressions - FAIL"):
> flight 2061 xen-4.0-testing real
> http://www.chiark.greenend.org.uk/~xensrcts/logs/2061/
>
> Regressions :-(
>
> tests which did not succeed:
> build-i386-oldkern 1 xen-build fail REGR. vs. 2055
This "regression" is in fact a lost race, due to the bizarre reentry
into the kernel build system, while attempt to build the remus kernel
modules.
I seem to remember a previous discussion of this, with a suggestion
that this part of the build should be disabled in xen-unstable pending
a more sane arrangement. But I couldn't find the patch in
xen-unstable.
It seems to me that the patch below is probably about right. Any
contrary opinions ?
Ian.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff -r 1831912d4109 tools/remus/Makefile
--- a/tools/remus/Makefile Thu Sep 02 19:12:42 2010 +0100
+++ b/tools/remus/Makefile Fri Sep 03 18:12:28 2010 +0100
@@ -1,7 +1,8 @@ XEN_ROOT=../..
XEN_ROOT=../..
include $(XEN_ROOT)/tools/Rules.mk
-SUBDIRS-$(CONFIG_Linux) := imqebt kmod
+# Reentering the kernel build system is buggy and racy.
+# SUBDIRS-$(CONFIG_Linux) := imqebt kmod
SCRIPTS = remus
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [xen-4.0-testing test] 2061: regressions - FAIL
2010-09-03 17:13 ` Ian Jackson
@ 2010-09-03 17:17 ` Brendan Cully
2010-09-03 17:20 ` Ian Jackson
2010-09-03 18:30 ` Jeremy Fitzhardinge
0 siblings, 2 replies; 12+ messages in thread
From: Brendan Cully @ 2010-09-03 17:17 UTC (permalink / raw)
To: Ian Jackson; +Cc: Jeremy Fitzhardinge, xen-devel
On Friday, 03 September 2010 at 18:13, Ian Jackson wrote:
> xen.org writes ("[Xen-devel] [xen-4.0-testing test] 2061: regressions - FAIL"):
> > flight 2061 xen-4.0-testing real
> > http://www.chiark.greenend.org.uk/~xensrcts/logs/2061/
> >
> > Regressions :-(
> >
> > tests which did not succeed:
> > build-i386-oldkern 1 xen-build fail REGR. vs. 2055
>
> This "regression" is in fact a lost race, due to the bizarre reentry
> into the kernel build system, while attempt to build the remus kernel
> modules.
>
> I seem to remember a previous discussion of this, with a suggestion
> that this part of the build should be disabled in xen-unstable pending
> a more sane arrangement. But I couldn't find the patch in
> xen-unstable.
>
> It seems to me that the patch below is probably about right. Any
> contrary opinions ?
>
> Ian.
>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
I have a patch for this, but it's waiting for Jeremy to merge sch_plug
into the pvops git branch that gets pulled by default from
xen-unstable.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [xen-4.0-testing test] 2061: regressions - FAIL
2010-09-03 17:17 ` Brendan Cully
@ 2010-09-03 17:20 ` Ian Jackson
2010-09-03 17:38 ` Brendan Cully
2010-09-03 18:30 ` Jeremy Fitzhardinge
1 sibling, 1 reply; 12+ messages in thread
From: Ian Jackson @ 2010-09-03 17:20 UTC (permalink / raw)
To: Brendan Cully; +Cc: Jeremy Fitzhardinge, xen-devel@lists.xensource.com
Brendan Cully writes ("Re: [Xen-devel] [xen-4.0-testing test] 2061: regressions - FAIL"):
> I have a patch for this, but it's waiting for Jeremy to merge sch_plug
> into the pvops git branch that gets pulled by default from
> xen-unstable.
Can we disable the build in xen-unstable (and xen-4.0-testing) in the
meantime, as it makes the builds fail randomly (although with a low
probability) ?
Ian.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [xen-4.0-testing test] 2061: regressions - FAIL
2010-09-03 17:20 ` Ian Jackson
@ 2010-09-03 17:38 ` Brendan Cully
2010-09-03 17:41 ` Ian Jackson
0 siblings, 1 reply; 12+ messages in thread
From: Brendan Cully @ 2010-09-03 17:38 UTC (permalink / raw)
To: Ian Jackson; +Cc: Jeremy Fitzhardinge, xen-devel@lists.xensource.com
On Friday, 03 September 2010 at 18:20, Ian Jackson wrote:
> Brendan Cully writes ("Re: [Xen-devel] [xen-4.0-testing test] 2061: regressions - FAIL"):
> > I have a patch for this, but it's waiting for Jeremy to merge sch_plug
> > into the pvops git branch that gets pulled by default from
> > xen-unstable.
>
> Can we disable the build in xen-unstable (and xen-4.0-testing) in the
> meantime, as it makes the builds fail randomly (although with a low
> probability) ?
Or, instead of removing features, maybe your test scripts could just
not use -j4, or explicitly build the kernel first, until Jeremy gets
around to doing the merge?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [xen-4.0-testing test] 2061: regressions - FAIL
2010-09-03 17:38 ` Brendan Cully
@ 2010-09-03 17:41 ` Ian Jackson
2010-09-03 17:54 ` Brendan Cully
0 siblings, 1 reply; 12+ messages in thread
From: Ian Jackson @ 2010-09-03 17:41 UTC (permalink / raw)
To: Brendan Cully; +Cc: Jeremy Fitzhardinge, xen-devel@lists.xensource.com
Brendan Cully writes ("Re: [Xen-devel] [xen-4.0-testing test] 2061: regressions - FAIL"):
> Or, instead of removing features, maybe your test scripts could just
> not use -j4, or explicitly build the kernel first, until Jeremy gets
> around to doing the merge?
Not using -j4 is out of the question. And I don't want to make the
situation with building kernels out of the xen tree in my test system
any worse than it is already. I'm intending to get rid of that
entirely. Hopefully we can get rid of it in xen-unstable at some
point too.
Ian.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [xen-4.0-testing test] 2061: regressions - FAIL
2010-09-03 17:41 ` Ian Jackson
@ 2010-09-03 17:54 ` Brendan Cully
2010-09-03 17:55 ` Ian Jackson
0 siblings, 1 reply; 12+ messages in thread
From: Brendan Cully @ 2010-09-03 17:54 UTC (permalink / raw)
To: Ian Jackson; +Cc: Jeremy Fitzhardinge, xen-devel@lists.xensource.com
On Friday, 03 September 2010 at 18:41, Ian Jackson wrote:
> Brendan Cully writes ("Re: [Xen-devel] [xen-4.0-testing test] 2061: regressions - FAIL"):
> > Or, instead of removing features, maybe your test scripts could just
> > not use -j4, or explicitly build the kernel first, until Jeremy gets
> > around to doing the merge?
>
> Not using -j4 is out of the question. And I don't want to make the
> situation with building kernels out of the xen tree in my test system
> any worse than it is already. I'm intending to get rid of that
> entirely. Hopefully we can get rid of it in xen-unstable at some
> point too.
Until the kernel modules are in their proper place, I think a less
drastic fix for your test suites would be to edit
tools/remus/kmod/Makefile and change
test -d $(KERNELDIR)
to
test -f $(KERNELDIR)/Module.symvers
which will still silently fail to build the modules if tools/remus
builds too early, but should suppress failure warnings. Completely
untested.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [xen-4.0-testing test] 2061: regressions - FAIL
2010-09-03 17:54 ` Brendan Cully
@ 2010-09-03 17:55 ` Ian Jackson
2010-09-03 18:04 ` Brendan Cully
0 siblings, 1 reply; 12+ messages in thread
From: Ian Jackson @ 2010-09-03 17:55 UTC (permalink / raw)
To: Brendan Cully; +Cc: Jeremy Fitzhardinge, xen-devel@lists.xensource.com
Brendan Cully writes ("Re: [Xen-devel] [xen-4.0-testing test] 2061: regressions - FAIL"):
> Until the kernel modules are in their proper place, I think a less
> drastic fix for your test suites would be to edit
> tools/remus/kmod/Makefile and change
>
> test -d $(KERNELDIR)
>
> to
>
> test -f $(KERNELDIR)/Module.symvers
>
> which will still silently fail to build the modules if tools/remus
> builds too early, but should suppress failure warnings. Completely
> untested.
I don't think this is reliable, is it ? As that .symvers file can be
created before the kernel build is complete. So we can still reenter
the whole kernel build.
Ian.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [xen-4.0-testing test] 2061: regressions - FAIL
2010-09-03 17:55 ` Ian Jackson
@ 2010-09-03 18:04 ` Brendan Cully
2010-09-03 18:11 ` Ian Campbell
0 siblings, 1 reply; 12+ messages in thread
From: Brendan Cully @ 2010-09-03 18:04 UTC (permalink / raw)
To: Ian Jackson; +Cc: Jeremy Fitzhardinge, xen-devel@lists.xensource.com
On Friday, 03 September 2010 at 18:55, Ian Jackson wrote:
> Brendan Cully writes ("Re: [Xen-devel] [xen-4.0-testing test] 2061: regressions - FAIL"):
> > Until the kernel modules are in their proper place, I think a less
> > drastic fix for your test suites would be to edit
> > tools/remus/kmod/Makefile and change
> >
> > test -d $(KERNELDIR)
> >
> > to
> >
> > test -f $(KERNELDIR)/Module.symvers
> >
> > which will still silently fail to build the modules if tools/remus
> > builds too early, but should suppress failure warnings. Completely
> > untested.
>
> I don't think this is reliable, is it ? As that .symvers file can be
> created before the kernel build is complete. So we can still reenter
> the whole kernel build.
What do you mean 'reenter the whole kernel build'? Are you under the
impression that the kmod tree is somehow actually building in the
kernel build directory?
As I said in an earlier email, it doesn't do that. It is just using
the kernel header files, like any other third party module. Normally
you could find them under /lib/modules/foo/build, but obviously that
doesn't apply here.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [xen-4.0-testing test] 2061: regressions - FAIL
2010-09-03 18:04 ` Brendan Cully
@ 2010-09-03 18:11 ` Ian Campbell
2010-09-03 18:16 ` Brendan Cully
0 siblings, 1 reply; 12+ messages in thread
From: Ian Campbell @ 2010-09-03 18:11 UTC (permalink / raw)
To: Brendan Cully
Cc: Jeremy Fitzhardinge, xen-devel@lists.xensource.com, Ian Jackson
On Fri, 2010-09-03 at 19:04 +0100, Brendan Cully wrote:
> On Friday, 03 September 2010 at 18:55, Ian Jackson wrote:
> > Brendan Cully writes ("Re: [Xen-devel] [xen-4.0-testing test] 2061: regressions - FAIL"):
> > > Until the kernel modules are in their proper place, I think a less
> > > drastic fix for your test suites would be to edit
> > > tools/remus/kmod/Makefile and change
> > >
> > > test -d $(KERNELDIR)
> > >
> > > to
> > >
> > > test -f $(KERNELDIR)/Module.symvers
> > >
> > > which will still silently fail to build the modules if tools/remus
> > > builds too early, but should suppress failure warnings. Completely
> > > untested.
> >
> > I don't think this is reliable, is it ? As that .symvers file can be
> > created before the kernel build is complete. So we can still reenter
> > the whole kernel build.
>
> What do you mean 'reenter the whole kernel build'? Are you under the
> impression that the kmod tree is somehow actually building in the
> kernel build directory?
>
> As I said in an earlier email, it doesn't do that. It is just using
> the kernel header files, like any other third party module. Normally
> you could find them under /lib/modules/foo/build, but obviously that
> doesn't apply here.
Out of tree module builds require a configured kernel tree, which it is
not when the race is lost. You can't use the kernel headers to build
modules without a .config for example since they contain various #ifdef
CONFIG_FOO stuff which affects the kernel ABI.
Maybe we should drop the remus stuff from tools/Makefile and add an
explicit call to "make -C tools/remus" (or whatever the path is) at the
appropriate place at the end of the rule which builds the kernel?
Ian.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [xen-4.0-testing test] 2061: regressions - FAIL
2010-09-03 18:11 ` Ian Campbell
@ 2010-09-03 18:16 ` Brendan Cully
0 siblings, 0 replies; 12+ messages in thread
From: Brendan Cully @ 2010-09-03 18:16 UTC (permalink / raw)
To: Ian Campbell
Cc: Jeremy Fitzhardinge, xen-devel@lists.xensource.com, Ian Jackson
On Friday, 03 September 2010 at 19:11, Ian Campbell wrote:
> On Fri, 2010-09-03 at 19:04 +0100, Brendan Cully wrote:
> > On Friday, 03 September 2010 at 18:55, Ian Jackson wrote:
> > > Brendan Cully writes ("Re: [Xen-devel] [xen-4.0-testing test] 2061: regressions - FAIL"):
> > > > Until the kernel modules are in their proper place, I think a less
> > > > drastic fix for your test suites would be to edit
> > > > tools/remus/kmod/Makefile and change
> > > >
> > > > test -d $(KERNELDIR)
> > > >
> > > > to
> > > >
> > > > test -f $(KERNELDIR)/Module.symvers
> > > >
> > > > which will still silently fail to build the modules if tools/remus
> > > > builds too early, but should suppress failure warnings. Completely
> > > > untested.
> > >
> > > I don't think this is reliable, is it ? As that .symvers file can be
> > > created before the kernel build is complete. So we can still reenter
> > > the whole kernel build.
> >
> > What do you mean 'reenter the whole kernel build'? Are you under the
> > impression that the kmod tree is somehow actually building in the
> > kernel build directory?
> >
> > As I said in an earlier email, it doesn't do that. It is just using
> > the kernel header files, like any other third party module. Normally
> > you could find them under /lib/modules/foo/build, but obviously that
> > doesn't apply here.
>
> Out of tree module builds require a configured kernel tree, which it is
> not when the race is lost. You can't use the kernel headers to build
> modules without a .config for example since they contain various #ifdef
> CONFIG_FOO stuff which affects the kernel ABI.
Yes. The current kmod Makefile already silently exits if
$(KERNELDIR)/.config isn't there, but .config turns out not to be good
enough. Looking for Module.symvers ought to be sufficient for kmod to
either succeed or silently exit when it loses the race, I
think. $(KERNELDIR)/include/linux/autoconf.h might also do the
trick. But it is obviously much better to have a proper Makefile
dependency.
> Maybe we should drop the remus stuff from tools/Makefile and add an
> explicit call to "make -C tools/remus" (or whatever the path is) at the
> appropriate place at the end of the rule which builds the kernel?
The problematic directory is tools/remus/kmod, but otherwise this
sounds fine to me.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [xen-4.0-testing test] 2061: regressions - FAIL
2010-09-03 17:17 ` Brendan Cully
2010-09-03 17:20 ` Ian Jackson
@ 2010-09-03 18:30 ` Jeremy Fitzhardinge
1 sibling, 0 replies; 12+ messages in thread
From: Jeremy Fitzhardinge @ 2010-09-03 18:30 UTC (permalink / raw)
To: Ian Jackson, xen-devel
On 09/03/2010 10:17 AM, Brendan Cully wrote:
> I have a patch for this, but it's waiting for Jeremy to merge sch_plug
> into the pvops git branch that gets pulled by default from
> xen-unstable.
sch_plug is merged into xen/next-2.6.32 which is what Ian's test rig
should be testing with. I've just updated stable-2.6.32.x to the change
where I merged it in.
J
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2010-09-03 18:30 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-03 4:05 [xen-4.0-testing test] 2061: regressions - FAIL xen.org
2010-09-03 17:13 ` Ian Jackson
2010-09-03 17:17 ` Brendan Cully
2010-09-03 17:20 ` Ian Jackson
2010-09-03 17:38 ` Brendan Cully
2010-09-03 17:41 ` Ian Jackson
2010-09-03 17:54 ` Brendan Cully
2010-09-03 17:55 ` Ian Jackson
2010-09-03 18:04 ` Brendan Cully
2010-09-03 18:11 ` Ian Campbell
2010-09-03 18:16 ` Brendan Cully
2010-09-03 18:30 ` Jeremy Fitzhardinge
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.