[PATCH] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.

[PATCH] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.

[Graham Gower]

From b90a9fef712cc934863ee786b2d2dedc37d6902d Mon Sep 17 00:00:00 2001
From: Graham Gower <graham.gower@gmail.com>
Date: Wed, 22 Sep 2010 09:39:00 +0930
Subject: [PATCH 1/5] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.


Signed-off-by: Graham Gower <graham.gower@gmail.com>
---
 recipes/at91bootstrap/at91bootstrap.inc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/recipes/at91bootstrap/at91bootstrap.inc b/recipes/at91bootstrap/at91bootstrap.inc
index 2160f64..dfe143a 100644
--- a/recipes/at91bootstrap/at91bootstrap.inc
+++ b/recipes/at91bootstrap/at91bootstrap.inc
@@ -1,6 +1,7 @@
 DESCRIPTION = "at91bootstrap: loaded into internal SRAM by AT91 BootROM"
 SECTION = "bootloaders"
 
+COMPATIBLE_MACHINE = "(afeb9260|at91cap9adk|at91sam9g20ek|at91sam9rlek|at91sam9263ek|at91sam9260ek|at91sam9xeek|at91sam9261ek)"
 SRC_URI = "ftp://www.at91.com/pub/buildroot/${PN}-${PV}.tar.bz2 \
 	   file://defconfig \
            "
-- 
1.7.1

Re: [PATCH] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.

[Marcin Juszkiewicz]

Dnia środa, 22 września 2010 o 02:41:52 Graham Gower napisał(a):

> --- a/recipes/at91bootstrap/at91bootstrap.inc
> +++ b/recipes/at91bootstrap/at91bootstrap.inc
 
> +COMPATIBLE_MACHINE =
> "(afeb9260|at91cap9adk|at91sam9g20ek|at91sam9rlek|at91sam9263ek|at91sam926
> 0ek|at91sam9xeek|at91sam9261ek)"

mk355 is also atmel at91sam9263 so at91bootstrap is used on it probably.

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz

Re: [PATCH] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.

[Graham Gower]

On 22 September 2010 16:43, Marcin Juszkiewicz
<marcin@juszkiewicz.com.pl> wrote:
> Dnia środa, 22 września 2010 o 02:41:52 Graham Gower napisał(a):
>
>> --- a/recipes/at91bootstrap/at91bootstrap.inc
>> +++ b/recipes/at91bootstrap/at91bootstrap.inc
>
>> +COMPATIBLE_MACHINE =
>> "(afeb9260|at91cap9adk|at91sam9g20ek|at91sam9rlek|at91sam9263ek|at91sam926
>> 0ek|at91sam9xeek|at91sam9261ek)"
>
> mk355 is also atmel at91sam9263 so at91bootstrap is used on it probably.
>

The compatible machines here are those that have a defconfig in the
the files/ directory.

-Graham

Re: [PATCH] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.

[Marco Cavallini]

Graham Gower ha scritto, Il 22/09/2010 09:36:
> On 22 September 2010 16:43, Marcin Juszkiewicz
> <marcin@juszkiewicz.com.pl> wrote:
>> Dnia środa, 22 września 2010 o 02:41:52 Graham Gower napisał(a):
>>
>>> --- a/recipes/at91bootstrap/at91bootstrap.inc
>>> +++ b/recipes/at91bootstrap/at91bootstrap.inc
>>> +COMPATIBLE_MACHINE =
>>> "(afeb9260|at91cap9adk|at91sam9g20ek|at91sam9rlek|at91sam9263ek|at91sam926
>>> 0ek|at91sam9xeek|at91sam9261ek)"
>> mk355 is also atmel at91sam9263 so at91bootstrap is used on it probably.
>>
> 
> The compatible machines here are those that have a defconfig in the
> the files/ directory.
> 

Yes please
mh55 is also atmel at91sam9263 so at91bootstrap is used on it too.
It also have its defconfig in the recipes/linux/linux-2.6.28/mh355/
directory.


Cordiali Saluti / Kindest Regards / mit freundlichen Grüssen
--
Marco Cavallini | KOAN sas | Bergamo - Italia
 embedded and real-time software engineering
   Atmel third party certified consultant
Phone:+39-035-255.235 - Fax:+39-178-22.39.748
      http://www.KoanSoftware.com
        http://www.KaeilOS.com

Re: [PATCH] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.

[Graham Gower]

On 22 September 2010 17:31, Marco Cavallini <koansoftware@gmail.com> wrote:
> Graham Gower ha scritto, Il 22/09/2010 09:36:
>> On 22 September 2010 16:43, Marcin Juszkiewicz
>> <marcin@juszkiewicz.com.pl> wrote:
>>> Dnia środa, 22 września 2010 o 02:41:52 Graham Gower napisał(a):
>>>
>>>> --- a/recipes/at91bootstrap/at91bootstrap.inc
>>>> +++ b/recipes/at91bootstrap/at91bootstrap.inc
>>>> +COMPATIBLE_MACHINE =
>>>> "(afeb9260|at91cap9adk|at91sam9g20ek|at91sam9rlek|at91sam9263ek|at91sam926
>>>> 0ek|at91sam9xeek|at91sam9261ek)"
>>> mk355 is also atmel at91sam9263 so at91bootstrap is used on it probably.
>>>
>>
>> The compatible machines here are those that have a defconfig in the
>> the files/ directory.
>>
>
> Yes please
> mh55 is also atmel at91sam9263 so at91bootstrap is used on it too.
> It also have its defconfig in the recipes/linux/linux-2.6.28/mh355/
> directory.
>
>

Ok, well the defconfigs are duplicated into this recipe dir (probably
a bad thing). To support mh55, you would have to copy the defconfig in
and add it to COMPATIBLE_MACHINE.

Re: [PATCH] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.

[Tom Rini]

Graham Gower wrote:
> On 22 September 2010 17:31, Marco Cavallini <koansoftware@gmail.com> wrote:
>> Graham Gower ha scritto, Il 22/09/2010 09:36:
>>> On 22 September 2010 16:43, Marcin Juszkiewicz
>>> <marcin@juszkiewicz.com.pl> wrote:
>>>> Dnia środa, 22 września 2010 o 02:41:52 Graham Gower napisał(a):
>>>>
>>>>> --- a/recipes/at91bootstrap/at91bootstrap.inc
>>>>> +++ b/recipes/at91bootstrap/at91bootstrap.inc
>>>>> +COMPATIBLE_MACHINE =
>>>>> "(afeb9260|at91cap9adk|at91sam9g20ek|at91sam9rlek|at91sam9263ek|at91sam926
>>>>> 0ek|at91sam9xeek|at91sam9261ek)"
>>>> mk355 is also atmel at91sam9263 so at91bootstrap is used on it probably.
>>>>
>>> The compatible machines here are those that have a defconfig in the
>>> the files/ directory.
>>>
>> Yes please
>> mh55 is also atmel at91sam9263 so at91bootstrap is used on it too.
>> It also have its defconfig in the recipes/linux/linux-2.6.28/mh355/
>> directory.
>>
>>
> 
> Ok, well the defconfigs are duplicated into this recipe dir (probably
> a bad thing). To support mh55, you would have to copy the defconfig in
> and add it to COMPATIBLE_MACHINE.

It sounds like, and trying not to open a different can of worms, but the 
at91 stuff should perhaps be using one of those hooks for grouping a set 
of machines together?

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 22-09-10 20:26, Tom Rini wrote:
> Graham Gower wrote:
>> On 22 September 2010 17:31, Marco Cavallini <koansoftware@gmail.com>
>> wrote:
>>> Graham Gower ha scritto, Il 22/09/2010 09:36:
>>>> On 22 September 2010 16:43, Marcin Juszkiewicz
>>>> <marcin@juszkiewicz.com.pl> wrote:
>>>>> Dnia środa, 22 września 2010 o 02:41:52 Graham Gower napisał(a):
>>>>>
>>>>>> --- a/recipes/at91bootstrap/at91bootstrap.inc
>>>>>> +++ b/recipes/at91bootstrap/at91bootstrap.inc
>>>>>> +COMPATIBLE_MACHINE =
>>>>>> "(afeb9260|at91cap9adk|at91sam9g20ek|at91sam9rlek|at91sam9263ek|at91sam926
>>>>>>
>>>>>> 0ek|at91sam9xeek|at91sam9261ek)"
>>>>> mk355 is also atmel at91sam9263 so at91bootstrap is used on it
>>>>> probably.
>>>>>
>>>> The compatible machines here are those that have a defconfig in the
>>>> the files/ directory.
>>>>
>>> Yes please
>>> mh55 is also atmel at91sam9263 so at91bootstrap is used on it too.
>>> It also have its defconfig in the recipes/linux/linux-2.6.28/mh355/
>>> directory.
>>>
>>>
>>
>> Ok, well the defconfigs are duplicated into this recipe dir (probably
>> a bad thing). To support mh55, you would have to copy the defconfig in
>> and add it to COMPATIBLE_MACHINE.
> 
> It sounds like, and trying not to open a different can of worms, but the
> at91 stuff should perhaps be using one of those hooks for grouping a set
> of machines together?

It is indeed what SOC_FAMILY was designed to do: group SOC related
features instead of formfactor features
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMmlIHMkyGM64RGpERAv2eAKCu02W7Pu7oDz+zZ/hWzyhOrNYPPACeOcvo
mT4UxCfGuVIKC8gIcDFGt8U=
=dV3k
-----END PGP SIGNATURE-----

Re: [PATCH] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

As a general remark to your current patch series, I think there is some
confusion what COMPATIBLE_MACHINE is for. To me it's signals "this
recipe is specific to a *machine*", not "this recipe is missing files to
make it work without other archs/machines".

The cases:

spidermonkey/firefox/numpy: needs jsautocfg.h for each arch, no need for
COMPATIBLE_MACHINE or COMPATIBLE_ARCH, people need to add support for
their archs

u-boot-env/pivotboot: needs a file for each machine to work properly,
but adding an (empty) fallback file is the way to go since it's only
used in deploy/.

Tacking on COMPATIBLE_{MACHINE,HOST} would just hide the problems and
make fixing it more more tedious than it needs to be. For kernel and
uboot C_M is used to make bitbake do the right thing since they all
share the same PN.

That's my take on the situation, dunno if it's the consensus or not.

regards,

Koen

On 22-09-10 02:41, Graham Gower wrote:
> From b90a9fef712cc934863ee786b2d2dedc37d6902d Mon Sep 17 00:00:00 2001
> From: Graham Gower <graham.gower@gmail.com>
> Date: Wed, 22 Sep 2010 09:39:00 +0930
> Subject: [PATCH 1/5] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.
> 
> 
> Signed-off-by: Graham Gower <graham.gower@gmail.com>
> ---
>  recipes/at91bootstrap/at91bootstrap.inc |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/recipes/at91bootstrap/at91bootstrap.inc b/recipes/at91bootstrap/at91bootstrap.inc
> index 2160f64..dfe143a 100644
> --- a/recipes/at91bootstrap/at91bootstrap.inc
> +++ b/recipes/at91bootstrap/at91bootstrap.inc
> @@ -1,6 +1,7 @@
>  DESCRIPTION = "at91bootstrap: loaded into internal SRAM by AT91 BootROM"
>  SECTION = "bootloaders"
>  
> +COMPATIBLE_MACHINE = "(afeb9260|at91cap9adk|at91sam9g20ek|at91sam9rlek|at91sam9263ek|at91sam9260ek|at91sam9xeek|at91sam9261ek)"
>  SRC_URI = "ftp://www.at91.com/pub/buildroot/${PN}-${PV}.tar.bz2 \
>  	   file://defconfig \
>             "

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMmlSbMkyGM64RGpERAtR1AKChk2g0bwBLsiyDaAsw94CZsWt9fwCfRw0L
bkqI5S6ortqh1+QHpHVQm1s=
=re7X
-----END PGP SIGNATURE-----

Re: [PATCH] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.

[Tom Rini]

Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> As a general remark to your current patch series, I think there is some
> confusion what COMPATIBLE_MACHINE is for. To me it's signals "this
> recipe is specific to a *machine*", not "this recipe is missing files to
> make it work without other archs/machines".

Let me just add that I agree, and talked with Graham on IRC a good bit 
after the patch series was posted (and before I noticed them on the ML).

I think what we need to do here is make a list of recipes that simply 
don't patch for all arches due to missing some usually easy "porting" 
work and putting that up on the janitors page as work that needs doing 
by someone.

> The cases:
> 
> spidermonkey/firefox/numpy: needs jsautocfg.h for each arch, no need for
> COMPATIBLE_MACHINE or COMPATIBLE_ARCH, people need to add support for
> their archs

And to further add, Debian has gone and made these files in some cases 
(mips/mipsel) and in others, it shouldn't be hard to craft it 
(translating autoconf variables into what mozilla wants) or if 
qemu-$arch works, dig out the program that generates the file and do so.

> u-boot-env/pivotboot: needs a file for each machine to work properly,
> but adding an (empty) fallback file is the way to go since it's only
> used in deploy/.

I gotta disagree here.  You're saying a valid and machine specific file 
needs adding for this to do something on a machine and a dummy fallback 
so it builds uselessly for all.  Isn't that a good reason to use the 
COMPATIBLE_MACHINE mask?

> Tacking on COMPATIBLE_{MACHINE,HOST} would just hide the problems and
> make fixing it more more tedious than it needs to be. For kernel and
> uboot C_M is used to make bitbake do the right thing since they all
> share the same PN.

Agreed.  These are heavy handed variables that need to be used with 
care.  This patchset does expose problems, which is good, it's just a 
matter of solving them well.

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.

[Ulf Samuelsson]

Graham Gower skrev:
> From b90a9fef712cc934863ee786b2d2dedc37d6902d Mon Sep 17 00:00:00 2001
> From: Graham Gower <graham.gower@gmail.com>
> Date: Wed, 22 Sep 2010 09:39:00 +0930
> Subject: [PATCH 1/5] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.
> 
> 
> Signed-off-by: Graham Gower <graham.gower@gmail.com>
> ---
>  recipes/at91bootstrap/at91bootstrap.inc |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/recipes/at91bootstrap/at91bootstrap.inc b/recipes/at91bootstrap/at91bootstrap.inc
> index 2160f64..dfe143a 100644
> --- a/recipes/at91bootstrap/at91bootstrap.inc
> +++ b/recipes/at91bootstrap/at91bootstrap.inc
> @@ -1,6 +1,7 @@
>  DESCRIPTION = "at91bootstrap: loaded into internal SRAM by AT91 BootROM"
>  SECTION = "bootloaders"
>  
> +COMPATIBLE_MACHINE = "(afeb9260|at91cap9adk|at91sam9g20ek|at91sam9rlek|at91sam9263ek|at91sam9260ek|at91sam9xeek|at91sam9261ek)"
>  SRC_URI = "ftp://www.at91.com/pub/buildroot/${PN}-${PV}.tar.bz2 \
>  	   file://defconfig \
>             "

Is it not better to move all machines to at91bootstrap-2.13 which does
not use this include file at all.


Best Regards
Ulf Samuelsson