From: Ben Greear <greearb@candelatech.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] ath9k, multiple stations, and AMPDUs
Date: Thu, 23 Sep 2010 06:56:19 -0700 [thread overview]
Message-ID: <4C9B5C83.4000407@candelatech.com> (raw)
In-Reply-To: <1285230831.3691.5.camel@jlt3.sipsolutions.net>
On 09/23/2010 01:33 AM, Johannes Berg wrote:
> On Wed, 2010-09-22 at 21:58 -0700, Ben Greear wrote:
>
>
>> + * @addr2: local address (vif->sdata->dev->dev_addr). Can be NULL for 'any'.
>> *
>> * This function must be called under RCU lock and the
>> * resulting pointer is only valid under RCU lock as well.
>> @@ -2434,7 +2435,8 @@ struct ieee80211_sta *ieee80211_find_sta(struct ieee80211_vif *vif,
>> * DO NOT USE THIS FUNCTION.
>> */
>> struct ieee80211_sta *ieee80211_find_sta_by_hw(struct ieee80211_hw *hw,
>> - const u8 *addr);
>> + const u8 *addr,
>> + const u8 *localaddr);
>
> That's not going to generate proper documentation. Also, it now probably
> shouldn't be called "by_hw" any more.
I can't think of a better name, and it still does take the hw struct,
but if you have a suggestion you like better, I will use it.
I re-posted with the rest of the changes you suggested. Seems to
be working fine.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Felix Fietkau <nbd@openwrt.org>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@venema.h4ckr.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [ath9k-devel] ath9k, multiple stations, and AMPDUs
Date: Thu, 23 Sep 2010 06:56:19 -0700 [thread overview]
Message-ID: <4C9B5C83.4000407@candelatech.com> (raw)
In-Reply-To: <1285230831.3691.5.camel@jlt3.sipsolutions.net>
On 09/23/2010 01:33 AM, Johannes Berg wrote:
> On Wed, 2010-09-22 at 21:58 -0700, Ben Greear wrote:
>
>
>> + * @addr2: local address (vif->sdata->dev->dev_addr). Can be NULL for 'any'.
>> *
>> * This function must be called under RCU lock and the
>> * resulting pointer is only valid under RCU lock as well.
>> @@ -2434,7 +2435,8 @@ struct ieee80211_sta *ieee80211_find_sta(struct ieee80211_vif *vif,
>> * DO NOT USE THIS FUNCTION.
>> */
>> struct ieee80211_sta *ieee80211_find_sta_by_hw(struct ieee80211_hw *hw,
>> - const u8 *addr);
>> + const u8 *addr,
>> + const u8 *localaddr);
>
> That's not going to generate proper documentation. Also, it now probably
> shouldn't be called "by_hw" any more.
I can't think of a better name, and it still does take the hw struct,
but if you have a suggestion you like better, I will use it.
I re-posted with the rest of the changes you suggested. Seems to
be working fine.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-09-23 13:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 5:25 [ath9k-devel] ath9k, multiple stations, and AMPDUs Ben Greear
2010-09-21 5:25 ` Ben Greear
2010-09-21 10:10 ` [ath9k-devel] " Felix Fietkau
2010-09-21 10:10 ` Felix Fietkau
2010-09-21 12:08 ` Ben Greear
2010-09-21 12:08 ` Ben Greear
2010-09-21 12:19 ` Felix Fietkau
2010-09-21 12:19 ` Felix Fietkau
2010-09-21 12:24 ` Johannes Berg
2010-09-21 12:24 ` Johannes Berg
2010-09-21 12:31 ` Johannes Berg
2010-09-21 12:31 ` Johannes Berg
2010-09-21 17:25 ` Ben Greear
2010-09-21 17:25 ` Ben Greear
2010-09-21 18:00 ` Felix Fietkau
2010-09-21 18:00 ` Felix Fietkau
2010-09-21 18:04 ` Ben Greear
2010-09-21 18:04 ` Ben Greear
2010-09-21 18:06 ` Felix Fietkau
2010-09-21 18:06 ` Felix Fietkau
2010-09-21 19:28 ` Johannes Berg
2010-09-21 19:28 ` Johannes Berg
2010-09-21 19:32 ` Felix Fietkau
2010-09-21 19:32 ` Felix Fietkau
2010-09-21 20:19 ` Ben Greear
2010-09-21 20:19 ` Ben Greear
2010-09-21 22:41 ` Felix Fietkau
2010-09-21 22:41 ` Felix Fietkau
2010-09-22 4:33 ` Ben Greear
2010-09-22 4:33 ` Ben Greear
2010-09-22 8:31 ` Felix Fietkau
2010-09-22 8:31 ` Felix Fietkau
2010-09-23 4:58 ` Ben Greear
2010-09-23 4:58 ` Ben Greear
2010-09-23 8:33 ` Johannes Berg
2010-09-23 8:33 ` Johannes Berg
2010-09-23 13:56 ` Ben Greear [this message]
2010-09-23 13:56 ` Ben Greear
2010-09-23 14:05 ` Johannes Berg
2010-09-23 14:05 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9B5C83.4000407@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.