From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, kexec <kexec@lists.infradead.org>,
caiqian@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: kexec load failure introduced by "x86, memblock: Replace e820_/_early string with memblock_"
Date: Mon, 27 Sep 2010 15:50:31 -0700 [thread overview]
Message-ID: <4CA11FB7.2080101@zytor.com> (raw)
In-Reply-To: <4CA11918.7050708@kernel.org>
+ crash_base = alignment;
+ while ((crash_base + crash_size) <= total_mem) {
+ start = memblock_find_in_range(crash_base,
+ crash_base + crash_size, crash_size, alignment);
+
+ if (start == crash_base)
+ break;
+
+ crash_base += alignment;
+ }
+ if (start != crash_base) {
Open-coded crap violation error!
Seriously, these kinds of open-coded loops are *never* acceptable, since
they are really "let's violate the interface by making it do something
it wasn't intended to do" -- it means we need a new interface.
Alternatively, if we really need the lowest possible address, why do we
need to search?
-hpa
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: caiqian@redhat.com, Ingo Molnar <mingo@elte.hu>,
kexec <kexec@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: kexec load failure introduced by "x86, memblock: Replace e820_/_early string with memblock_"
Date: Mon, 27 Sep 2010 15:50:31 -0700 [thread overview]
Message-ID: <4CA11FB7.2080101@zytor.com> (raw)
In-Reply-To: <4CA11918.7050708@kernel.org>
+ crash_base = alignment;
+ while ((crash_base + crash_size) <= total_mem) {
+ start = memblock_find_in_range(crash_base,
+ crash_base + crash_size, crash_size, alignment);
+
+ if (start == crash_base)
+ break;
+
+ crash_base += alignment;
+ }
+ if (start != crash_base) {
Open-coded crap violation error!
Seriously, these kinds of open-coded loops are *never* acceptable, since
they are really "let's violate the interface by making it do something
it wasn't intended to do" -- it means we need a new interface.
Alternatively, if we really need the lowest possible address, why do we
need to search?
-hpa
next prev parent reply other threads:[~2010-09-27 22:51 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1909915255.2046011285586388234.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-27 11:21 ` kexec load failure introduced by "x86, memblock: Replace e820_/_early string with memblock_" caiqian
2010-09-27 11:21 ` caiqian
2010-09-27 22:22 ` Yinghai Lu
2010-09-27 22:22 ` Yinghai Lu
2010-09-27 22:50 ` H. Peter Anvin [this message]
2010-09-27 22:50 ` H. Peter Anvin
2010-09-27 23:20 ` Yinghai Lu
2010-09-27 23:20 ` Yinghai Lu
2010-09-27 23:26 ` H. Peter Anvin
2010-09-27 23:26 ` H. Peter Anvin
2010-09-27 23:32 ` Yinghai Lu
2010-09-27 23:32 ` Yinghai Lu
2010-09-27 23:34 ` H. Peter Anvin
2010-09-27 23:34 ` H. Peter Anvin
2010-09-27 23:41 ` Yinghai Lu
2010-09-27 23:41 ` Yinghai Lu
2010-09-28 0:53 ` Vivek Goyal
2010-09-28 0:53 ` Vivek Goyal
2010-09-28 2:41 ` Yinghai Lu
2010-09-28 2:41 ` Yinghai Lu
2010-09-28 3:46 ` H. Peter Anvin
2010-09-28 3:46 ` H. Peter Anvin
2010-09-28 7:14 ` Yinghai Lu
2010-09-28 7:14 ` Yinghai Lu
2010-09-28 14:01 ` Vivek Goyal
2010-09-28 14:01 ` Vivek Goyal
2010-09-28 13:54 ` Vivek Goyal
2010-09-28 13:54 ` Vivek Goyal
[not found] <1346740216.2003261285553562018.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-27 2:42 ` caiqian
2010-09-27 2:42 ` caiqian
2010-09-27 5:58 ` Yinghai Lu
2010-09-27 5:58 ` Yinghai Lu
2010-09-27 6:31 ` Yinghai Lu
2010-09-27 6:31 ` Yinghai Lu
2010-09-27 9:16 ` CAI Qian
2010-09-27 9:16 ` CAI Qian
[not found] <1834151968.1996101285512089968.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-26 14:47 ` caiqian
2010-09-26 14:47 ` caiqian
2010-09-26 19:42 ` Yinghai Lu
2010-09-26 19:42 ` Yinghai Lu
[not found] <1614106428.1991831285470588200.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-26 3:11 ` caiqian
2010-09-26 3:11 ` caiqian
2010-09-26 6:44 ` Yinghai Lu
2010-09-26 6:44 ` Yinghai Lu
2010-09-26 6:55 ` CAI Qian
2010-09-26 6:55 ` CAI Qian
2010-09-26 6:56 ` Yinghai Lu
2010-09-26 6:56 ` Yinghai Lu
2010-09-26 10:37 ` CAI Qian
2010-09-26 10:37 ` CAI Qian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA11FB7.2080101@zytor.com \
--to=hpa@zytor.com \
--cc=caiqian@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.