* [PATCH] drm/ttm: Fix missing return
@ 2010-10-01 8:09 Thomas Hellstrom
2010-10-01 10:14 ` Thomas Hellstrom
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Hellstrom @ 2010-10-01 8:09 UTC (permalink / raw)
To: airlied; +Cc: Thomas Hellstrom, dri-devel
The commit "drm/ttm: Fix two race conditions"
was missing a return statement in a very unlikely code path.
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index b98cb2c..d6000d7 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -524,6 +524,7 @@ static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo, bool remove_all)
atomic_set(&bo->reserved, 0);
wake_up_all(&bo->event_queue);
spin_unlock(&glob->lru_lock);
+ return 0;
}
put_count = ttm_bo_del_from_lru(bo);
--
1.6.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/ttm: Fix missing return
2010-10-01 8:09 [PATCH] drm/ttm: Fix missing return Thomas Hellstrom
@ 2010-10-01 10:14 ` Thomas Hellstrom
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Hellstrom @ 2010-10-01 10:14 UTC (permalink / raw)
To: airlied@redhat.com; +Cc: Thomas Hellstrom, dri-devel@lists.freedesktop.org
Hmm. Forget this patch! I must have been extremely tired today. A new
one coming up in a moment.
/Thomas
On 10/01/2010 10:09 AM, Thomas Hellstrom wrote:
> The commit "drm/ttm: Fix two race conditions"
> was missing a return statement in a very unlikely code path.
>
> Signed-off-by: Thomas Hellstrom<thellstrom@vmware.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index b98cb2c..d6000d7 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -524,6 +524,7 @@ static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo, bool remove_all)
> atomic_set(&bo->reserved, 0);
> wake_up_all(&bo->event_queue);
> spin_unlock(&glob->lru_lock);
> + return 0;
> }
>
> put_count = ttm_bo_del_from_lru(bo);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-01 10:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-01 8:09 [PATCH] drm/ttm: Fix missing return Thomas Hellstrom
2010-10-01 10:14 ` Thomas Hellstrom
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.