[PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines

[PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/cx25821/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/cx25821/Makefile b/drivers/staging/cx25821/Makefile
index d0eb16e..6448364 100644
--- a/drivers/staging/cx25821/Makefile
+++ b/drivers/staging/cx25821/Makefile
@@ -7,7 +7,7 @@ cx25821-objs   := cx25821-core.o cx25821-cards.o cx25821-i2c.o \
 obj-$(CONFIG_VIDEO_CX25821) += cx25821.o
 obj-$(CONFIG_VIDEO_CX25821_ALSA) += cx25821-alsa.o
 
-EXTRA_CFLAGS += -Idrivers/media/video
-EXTRA_CFLAGS += -Idrivers/media/common/tuners
-EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
-EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
+ccflags-y := -Idrivers/media/video
+ccflags-y += -Idrivers/media/common/tuners
+ccflags-y += -Idrivers/media/dvb/dvb-core
+ccflags-y += -Idrivers/media/dvb/frontends
-- 
1.7.3.1.50.g1e633

[PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/cx25821/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/cx25821/Makefile b/drivers/staging/cx25821/Makefile
index d0eb16e..6448364 100644
--- a/drivers/staging/cx25821/Makefile
+++ b/drivers/staging/cx25821/Makefile
@@ -7,7 +7,7 @@ cx25821-objs   := cx25821-core.o cx25821-cards.o cx25821-i2c.o \
 obj-$(CONFIG_VIDEO_CX25821) += cx25821.o
 obj-$(CONFIG_VIDEO_CX25821_ALSA) += cx25821-alsa.o
 
-EXTRA_CFLAGS += -Idrivers/media/video
-EXTRA_CFLAGS += -Idrivers/media/common/tuners
-EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
-EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
+ccflags-y := -Idrivers/media/video
+ccflags-y += -Idrivers/media/common/tuners
+ccflags-y += -Idrivers/media/dvb/dvb-core
+ccflags-y += -Idrivers/media/dvb/frontends
-- 
1.7.3.1.50.g1e633

[PATCH v3 02/20] Staging: cxt1e1: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/cxt1e1/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/cxt1e1/Makefile b/drivers/staging/cxt1e1/Makefile
index 10020d7..a524a62 100644
--- a/drivers/staging/cxt1e1/Makefile
+++ b/drivers/staging/cxt1e1/Makefile
@@ -1,8 +1,8 @@
 obj-$(CONFIG_CXT1E1)	+= cxt1e1.o
 
-EXTRA_CFLAGS += -DSBE_PMCC4_ENABLE
-EXTRA_CFLAGS += -DSBE_ISR_TASKLET
-EXTRA_CFLAGS += -DSBE_INCLUDE_SYMBOLS
+ccflags-y := -DSBE_PMCC4_ENABLE
+ccflags-y += -DSBE_ISR_TASKLET
+ccflags-y += -DSBE_INCLUDE_SYMBOLS
 
 cxt1e1-objs += 	\
   ossiRelease.o 	\
-- 
1.7.3.1.50.g1e633

[PATCH v3 02/20] Staging: cxt1e1: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/cxt1e1/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/cxt1e1/Makefile b/drivers/staging/cxt1e1/Makefile
index 10020d7..a524a62 100644
--- a/drivers/staging/cxt1e1/Makefile
+++ b/drivers/staging/cxt1e1/Makefile
@@ -1,8 +1,8 @@
 obj-$(CONFIG_CXT1E1)	+= cxt1e1.o
 
-EXTRA_CFLAGS += -DSBE_PMCC4_ENABLE
-EXTRA_CFLAGS += -DSBE_ISR_TASKLET
-EXTRA_CFLAGS += -DSBE_INCLUDE_SYMBOLS
+ccflags-y := -DSBE_PMCC4_ENABLE
+ccflags-y += -DSBE_ISR_TASKLET
+ccflags-y += -DSBE_INCLUDE_SYMBOLS
 
 cxt1e1-objs += 	\
   ossiRelease.o 	\
-- 
1.7.3.1.50.g1e633

[PATCH v3 03/20] Staging: dream: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/dream/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/dream/Makefile b/drivers/staging/dream/Makefile
index fbea0ab..87de1a5 100644
--- a/drivers/staging/dream/Makefile
+++ b/drivers/staging/dream/Makefile
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS=-Idrivers/staging/dream/include
+ccflags-y:=-Idrivers/staging/dream/include
 obj-$(CONFIG_MSM_ADSP)		+= qdsp5/
 obj-$(CONFIG_MSM_CAMERA)	+= camera/
 obj-$(CONFIG_INPUT_GPIO)	+= gpio_axis.o gpio_event.o gpio_input.o gpio_matrix.o gpio_output.o
-- 
1.7.3.1.50.g1e633

[PATCH v3 03/20] Staging: dream: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/dream/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/dream/Makefile b/drivers/staging/dream/Makefile
index fbea0ab..87de1a5 100644
--- a/drivers/staging/dream/Makefile
+++ b/drivers/staging/dream/Makefile
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS=-Idrivers/staging/dream/include
+ccflags-y:=-Idrivers/staging/dream/include
 obj-$(CONFIG_MSM_ADSP)		+= qdsp5/
 obj-$(CONFIG_MSM_CAMERA)	+= camera/
 obj-$(CONFIG_INPUT_GPIO)	+= gpio_axis.o gpio_event.o gpio_input.o gpio_matrix.o gpio_output.o
-- 
1.7.3.1.50.g1e633

[PATCH v3 04/20] Staging: dream: camera: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/dream/camera/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/dream/camera/Makefile b/drivers/staging/dream/camera/Makefile
index db228d7..03711dc 100644
--- a/drivers/staging/dream/camera/Makefile
+++ b/drivers/staging/dream/camera/Makefile
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS=-Idrivers/staging/dream/include
+ccflags-y:=-Idrivers/staging/dream/include
 obj-$(CONFIG_MT9T013) += mt9t013.o mt9t013_reg.o
 obj-$(CONFIG_MT9D112) += mt9d112.o mt9d112_reg.o
 obj-$(CONFIG_MT9P012) += mt9p012_fox.o mt9p012_reg.o
-- 
1.7.3.1.50.g1e633

[PATCH v3 04/20] Staging: dream: camera: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/dream/camera/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/dream/camera/Makefile b/drivers/staging/dream/camera/Makefile
index db228d7..03711dc 100644
--- a/drivers/staging/dream/camera/Makefile
+++ b/drivers/staging/dream/camera/Makefile
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS=-Idrivers/staging/dream/include
+ccflags-y:=-Idrivers/staging/dream/include
 obj-$(CONFIG_MT9T013) += mt9t013.o mt9t013_reg.o
 obj-$(CONFIG_MT9D112) += mt9d112.o mt9d112_reg.o
 obj-$(CONFIG_MT9P012) += mt9p012_fox.o mt9p012_reg.o
-- 
1.7.3.1.50.g1e633

[PATCH v3 05/20] Staging: dream: qdsp5: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/dream/qdsp5/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/dream/qdsp5/Makefile b/drivers/staging/dream/qdsp5/Makefile
index beedaaf..44ae6b4 100644
--- a/drivers/staging/dream/qdsp5/Makefile
+++ b/drivers/staging/dream/qdsp5/Makefile
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS=-Idrivers/staging/dream/include
+ccflags-y:=-Idrivers/staging/dream/include
 obj-y += adsp.o
 ifeq ($(CONFIG_MSM_AMSS_VERSION_6350),y)
 obj-y += adsp_info.o
-- 
1.7.3.1.50.g1e633

[PATCH v3 05/20] Staging: dream: qdsp5: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/dream/qdsp5/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/dream/qdsp5/Makefile b/drivers/staging/dream/qdsp5/Makefile
index beedaaf..44ae6b4 100644
--- a/drivers/staging/dream/qdsp5/Makefile
+++ b/drivers/staging/dream/qdsp5/Makefile
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS=-Idrivers/staging/dream/include
+ccflags-y:=-Idrivers/staging/dream/include
 obj-y += adsp.o
 ifeq ($(CONFIG_MSM_AMSS_VERSION_6350),y)
 obj-y += adsp_info.o
-- 
1.7.3.1.50.g1e633

[PATCH v3 06/20] Stagng: easycap: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/easycap/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/easycap/Makefile b/drivers/staging/easycap/Makefile
index d93bd6b..680f370 100644
--- a/drivers/staging/easycap/Makefile
+++ b/drivers/staging/easycap/Makefile
@@ -5,9 +5,9 @@ easycap-objs	:= easycap_main.o easycap_low.o easycap_sound.o
 easycap-objs	+= easycap_ioctl.o easycap_settings.o
 easycap-objs	+= easycap_testcard.o
 
-EXTRA_CFLAGS += -Wall
+ccflags-y := -Wall
 # Impose all or none of the following:
-EXTRA_CFLAGS += -DEASYCAP_IS_VIDEODEV_CLIENT
-EXTRA_CFLAGS += -DEASYCAP_NEEDS_V4L2_DEVICE_H
-EXTRA_CFLAGS += -DEASYCAP_NEEDS_V4L2_FOPS
+ccflags-y += -DEASYCAP_IS_VIDEODEV_CLIENT
+ccflags-y += -DEASYCAP_NEEDS_V4L2_DEVICE_H
+ccflags-y += -DEASYCAP_NEEDS_V4L2_FOPS
 
-- 
1.7.3.1.50.g1e633

[PATCH v3 06/20] Stagng: easycap: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/easycap/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/easycap/Makefile b/drivers/staging/easycap/Makefile
index d93bd6b..680f370 100644
--- a/drivers/staging/easycap/Makefile
+++ b/drivers/staging/easycap/Makefile
@@ -5,9 +5,9 @@ easycap-objs	:= easycap_main.o easycap_low.o easycap_sound.o
 easycap-objs	+= easycap_ioctl.o easycap_settings.o
 easycap-objs	+= easycap_testcard.o
 
-EXTRA_CFLAGS += -Wall
+ccflags-y := -Wall
 # Impose all or none of the following:
-EXTRA_CFLAGS += -DEASYCAP_IS_VIDEODEV_CLIENT
-EXTRA_CFLAGS += -DEASYCAP_NEEDS_V4L2_DEVICE_H
-EXTRA_CFLAGS += -DEASYCAP_NEEDS_V4L2_FOPS
+ccflags-y += -DEASYCAP_IS_VIDEODEV_CLIENT
+ccflags-y += -DEASYCAP_NEEDS_V4L2_DEVICE_H
+ccflags-y += -DEASYCAP_NEEDS_V4L2_FOPS
 
-- 
1.7.3.1.50.g1e633

[PATCH v3 07/20] Staging: rt2860: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rt2860/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rt2860/Makefile b/drivers/staging/rt2860/Makefile
index 23ae07f..d816ddb 100644
--- a/drivers/staging/rt2860/Makefile
+++ b/drivers/staging/rt2860/Makefile
@@ -1,10 +1,10 @@
 obj-$(CONFIG_RT2860)	+= rt2860sta.o
 
 # TODO: all of these should be removed
-EXTRA_CFLAGS += -DLINUX -DAGGREGATION_SUPPORT -DPIGGYBACK_SUPPORT -DWMM_SUPPORT
-EXTRA_CFLAGS += -DRTMP_MAC_PCI -DRTMP_PCI_SUPPORT -DRT2860
-EXTRA_CFLAGS += -DRTMP_RF_RW_SUPPORT -DRTMP_EFUSE_SUPPORT -DRT30xx -DRT3090
-EXTRA_CFLAGS += -DDBG
+ccflags-y := -DLINUX -DAGGREGATION_SUPPORT -DPIGGYBACK_SUPPORT -DWMM_SUPPORT
+ccflags-y += -DRTMP_MAC_PCI -DRTMP_PCI_SUPPORT -DRT2860
+ccflags-y += -DRTMP_RF_RW_SUPPORT -DRTMP_EFUSE_SUPPORT -DRT30xx -DRT3090
+ccflags-y += -DDBG
 
 rt2860sta-objs :=	\
 	common/crypt_md5.o	\
-- 
1.7.3.1.50.g1e633

[PATCH v3 07/20] Staging: rt2860: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rt2860/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rt2860/Makefile b/drivers/staging/rt2860/Makefile
index 23ae07f..d816ddb 100644
--- a/drivers/staging/rt2860/Makefile
+++ b/drivers/staging/rt2860/Makefile
@@ -1,10 +1,10 @@
 obj-$(CONFIG_RT2860)	+= rt2860sta.o
 
 # TODO: all of these should be removed
-EXTRA_CFLAGS += -DLINUX -DAGGREGATION_SUPPORT -DPIGGYBACK_SUPPORT -DWMM_SUPPORT
-EXTRA_CFLAGS += -DRTMP_MAC_PCI -DRTMP_PCI_SUPPORT -DRT2860
-EXTRA_CFLAGS += -DRTMP_RF_RW_SUPPORT -DRTMP_EFUSE_SUPPORT -DRT30xx -DRT3090
-EXTRA_CFLAGS += -DDBG
+ccflags-y := -DLINUX -DAGGREGATION_SUPPORT -DPIGGYBACK_SUPPORT -DWMM_SUPPORT
+ccflags-y += -DRTMP_MAC_PCI -DRTMP_PCI_SUPPORT -DRT2860
+ccflags-y += -DRTMP_RF_RW_SUPPORT -DRTMP_EFUSE_SUPPORT -DRT30xx -DRT3090
+ccflags-y += -DDBG
 
 rt2860sta-objs :=	\
 	common/crypt_md5.o	\
-- 
1.7.3.1.50.g1e633

[PATCH v3 08/20] Staging: rt2870: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rt2870/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rt2870/Makefile b/drivers/staging/rt2870/Makefile
index 523e7e7..7b29493 100644
--- a/drivers/staging/rt2870/Makefile
+++ b/drivers/staging/rt2870/Makefile
@@ -2,10 +2,10 @@
 obj-$(CONFIG_RT2870)	+= rt2870sta.o
 
 # TODO: all of these should be removed
-EXTRA_CFLAGS += -DLINUX -DAGGREGATION_SUPPORT -DPIGGYBACK_SUPPORT -DWMM_SUPPORT
-EXTRA_CFLAGS += -DRTMP_MAC_USB -DRTMP_USB_SUPPORT -DRT2870 -DRTMP_TIMER_TASK_SUPPORT
-EXTRA_CFLAGS += -DRTMP_RF_RW_SUPPORT -DRTMP_EFUSE_SUPPORT -DRT30xx -DRT3070
-EXTRA_CFLAGS += -DDBG
+ccflags-y := -DLINUX -DAGGREGATION_SUPPORT -DPIGGYBACK_SUPPORT -DWMM_SUPPORT
+ccflags-y += -DRTMP_MAC_USB -DRTMP_USB_SUPPORT -DRT2870 -DRTMP_TIMER_TASK_SUPPORT
+ccflags-y += -DRTMP_RF_RW_SUPPORT -DRTMP_EFUSE_SUPPORT -DRT30xx -DRT3070
+ccflags-y += -DDBG
 
 rt2870sta-objs :=		\
 	common/crypt_md5.o	\
-- 
1.7.3.1.50.g1e633

[PATCH v3 08/20] Staging: rt2870: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rt2870/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rt2870/Makefile b/drivers/staging/rt2870/Makefile
index 523e7e7..7b29493 100644
--- a/drivers/staging/rt2870/Makefile
+++ b/drivers/staging/rt2870/Makefile
@@ -2,10 +2,10 @@
 obj-$(CONFIG_RT2870)	+= rt2870sta.o
 
 # TODO: all of these should be removed
-EXTRA_CFLAGS += -DLINUX -DAGGREGATION_SUPPORT -DPIGGYBACK_SUPPORT -DWMM_SUPPORT
-EXTRA_CFLAGS += -DRTMP_MAC_USB -DRTMP_USB_SUPPORT -DRT2870 -DRTMP_TIMER_TASK_SUPPORT
-EXTRA_CFLAGS += -DRTMP_RF_RW_SUPPORT -DRTMP_EFUSE_SUPPORT -DRT30xx -DRT3070
-EXTRA_CFLAGS += -DDBG
+ccflags-y := -DLINUX -DAGGREGATION_SUPPORT -DPIGGYBACK_SUPPORT -DWMM_SUPPORT
+ccflags-y += -DRTMP_MAC_USB -DRTMP_USB_SUPPORT -DRT2870 -DRTMP_TIMER_TASK_SUPPORT
+ccflags-y += -DRTMP_RF_RW_SUPPORT -DRTMP_EFUSE_SUPPORT -DRT30xx -DRT3070
+ccflags-y += -DDBG
 
 rt2870sta-objs :=		\
 	common/crypt_md5.o	\
-- 
1.7.3.1.50.g1e633

[PATCH v3 09/20] Staging: rtl8187se: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rtl8187se/Makefile |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8187se/Makefile b/drivers/staging/rtl8187se/Makefile
index e6adf91..adc3849 100644
--- a/drivers/staging/rtl8187se/Makefile
+++ b/drivers/staging/rtl8187se/Makefile
@@ -4,17 +4,17 @@
 #EXTRA_CFLAGS += -O2
 #CC            = gcc
 
-EXTRA_CFLAGS += -DSW_ANTE
-EXTRA_CFLAGS += -DTX_TRACK
-EXTRA_CFLAGS += -DHIGH_POWER
-EXTRA_CFLAGS += -DSW_DIG
-EXTRA_CFLAGS += -DRATE_ADAPT
+ccflags-y := -DSW_ANTE
+ccflags-y += -DTX_TRACK
+ccflags-y += -DHIGH_POWER
+ccflags-y += -DSW_DIG
+ccflags-y += -DRATE_ADAPT
 
 #enable it for legacy power save, disable it for leisure  power save
-EXTRA_CFLAGS += -DENABLE_LPS
+ccflags-y += -DENABLE_LPS
 
 
-#EXTRA_CFLAGS += -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y
+#ccflags-y := -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y
 
 r8187se-objs :=			\
 		r8180_core.o		\
-- 
1.7.3.1.50.g1e633

[PATCH v3 09/20] Staging: rtl8187se: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rtl8187se/Makefile |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8187se/Makefile b/drivers/staging/rtl8187se/Makefile
index e6adf91..adc3849 100644
--- a/drivers/staging/rtl8187se/Makefile
+++ b/drivers/staging/rtl8187se/Makefile
@@ -4,17 +4,17 @@
 #EXTRA_CFLAGS += -O2
 #CC            = gcc
 
-EXTRA_CFLAGS += -DSW_ANTE
-EXTRA_CFLAGS += -DTX_TRACK
-EXTRA_CFLAGS += -DHIGH_POWER
-EXTRA_CFLAGS += -DSW_DIG
-EXTRA_CFLAGS += -DRATE_ADAPT
+ccflags-y := -DSW_ANTE
+ccflags-y += -DTX_TRACK
+ccflags-y += -DHIGH_POWER
+ccflags-y += -DSW_DIG
+ccflags-y += -DRATE_ADAPT
 
 #enable it for legacy power save, disable it for leisure  power save
-EXTRA_CFLAGS += -DENABLE_LPS
+ccflags-y += -DENABLE_LPS
 
 
-#EXTRA_CFLAGS += -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y
+#ccflags-y := -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y
 
 r8187se-objs :=			\
 		r8180_core.o		\
-- 
1.7.3.1.50.g1e633

[PATCH v3 10/20] Staging: rtl8192e: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rtl8192e/Makefile |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8192e/Makefile b/drivers/staging/rtl8192e/Makefile
index 41cb4d3..6e41067 100644
--- a/drivers/staging/rtl8192e/Makefile
+++ b/drivers/staging/rtl8192e/Makefile
@@ -1,13 +1,13 @@
 NIC_SELECT = RTL8192E
 
-EXTRA_CFLAGS += -DRTL8192E
-EXTRA_CFLAGS += -std=gnu89
-EXTRA_CFLAGS += -O2
-EXTRA_CFLAGS += -DTHOMAS_TURBO
-EXTRA_CFLAGS += -DENABLE_DOT11D
+ccflags-y := -DRTL8192E
+ccflags-y += -std=gnu89
+ccflags-y += -O2
+ccflags-y += -DTHOMAS_TURBO
+ccflags-y += -DENABLE_DOT11D
 
-EXTRA_CFLAGS += -DENABLE_IPS
-EXTRA_CFLAGS += -DENABLE_LPS
+ccflags-y += -DENABLE_IPS
+ccflags-y += -DENABLE_LPS
 
 r8192e_pci-objs :=		\
 	r8192E_core.o		\
-- 
1.7.3.1.50.g1e633

[PATCH v3 10/20] Staging: rtl8192e: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rtl8192e/Makefile |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8192e/Makefile b/drivers/staging/rtl8192e/Makefile
index 41cb4d3..6e41067 100644
--- a/drivers/staging/rtl8192e/Makefile
+++ b/drivers/staging/rtl8192e/Makefile
@@ -1,13 +1,13 @@
 NIC_SELECT = RTL8192E
 
-EXTRA_CFLAGS += -DRTL8192E
-EXTRA_CFLAGS += -std=gnu89
-EXTRA_CFLAGS += -O2
-EXTRA_CFLAGS += -DTHOMAS_TURBO
-EXTRA_CFLAGS += -DENABLE_DOT11D
+ccflags-y := -DRTL8192E
+ccflags-y += -std=gnu89
+ccflags-y += -O2
+ccflags-y += -DTHOMAS_TURBO
+ccflags-y += -DENABLE_DOT11D
 
-EXTRA_CFLAGS += -DENABLE_IPS
-EXTRA_CFLAGS += -DENABLE_LPS
+ccflags-y += -DENABLE_IPS
+ccflags-y += -DENABLE_LPS
 
 r8192e_pci-objs :=		\
 	r8192E_core.o		\
-- 
1.7.3.1.50.g1e633

[PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rtl8192su/Makefile |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192su/Makefile b/drivers/staging/rtl8192su/Makefile
index 7133894..1120c04 100644
--- a/drivers/staging/rtl8192su/Makefile
+++ b/drivers/staging/rtl8192su/Makefile
@@ -1,12 +1,12 @@
 NIC_SELECT = RTL8192SU
 
-EXTRA_CFLAGS += -std=gnu89
-EXTRA_CFLAGS += -O2
+ccflags-y := -std=gnu89
+ccflags-y += -O2
 
-EXTRA_CFLAGS += -DJACKSON_NEW_RX
-EXTRA_CFLAGS += -DTHOMAS_BEACON
+ccflags-y += -DJACKSON_NEW_RX
+ccflags-y += -DTHOMAS_BEACON
 
-#EXTRA_CFLAGS += -DMUTIPLE_BULK_OUT
+#ccflags-y += -DMUTIPLE_BULK_OUT
 
 r8192s_usb-objs :=		\
 	r8192U_wx.o		\
-- 
1.7.3.1.50.g1e633

[PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rtl8192su/Makefile |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192su/Makefile b/drivers/staging/rtl8192su/Makefile
index 7133894..1120c04 100644
--- a/drivers/staging/rtl8192su/Makefile
+++ b/drivers/staging/rtl8192su/Makefile
@@ -1,12 +1,12 @@
 NIC_SELECT = RTL8192SU
 
-EXTRA_CFLAGS += -std=gnu89
-EXTRA_CFLAGS += -O2
+ccflags-y := -std=gnu89
+ccflags-y += -O2
 
-EXTRA_CFLAGS += -DJACKSON_NEW_RX
-EXTRA_CFLAGS += -DTHOMAS_BEACON
+ccflags-y += -DJACKSON_NEW_RX
+ccflags-y += -DTHOMAS_BEACON
 
-#EXTRA_CFLAGS += -DMUTIPLE_BULK_OUT
+#ccflags-y += -DMUTIPLE_BULK_OUT
 
 r8192s_usb-objs :=		\
 	r8192U_wx.o		\
-- 
1.7.3.1.50.g1e633

[PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rtl8192su/ieee80211/Makefile |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192su/ieee80211/Makefile b/drivers/staging/rtl8192su/ieee80211/Makefile
index a500bfa..5bee643 100644
--- a/drivers/staging/rtl8192su/ieee80211/Makefile
+++ b/drivers/staging/rtl8192su/ieee80211/Makefile
@@ -1,10 +1,10 @@
 NIC_SELECT = RTL8192SU
 
-EXTRA_CFLAGS += -O2
-EXTRA_CFLAGS += -DRTL8192S_DISABLE_FW_DM=0
-EXTRA_CFLAGS += -DRTL8192SU
-#EXTRA_CFLAGS += -DJOHN_NOCPY
-EXTRA_CFLAGS += -DTHOMAS_TURBO
+ccflags-y := -O2
+ccflags-y += -DRTL8192S_DISABLE_FW_DM=0
+ccflags-y += -DRTL8192SU
+#ccflags-y += -DJOHN_NOCPY
+ccflags-y += -DTHOMAS_TURBO
 
 ieee80211-rsl-objs := ieee80211_rx.o \
 		      ieee80211_softmac.o \
-- 
1.7.3.1.50.g1e633

[PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rtl8192su/ieee80211/Makefile |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192su/ieee80211/Makefile b/drivers/staging/rtl8192su/ieee80211/Makefile
index a500bfa..5bee643 100644
--- a/drivers/staging/rtl8192su/ieee80211/Makefile
+++ b/drivers/staging/rtl8192su/ieee80211/Makefile
@@ -1,10 +1,10 @@
 NIC_SELECT = RTL8192SU
 
-EXTRA_CFLAGS += -O2
-EXTRA_CFLAGS += -DRTL8192S_DISABLE_FW_DM=0
-EXTRA_CFLAGS += -DRTL8192SU
-#EXTRA_CFLAGS += -DJOHN_NOCPY
-EXTRA_CFLAGS += -DTHOMAS_TURBO
+ccflags-y := -O2
+ccflags-y += -DRTL8192S_DISABLE_FW_DM=0
+ccflags-y += -DRTL8192SU
+#ccflags-y += -DJOHN_NOCPY
+ccflags-y += -DTHOMAS_TURBO
 
 ieee80211-rsl-objs := ieee80211_rx.o \
 		      ieee80211_softmac.o \
-- 
1.7.3.1.50.g1e633

[PATCH v3 13/20] Staging: rtl8192u: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rtl8192u/Makefile |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/rtl8192u/Makefile b/drivers/staging/rtl8192u/Makefile
index 738f4a8..cba4344 100644
--- a/drivers/staging/rtl8192u/Makefile
+++ b/drivers/staging/rtl8192u/Makefile
@@ -1,16 +1,16 @@
 NIC_SELECT = RTL8192U
 
-EXTRA_CFLAGS += -std=gnu89
-EXTRA_CFLAGS += -O2
+ccflags-y := -std=gnu89
+ccflags-y += -O2
 
-EXTRA_CFLAGS += -DCONFIG_FORCE_HARD_FLOAT=y
-EXTRA_CFLAGS += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
-EXTRA_CFLAGS += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO
-#EXTRA_CFLAGS += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
-#EXTRA_CFLAGS += -DUSB_RX_AGGREGATION_SUPPORT
-EXTRA_CFLAGS += -DUSE_ONE_PIPE
-EXTRA_CFLAGS += -DENABLE_DOT11D
-EXTRA_CFLAGS += -Idrivers/staging/rtl8192u/ieee80211
+ccflags-y += -DCONFIG_FORCE_HARD_FLOAT=y
+ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
+ccflags-y += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO
+#ccflags-y += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
+#ccflags-y += -DUSB_RX_AGGREGATION_SUPPORT
+ccflags-y += -DUSE_ONE_PIPE
+ccflags-y += -DENABLE_DOT11D
+ccflags-y += -Idrivers/staging/rtl8192u/ieee80211
 
 r8192u_usb-objs := r8192U_core.o r8180_93cx6.o r8192U_wx.o		\
 		  r8190_rtl8256.o r819xU_phy.o r819xU_firmware.o	\
-- 
1.7.3.1.50.g1e633

[PATCH v3 13/20] Staging: rtl8192u: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rtl8192u/Makefile |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/rtl8192u/Makefile b/drivers/staging/rtl8192u/Makefile
index 738f4a8..cba4344 100644
--- a/drivers/staging/rtl8192u/Makefile
+++ b/drivers/staging/rtl8192u/Makefile
@@ -1,16 +1,16 @@
 NIC_SELECT = RTL8192U
 
-EXTRA_CFLAGS += -std=gnu89
-EXTRA_CFLAGS += -O2
+ccflags-y := -std=gnu89
+ccflags-y += -O2
 
-EXTRA_CFLAGS += -DCONFIG_FORCE_HARD_FLOAT=y
-EXTRA_CFLAGS += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
-EXTRA_CFLAGS += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO
-#EXTRA_CFLAGS += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
-#EXTRA_CFLAGS += -DUSB_RX_AGGREGATION_SUPPORT
-EXTRA_CFLAGS += -DUSE_ONE_PIPE
-EXTRA_CFLAGS += -DENABLE_DOT11D
-EXTRA_CFLAGS += -Idrivers/staging/rtl8192u/ieee80211
+ccflags-y += -DCONFIG_FORCE_HARD_FLOAT=y
+ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
+ccflags-y += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO
+#ccflags-y += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
+#ccflags-y += -DUSB_RX_AGGREGATION_SUPPORT
+ccflags-y += -DUSE_ONE_PIPE
+ccflags-y += -DENABLE_DOT11D
+ccflags-y += -Idrivers/staging/rtl8192u/ieee80211
 
 r8192u_usb-objs := r8192U_core.o r8180_93cx6.o r8192U_wx.o		\
 		  r8190_rtl8256.o r819xU_phy.o r819xU_firmware.o	\
-- 
1.7.3.1.50.g1e633

[PATCH v3 14/20] Staging: rtl8192u: ieee80211: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/Makefile |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/Makefile b/drivers/staging/rtl8192u/ieee80211/Makefile
index 71ca5d9..45704f8 100644
--- a/drivers/staging/rtl8192u/ieee80211/Makefile
+++ b/drivers/staging/rtl8192u/ieee80211/Makefile
@@ -5,22 +5,22 @@ MODDESTDIR := /lib/modules/$(KVER)/kernel/drivers/net/wireless/$(NIC_SELECT)
 
 CC = gcc
 ifneq ($(shell uname -r|cut -d. -f1,2), 2.4)
-EXTRA_CFLAGS += -I$(TOPDIR)/drivers/net/wireless
-EXTRA_CFLAGS += -O2
-EXTRA_CFLAGS += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
+ccflags-y := -I$(TOPDIR)/drivers/net/wireless
+ccflags-y += -O2
+ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
 
 #it will fail to compile in suse linux enterprise 10 sp2. This flag is to solve this problem.
 ifeq ($(shell uname -r | cut -d. -f1,2,3,4), 2.6.16.60-0)
-EXTRA_CFLAGS += -DOPENSUSE_SLED
+ccflags-y := -DOPENSUSE_SLED
 endif
 
 ifeq ($(NIC_SELECT),RTL8192U)
-#EXTRA_CFLAGS += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
-#EXTRA_CFLAGS += -DUSB_RX_AGGREGATION_SUPPORT
+#ccflags-y := -DUSB_TX_DRIVER_AGGREGATION_ENABLE
+#ccflags-y := -DUSB_RX_AGGREGATION_SUPPORT
 endif
-#EXTRA_CFLAGS += -DJOHN_NOCPY
+#ccflags-y := -DJOHN_NOCPY
 #flags to enable or disble 80211D feature
-EXTRA_CFLAGS += -DENABLE_DOT11D
+ccflags-y += -DENABLE_DOT11D
 ieee80211-rsl-objs := ieee80211_rx.o \
 		      ieee80211_softmac.o \
 		      ieee80211_tx.o \
-- 
1.7.3.1.50.g1e633

[PATCH v3 14/20] Staging: rtl8192u: ieee80211: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/Makefile |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/Makefile b/drivers/staging/rtl8192u/ieee80211/Makefile
index 71ca5d9..45704f8 100644
--- a/drivers/staging/rtl8192u/ieee80211/Makefile
+++ b/drivers/staging/rtl8192u/ieee80211/Makefile
@@ -5,22 +5,22 @@ MODDESTDIR := /lib/modules/$(KVER)/kernel/drivers/net/wireless/$(NIC_SELECT)
 
 CC = gcc
 ifneq ($(shell uname -r|cut -d. -f1,2), 2.4)
-EXTRA_CFLAGS += -I$(TOPDIR)/drivers/net/wireless
-EXTRA_CFLAGS += -O2
-EXTRA_CFLAGS += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
+ccflags-y := -I$(TOPDIR)/drivers/net/wireless
+ccflags-y += -O2
+ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
 
 #it will fail to compile in suse linux enterprise 10 sp2. This flag is to solve this problem.
 ifeq ($(shell uname -r | cut -d. -f1,2,3,4), 2.6.16.60-0)
-EXTRA_CFLAGS += -DOPENSUSE_SLED
+ccflags-y := -DOPENSUSE_SLED
 endif
 
 ifeq ($(NIC_SELECT),RTL8192U)
-#EXTRA_CFLAGS += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
-#EXTRA_CFLAGS += -DUSB_RX_AGGREGATION_SUPPORT
+#ccflags-y := -DUSB_TX_DRIVER_AGGREGATION_ENABLE
+#ccflags-y := -DUSB_RX_AGGREGATION_SUPPORT
 endif
-#EXTRA_CFLAGS += -DJOHN_NOCPY
+#ccflags-y := -DJOHN_NOCPY
 #flags to enable or disble 80211D feature
-EXTRA_CFLAGS += -DENABLE_DOT11D
+ccflags-y += -DENABLE_DOT11D
 ieee80211-rsl-objs := ieee80211_rx.o \
 		      ieee80211_softmac.o \
 		      ieee80211_tx.o \
-- 
1.7.3.1.50.g1e633

[PATCH v3 15/20] Staging: tm6000: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/tm6000/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/tm6000/Makefile b/drivers/staging/tm6000/Makefile
index 77e06bf..d8ccdaa 100644
--- a/drivers/staging/tm6000/Makefile
+++ b/drivers/staging/tm6000/Makefile
@@ -9,7 +9,7 @@ obj-$(CONFIG_VIDEO_TM6000) += tm6000.o
 obj-$(CONFIG_VIDEO_TM6000_ALSA) += tm6000-alsa.o
 obj-$(CONFIG_VIDEO_TM6000_DVB) += tm6000-dvb.o
 
-EXTRA_CFLAGS = -Idrivers/media/video
-EXTRA_CFLAGS += -Idrivers/media/common/tuners
-EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
-EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
+ccflags-y := -Idrivers/media/video
+ccflags-y += -Idrivers/media/common/tuners
+ccflags-y += -Idrivers/media/dvb/dvb-core
+ccflags-y += -Idrivers/media/dvb/frontends
-- 
1.7.3.1.50.g1e633

[PATCH v3 15/20] Staging: tm6000: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/tm6000/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/tm6000/Makefile b/drivers/staging/tm6000/Makefile
index 77e06bf..d8ccdaa 100644
--- a/drivers/staging/tm6000/Makefile
+++ b/drivers/staging/tm6000/Makefile
@@ -9,7 +9,7 @@ obj-$(CONFIG_VIDEO_TM6000) += tm6000.o
 obj-$(CONFIG_VIDEO_TM6000_ALSA) += tm6000-alsa.o
 obj-$(CONFIG_VIDEO_TM6000_DVB) += tm6000-dvb.o
 
-EXTRA_CFLAGS = -Idrivers/media/video
-EXTRA_CFLAGS += -Idrivers/media/common/tuners
-EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
-EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
+ccflags-y := -Idrivers/media/video
+ccflags-y += -Idrivers/media/common/tuners
+ccflags-y += -Idrivers/media/dvb/dvb-core
+ccflags-y += -Idrivers/media/dvb/frontends
-- 
1.7.3.1.50.g1e633

[PATCH v3 16/20] Staging: usbip: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/usbip/Makefile |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/usbip/Makefile b/drivers/staging/usbip/Makefile
index 6f2916b..10307f8 100644
--- a/drivers/staging/usbip/Makefile
+++ b/drivers/staging/usbip/Makefile
@@ -7,6 +7,5 @@ vhci-hcd-objs := vhci_sysfs.o vhci_tx.o vhci_rx.o vhci_hcd.o
 obj-$(CONFIG_USB_IP_HOST) += usbip.o
 usbip-objs := stub_dev.o stub_main.o stub_rx.o stub_tx.o
 
-ifeq ($(CONFIG_USB_IP_DEBUG_ENABLE),y)
-	EXTRA_CFLAGS += -DDEBUG
-endif
+ccflags-$(CONFIG_USB_IP_DEBUG_ENABLE) := -DDEBUG
+
-- 
1.7.3.1.50.g1e633

[PATCH v3 16/20] Staging: usbip: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/usbip/Makefile |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/usbip/Makefile b/drivers/staging/usbip/Makefile
index 6f2916b..10307f8 100644
--- a/drivers/staging/usbip/Makefile
+++ b/drivers/staging/usbip/Makefile
@@ -7,6 +7,5 @@ vhci-hcd-objs := vhci_sysfs.o vhci_tx.o vhci_rx.o vhci_hcd.o
 obj-$(CONFIG_USB_IP_HOST) += usbip.o
 usbip-objs := stub_dev.o stub_main.o stub_rx.o stub_tx.o
 
-ifeq ($(CONFIG_USB_IP_DEBUG_ENABLE),y)
-	EXTRA_CFLAGS += -DDEBUG
-endif
+ccflags-$(CONFIG_USB_IP_DEBUG_ENABLE) := -DDEBUG
+
-- 
1.7.3.1.50.g1e633

[PATCH v3 17/20] Staging: vt6655: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/vt6655/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/Makefile b/drivers/staging/vt6655/Makefile
index 824c971..f7544a6 100644
--- a/drivers/staging/vt6655/Makefile
+++ b/drivers/staging/vt6655/Makefile
@@ -1,6 +1,6 @@
 # TODO: all of these should be removed
-EXTRA_CFLAGS += -DLINUX -D__KERNEL__ -D__NO_VERSION__
-EXTRA_CFLAGS += -DHOSTAP
+ccflags-y := -DLINUX -D__KERNEL__ -D__NO_VERSION__
+ccflags-y += -DHOSTAP
 
 vt6655_stage-y +=	device_main.o \
 	card.o \
-- 
1.7.3.1.50.g1e633

[PATCH v3 17/20] Staging: vt6655: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/vt6655/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/Makefile b/drivers/staging/vt6655/Makefile
index 824c971..f7544a6 100644
--- a/drivers/staging/vt6655/Makefile
+++ b/drivers/staging/vt6655/Makefile
@@ -1,6 +1,6 @@
 # TODO: all of these should be removed
-EXTRA_CFLAGS += -DLINUX -D__KERNEL__ -D__NO_VERSION__
-EXTRA_CFLAGS += -DHOSTAP
+ccflags-y := -DLINUX -D__KERNEL__ -D__NO_VERSION__
+ccflags-y += -DHOSTAP
 
 vt6655_stage-y +=	device_main.o \
 	card.o \
-- 
1.7.3.1.50.g1e633

[PATCH v3 18/20] Staging: vt6656: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/vt6656/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile
index 582a35197..41ed06b 100644
--- a/drivers/staging/vt6656/Makefile
+++ b/drivers/staging/vt6656/Makefile
@@ -1,6 +1,6 @@
 # TODO: all of these should be removed
-EXTRA_CFLAGS += -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__
-EXTRA_CFLAGS += -DHOSTAP
+ccflags-y := -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__
+ccflags-y += -DHOSTAP
 
 vt6656_stage-y +=	main_usb.o \
 			card.o  \
-- 
1.7.3.1.50.g1e633

[PATCH v3 18/20] Staging: vt6656: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/vt6656/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile
index 582a35197..41ed06b 100644
--- a/drivers/staging/vt6656/Makefile
+++ b/drivers/staging/vt6656/Makefile
@@ -1,6 +1,6 @@
 # TODO: all of these should be removed
-EXTRA_CFLAGS += -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__
-EXTRA_CFLAGS += -DHOSTAP
+ccflags-y := -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__
+ccflags-y += -DHOSTAP
 
 vt6656_stage-y +=	main_usb.o \
 			card.o  \
-- 
1.7.3.1.50.g1e633

[PATCH v3 19/20] Staging: wlags49_h2: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/wlags49_h2/Makefile |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wlags49_h2/Makefile b/drivers/staging/wlags49_h2/Makefile
index 25d0a8a..e604ebd 100644
--- a/drivers/staging/wlags49_h2/Makefile
+++ b/drivers/staging/wlags49_h2/Makefile
@@ -12,8 +12,8 @@
 #  If you want to build AP support (untested), comment out -DSTA_ONLY
 
 INSTALLDIR := /lib/modules/$(shell uname -r)/kernel/drivers/net/wireless
-EXTRA_CFLAGS += -I$(KERNELDIR)/include
-EXTRA_CFLAGS += -I$(src) \
+ccflags-y := -I$(KERNELDIR)/include
+ccflags-y += -I$(src) \
 		-DBUS_PCMCIA \
 		-DUSE_WPA \
 		-DUSE_WEXT \
@@ -25,16 +25,16 @@ EXTRA_CFLAGS += -I$(src) \
 #		-DUSE_UIL \
 #		-DUSE_PROFILE \
 
-ifeq ($(findstring HERMES25,$(EXTRA_CFLAGS)),)
+ifeq ($(findstring HERMES25,$(ccflags-y)),)
 WLNAME := wlags49_h2_cs
 $(WLNAME)-y := sta_h2.o
-ifeq ($(findstring STA_ONLY,$(EXTRA_CFLAGS)),)
+ifeq ($(findstring STA_ONLY,$(ccflags-y)),)
 $(WLNAME)-y += ap_h2.o
 endif
 else
 WLNAME=wlags49_h25_cs
 $(WLNAME)-y := sta_h25.o
-ifeq ($(findstring STA_ONLY,$(EXTRA_CFLAGS)),)
+ifeq ($(findstring STA_ONLY,$(ccflags-y)),)
 $(WLNAME)-y += ap_h25.o
 endif
 endif
-- 
1.7.3.1.50.g1e633

[PATCH v3 19/20] Staging: wlags49_h2: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/wlags49_h2/Makefile |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wlags49_h2/Makefile b/drivers/staging/wlags49_h2/Makefile
index 25d0a8a..e604ebd 100644
--- a/drivers/staging/wlags49_h2/Makefile
+++ b/drivers/staging/wlags49_h2/Makefile
@@ -12,8 +12,8 @@
 #  If you want to build AP support (untested), comment out -DSTA_ONLY
 
 INSTALLDIR := /lib/modules/$(shell uname -r)/kernel/drivers/net/wireless
-EXTRA_CFLAGS += -I$(KERNELDIR)/include
-EXTRA_CFLAGS += -I$(src) \
+ccflags-y := -I$(KERNELDIR)/include
+ccflags-y += -I$(src) \
 		-DBUS_PCMCIA \
 		-DUSE_WPA \
 		-DUSE_WEXT \
@@ -25,16 +25,16 @@ EXTRA_CFLAGS += -I$(src) \
 #		-DUSE_UIL \
 #		-DUSE_PROFILE \
 
-ifeq ($(findstring HERMES25,$(EXTRA_CFLAGS)),)
+ifeq ($(findstring HERMES25,$(ccflags-y)),)
 WLNAME := wlags49_h2_cs
 $(WLNAME)-y := sta_h2.o
-ifeq ($(findstring STA_ONLY,$(EXTRA_CFLAGS)),)
+ifeq ($(findstring STA_ONLY,$(ccflags-y)),)
 $(WLNAME)-y += ap_h2.o
 endif
 else
 WLNAME=wlags49_h25_cs
 $(WLNAME)-y := sta_h25.o
-ifeq ($(findstring STA_ONLY,$(EXTRA_CFLAGS)),)
+ifeq ($(findstring STA_ONLY,$(ccflags-y)),)
 $(WLNAME)-y += ap_h25.o
 endif
 endif
-- 
1.7.3.1.50.g1e633

[PATCH v3 20/20] Staging: wlags49_h25: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/wlags49_h25/Makefile |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wlags49_h25/Makefile b/drivers/staging/wlags49_h25/Makefile
index d0b23d4..7d4b563 100644
--- a/drivers/staging/wlags49_h25/Makefile
+++ b/drivers/staging/wlags49_h25/Makefile
@@ -12,8 +12,8 @@
 #  If you want to build AP support (untested), comment out -DSTA_ONLY
 
 INSTALLDIR := /lib/modules/$(shell uname -r)/kernel/drivers/net/wireless
-EXTRA_CFLAGS += -I$(KERNELDIR)/include
-EXTRA_CFLAGS += -I$(src) \
+ccflags-y := -I$(KERNELDIR)/include
+ccflags-y += -I$(src) \
 		-DBUS_PCMCIA \
 		-DUSE_WPA \
 		-DUSE_WEXT \
@@ -25,16 +25,16 @@ EXTRA_CFLAGS += -I$(src) \
 #		-DUSE_UIL \
 #		-DUSE_PROFILE \
 
-ifeq ($(findstring HERMES25,$(EXTRA_CFLAGS)),)
+ifeq ($(findstring HERMES25,$(ccflags-y)),)
 WLNAME := wlags49_h2_cs
 $(WLNAME)-y := sta_h2.o
-ifeq ($(findstring STA_ONLY,$(EXTRA_CFLAGS)),)
+ifeq ($(findstring STA_ONLY,$(ccflags-y)),)
 $(WLNAME)-y += ap_h2.o
 endif
 else
 WLNAME=wlags49_h25_cs
 $(WLNAME)-y := sta_h25.o
-ifeq ($(findstring STA_ONLY,$(EXTRA_CFLAGS)),)
+ifeq ($(findstring STA_ONLY,$(ccflags-y)),)
 $(WLNAME)-y += ap_h25.o
 endif
 endif
-- 
1.7.3.1.50.g1e633

[PATCH v3 20/20] Staging: wlags49_h25: Makefile: cleaned up Makefile cflag lines

[Tracey Dent]

Changed to use the proper ccflags-y option

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/wlags49_h25/Makefile |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wlags49_h25/Makefile b/drivers/staging/wlags49_h25/Makefile
index d0b23d4..7d4b563 100644
--- a/drivers/staging/wlags49_h25/Makefile
+++ b/drivers/staging/wlags49_h25/Makefile
@@ -12,8 +12,8 @@
 #  If you want to build AP support (untested), comment out -DSTA_ONLY
 
 INSTALLDIR := /lib/modules/$(shell uname -r)/kernel/drivers/net/wireless
-EXTRA_CFLAGS += -I$(KERNELDIR)/include
-EXTRA_CFLAGS += -I$(src) \
+ccflags-y := -I$(KERNELDIR)/include
+ccflags-y += -I$(src) \
 		-DBUS_PCMCIA \
 		-DUSE_WPA \
 		-DUSE_WEXT \
@@ -25,16 +25,16 @@ EXTRA_CFLAGS += -I$(src) \
 #		-DUSE_UIL \
 #		-DUSE_PROFILE \
 
-ifeq ($(findstring HERMES25,$(EXTRA_CFLAGS)),)
+ifeq ($(findstring HERMES25,$(ccflags-y)),)
 WLNAME := wlags49_h2_cs
 $(WLNAME)-y := sta_h2.o
-ifeq ($(findstring STA_ONLY,$(EXTRA_CFLAGS)),)
+ifeq ($(findstring STA_ONLY,$(ccflags-y)),)
 $(WLNAME)-y += ap_h2.o
 endif
 else
 WLNAME=wlags49_h25_cs
 $(WLNAME)-y := sta_h25.o
-ifeq ($(findstring STA_ONLY,$(EXTRA_CFLAGS)),)
+ifeq ($(findstring STA_ONLY,$(ccflags-y)),)
 $(WLNAME)-y += ap_h25.o
 endif
 endif
-- 
1.7.3.1.50.g1e633

Re: [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/cx25821/Makefile |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/cx25821/Makefile b/drivers/staging/cx25821/Makefile
> index d0eb16e..6448364 100644
> --- a/drivers/staging/cx25821/Makefile
> +++ b/drivers/staging/cx25821/Makefile
> @@ -7,7 +7,7 @@ cx25821-objs   := cx25821-core.o cx25821-cards.o cx25821-i2c.o \
>  obj-$(CONFIG_VIDEO_CX25821) += cx25821.o
>  obj-$(CONFIG_VIDEO_CX25821_ALSA) += cx25821-alsa.o
>  
> -EXTRA_CFLAGS += -Idrivers/media/video
> -EXTRA_CFLAGS += -Idrivers/media/common/tuners
> -EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
> -EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
> +ccflags-y := -Idrivers/media/video
> +ccflags-y += -Idrivers/media/common/tuners
> +ccflags-y += -Idrivers/media/dvb/dvb-core
> +ccflags-y += -Idrivers/media/dvb/frontends

they have invented vpath for this, did they ?
note: I am not familiar with the linux makefile.

re,
 wh

Re: [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/cx25821/Makefile |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/cx25821/Makefile b/drivers/staging/cx25821/Makefile
> index d0eb16e..6448364 100644
> --- a/drivers/staging/cx25821/Makefile
> +++ b/drivers/staging/cx25821/Makefile
> @@ -7,7 +7,7 @@ cx25821-objs   := cx25821-core.o cx25821-cards.o cx25821-i2c.o \
>  obj-$(CONFIG_VIDEO_CX25821) += cx25821.o
>  obj-$(CONFIG_VIDEO_CX25821_ALSA) += cx25821-alsa.o
>  
> -EXTRA_CFLAGS += -Idrivers/media/video
> -EXTRA_CFLAGS += -Idrivers/media/common/tuners
> -EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
> -EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
> +ccflags-y := -Idrivers/media/video
> +ccflags-y += -Idrivers/media/common/tuners
> +ccflags-y += -Idrivers/media/dvb/dvb-core
> +ccflags-y += -Idrivers/media/dvb/frontends

they have invented vpath for this, did they ?
note: I am not familiar with the linux makefile.

re,
 wh

Re: [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192su/Makefile |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192su/Makefile b/drivers/staging/rtl8192su/Makefile
> index 7133894..1120c04 100644
> --- a/drivers/staging/rtl8192su/Makefile
> +++ b/drivers/staging/rtl8192su/Makefile
> @@ -1,12 +1,12 @@
>  NIC_SELECT = RTL8192SU
>  
> -EXTRA_CFLAGS += -std=gnu89
> -EXTRA_CFLAGS += -O2
> +ccflags-y := -std=gnu89
> +ccflags-y += -O2
>  


I still do not think that -O2 belongs here.
it should simply be removed.

re,
 wh



> -EXTRA_CFLAGS += -DJACKSON_NEW_RX
> -EXTRA_CFLAGS += -DTHOMAS_BEACON
> +ccflags-y += -DJACKSON_NEW_RX
> +ccflags-y += -DTHOMAS_BEACON
>  
> -#EXTRA_CFLAGS += -DMUTIPLE_BULK_OUT
> +#ccflags-y += -DMUTIPLE_BULK_OUT
>  
>  r8192s_usb-objs :=		\
>  	r8192U_wx.o		\

Re: [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile cflag lines

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192su/Makefile |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192su/Makefile b/drivers/staging/rtl8192su/Makefile
> index 7133894..1120c04 100644
> --- a/drivers/staging/rtl8192su/Makefile
> +++ b/drivers/staging/rtl8192su/Makefile
> @@ -1,12 +1,12 @@
>  NIC_SELECT = RTL8192SU
>  
> -EXTRA_CFLAGS += -std=gnu89
> -EXTRA_CFLAGS += -O2
> +ccflags-y := -std=gnu89
> +ccflags-y += -O2
>  


I still do not think that -O2 belongs here.
it should simply be removed.

re,
 wh



> -EXTRA_CFLAGS += -DJACKSON_NEW_RX
> -EXTRA_CFLAGS += -DTHOMAS_BEACON
> +ccflags-y += -DJACKSON_NEW_RX
> +ccflags-y += -DTHOMAS_BEACON
>  
> -#EXTRA_CFLAGS += -DMUTIPLE_BULK_OUT
> +#ccflags-y += -DMUTIPLE_BULK_OUT
>  
>  r8192s_usb-objs :=		\
>  	r8192U_wx.o		\

Re: [PATCH v3 09/20] Staging: rtl8187se: Makefile: cleaned up Makefile

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8187se/Makefile |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8187se/Makefile b/drivers/staging/rtl8187se/Makefile
> index e6adf91..adc3849 100644
> --- a/drivers/staging/rtl8187se/Makefile
> +++ b/drivers/staging/rtl8187se/Makefile
> @@ -4,17 +4,17 @@
>  #EXTRA_CFLAGS += -O2
>  #CC            = gcc
>  
> -EXTRA_CFLAGS += -DSW_ANTE
> -EXTRA_CFLAGS += -DTX_TRACK
> -EXTRA_CFLAGS += -DHIGH_POWER
> -EXTRA_CFLAGS += -DSW_DIG
> -EXTRA_CFLAGS += -DRATE_ADAPT
> +ccflags-y := -DSW_ANTE
> +ccflags-y += -DTX_TRACK
> +ccflags-y += -DHIGH_POWER
> +ccflags-y += -DSW_DIG
> +ccflags-y += -DRATE_ADAPT
>  
>  #enable it for legacy power save, disable it for leisure  power save
> -EXTRA_CFLAGS += -DENABLE_LPS
> +ccflags-y += -DENABLE_LPS
>  
>  
> -#EXTRA_CFLAGS += -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y
> +#ccflags-y := -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y
>  

so every time someone selects "my cpu does not have hard-float
they will try it again, and to make sure that it will cause max
confusion it sets CONFIG_FORCE_HARD_FLOAT to yes.

re,
 wh





>  r8187se-objs :=			\
>  		r8180_core.o		\

Re: [PATCH v3 09/20] Staging: rtl8187se: Makefile: cleaned up Makefile cflag lines

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8187se/Makefile |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8187se/Makefile b/drivers/staging/rtl8187se/Makefile
> index e6adf91..adc3849 100644
> --- a/drivers/staging/rtl8187se/Makefile
> +++ b/drivers/staging/rtl8187se/Makefile
> @@ -4,17 +4,17 @@
>  #EXTRA_CFLAGS += -O2
>  #CC            = gcc
>  
> -EXTRA_CFLAGS += -DSW_ANTE
> -EXTRA_CFLAGS += -DTX_TRACK
> -EXTRA_CFLAGS += -DHIGH_POWER
> -EXTRA_CFLAGS += -DSW_DIG
> -EXTRA_CFLAGS += -DRATE_ADAPT
> +ccflags-y := -DSW_ANTE
> +ccflags-y += -DTX_TRACK
> +ccflags-y += -DHIGH_POWER
> +ccflags-y += -DSW_DIG
> +ccflags-y += -DRATE_ADAPT
>  
>  #enable it for legacy power save, disable it for leisure  power save
> -EXTRA_CFLAGS += -DENABLE_LPS
> +ccflags-y += -DENABLE_LPS
>  
>  
> -#EXTRA_CFLAGS += -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y
> +#ccflags-y := -mhard-float -DCONFIG_FORCE_HARD_FLOAT=y
>  

so every time someone selects "my cpu does not have hard-float
they will try it again, and to make sure that it will cause max
confusion it sets CONFIG_FORCE_HARD_FLOAT to yes.

re,
 wh





>  r8187se-objs :=			\
>  		r8180_core.o		\

Re: [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192su/ieee80211/Makefile |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192su/ieee80211/Makefile b/drivers/staging/rtl8192su/ieee80211/Makefile
> index a500bfa..5bee643 100644
> --- a/drivers/staging/rtl8192su/ieee80211/Makefile
> +++ b/drivers/staging/rtl8192su/ieee80211/Makefile
> @@ -1,10 +1,10 @@
>  NIC_SELECT = RTL8192SU
>  
> -EXTRA_CFLAGS += -O2
> -EXTRA_CFLAGS += -DRTL8192S_DISABLE_FW_DM=0
> -EXTRA_CFLAGS += -DRTL8192SU
> -#EXTRA_CFLAGS += -DJOHN_NOCPY
> -EXTRA_CFLAGS += -DTHOMAS_TURBO
> +ccflags-y := -O2

optimisation should be configured in the main file.

re,
 wh

> +ccflags-y += -DRTL8192S_DISABLE_FW_DM=0
> +ccflags-y += -DRTL8192SU
> +#ccflags-y += -DJOHN_NOCPY
> +ccflags-y += -DTHOMAS_TURBO
>  
>  ieee80211-rsl-objs := ieee80211_rx.o \
>  		      ieee80211_softmac.o \

Re: [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192su/ieee80211/Makefile |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192su/ieee80211/Makefile b/drivers/staging/rtl8192su/ieee80211/Makefile
> index a500bfa..5bee643 100644
> --- a/drivers/staging/rtl8192su/ieee80211/Makefile
> +++ b/drivers/staging/rtl8192su/ieee80211/Makefile
> @@ -1,10 +1,10 @@
>  NIC_SELECT = RTL8192SU
>  
> -EXTRA_CFLAGS += -O2
> -EXTRA_CFLAGS += -DRTL8192S_DISABLE_FW_DM=0
> -EXTRA_CFLAGS += -DRTL8192SU
> -#EXTRA_CFLAGS += -DJOHN_NOCPY
> -EXTRA_CFLAGS += -DTHOMAS_TURBO
> +ccflags-y := -O2

optimisation should be configured in the main file.

re,
 wh

> +ccflags-y += -DRTL8192S_DISABLE_FW_DM=0
> +ccflags-y += -DRTL8192SU
> +#ccflags-y += -DJOHN_NOCPY
> +ccflags-y += -DTHOMAS_TURBO
>  
>  ieee80211-rsl-objs := ieee80211_rx.o \
>  		      ieee80211_softmac.o \

Re: [PATCH v3 13/20] Staging: rtl8192u: Makefile: cleaned up Makefile

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192u/Makefile |   20 ++++++++++----------
>  1 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/Makefile b/drivers/staging/rtl8192u/Makefile
> index 738f4a8..cba4344 100644
> --- a/drivers/staging/rtl8192u/Makefile
> +++ b/drivers/staging/rtl8192u/Makefile
> @@ -1,16 +1,16 @@
>  NIC_SELECT = RTL8192U
>  
> -EXTRA_CFLAGS += -std=gnu89
> -EXTRA_CFLAGS += -O2
> +ccflags-y := -std=gnu89
> +ccflags-y += -O2
>  

no optimisation please,

> -EXTRA_CFLAGS += -DCONFIG_FORCE_HARD_FLOAT=y

these CONFIG_FORCE_HARD_FLOAT again, why do they call it
config when they need it ?

re,
 wh



> -EXTRA_CFLAGS += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
> -EXTRA_CFLAGS += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO
> -#EXTRA_CFLAGS += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
> -#EXTRA_CFLAGS += -DUSB_RX_AGGREGATION_SUPPORT
> -EXTRA_CFLAGS += -DUSE_ONE_PIPE
> -EXTRA_CFLAGS += -DENABLE_DOT11D
> -EXTRA_CFLAGS += -Idrivers/staging/rtl8192u/ieee80211
> +ccflags-y += -DCONFIG_FORCE_HARD_FLOAT=y
> +ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
> +ccflags-y += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO
> +#ccflags-y += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
> +#ccflags-y += -DUSB_RX_AGGREGATION_SUPPORT
> +ccflags-y += -DUSE_ONE_PIPE
> +ccflags-y += -DENABLE_DOT11D
> +ccflags-y += -Idrivers/staging/rtl8192u/ieee80211
>  
>  r8192u_usb-objs := r8192U_core.o r8180_93cx6.o r8192U_wx.o		\
>  		  r8190_rtl8256.o r819xU_phy.o r819xU_firmware.o	\

Re: [PATCH v3 13/20] Staging: rtl8192u: Makefile: cleaned up Makefile cflag lines

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192u/Makefile |   20 ++++++++++----------
>  1 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/Makefile b/drivers/staging/rtl8192u/Makefile
> index 738f4a8..cba4344 100644
> --- a/drivers/staging/rtl8192u/Makefile
> +++ b/drivers/staging/rtl8192u/Makefile
> @@ -1,16 +1,16 @@
>  NIC_SELECT = RTL8192U
>  
> -EXTRA_CFLAGS += -std=gnu89
> -EXTRA_CFLAGS += -O2
> +ccflags-y := -std=gnu89
> +ccflags-y += -O2
>  

no optimisation please,

> -EXTRA_CFLAGS += -DCONFIG_FORCE_HARD_FLOAT=y

these CONFIG_FORCE_HARD_FLOAT again, why do they call it
config when they need it ?

re,
 wh



> -EXTRA_CFLAGS += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
> -EXTRA_CFLAGS += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO
> -#EXTRA_CFLAGS += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
> -#EXTRA_CFLAGS += -DUSB_RX_AGGREGATION_SUPPORT
> -EXTRA_CFLAGS += -DUSE_ONE_PIPE
> -EXTRA_CFLAGS += -DENABLE_DOT11D
> -EXTRA_CFLAGS += -Idrivers/staging/rtl8192u/ieee80211
> +ccflags-y += -DCONFIG_FORCE_HARD_FLOAT=y
> +ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
> +ccflags-y += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO
> +#ccflags-y += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
> +#ccflags-y += -DUSB_RX_AGGREGATION_SUPPORT
> +ccflags-y += -DUSE_ONE_PIPE
> +ccflags-y += -DENABLE_DOT11D
> +ccflags-y += -Idrivers/staging/rtl8192u/ieee80211
>  
>  r8192u_usb-objs := r8192U_core.o r8180_93cx6.o r8192U_wx.o		\
>  		  r8190_rtl8256.o r819xU_phy.o r819xU_firmware.o	\

Re: [PATCH v3 14/20] Staging: rtl8192u: ieee80211: Makefile: cleaned

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/Makefile |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/Makefile b/drivers/staging/rtl8192u/ieee80211/Makefile
> index 71ca5d9..45704f8 100644
> --- a/drivers/staging/rtl8192u/ieee80211/Makefile
> +++ b/drivers/staging/rtl8192u/ieee80211/Makefile
> @@ -5,22 +5,22 @@ MODDESTDIR := /lib/modules/$(KVER)/kernel/drivers/net/wireless/$(NIC_SELECT)
>  
>  CC = gcc

does this mean we can compile with gcc only ? where are the icc users ?

>  ifneq ($(shell uname -r|cut -d. -f1,2), 2.4)

I can guess what the author intended but this will only check *on*
what system i am compiling, not what linux version i try *to conpile*.
see: KERNEL_VERSION macro



> -EXTRA_CFLAGS += -I$(TOPDIR)/drivers/net/wireless
> -EXTRA_CFLAGS += -O2

no optimisation, please

> -EXTRA_CFLAGS += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
> +ccflags-y := -I$(TOPDIR)/drivers/net/wireless
> +ccflags-y += -O2
> +ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
>  
>  #it will fail to compile in suse linux enterprise 10 sp2. This flag is to solve this problem.
>  ifeq ($(shell uname -r | cut -d. -f1,2,3,4), 2.6.16.60-0)
> -EXTRA_CFLAGS += -DOPENSUSE_SLED
> +ccflags-y := -DOPENSUSE_SLED
>  endif

this should be something like .....

# if LINUX_VERSION_CODE = KERNEL_VERSION(2,6,16)
#define OPENSUSE_SLED
#endif

>  ifeq ($(NIC_SELECT),RTL8192U)
> -#EXTRA_CFLAGS += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
> -#EXTRA_CFLAGS += -DUSB_RX_AGGREGATION_SUPPORT
> +#ccflags-y := -DUSB_TX_DRIVER_AGGREGATION_ENABLE
> +#ccflags-y := -DUSB_RX_AGGREGATION_SUPPORT
>  endif
> -#EXTRA_CFLAGS += -DJOHN_NOCPY
> +#ccflags-y := -DJOHN_NOCPY
>  #flags to enable or disble 80211D feature
> -EXTRA_CFLAGS += -DENABLE_DOT11D
> +ccflags-y += -DENABLE_DOT11D
>  ieee80211-rsl-objs := ieee80211_rx.o \
>  		      ieee80211_softmac.o \
>  		      ieee80211_tx.o \


just my 2 cents,
 wh

Re: [PATCH v3 14/20] Staging: rtl8192u: ieee80211: Makefile: cleaned up Makefile cflag lines

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/Makefile |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/Makefile b/drivers/staging/rtl8192u/ieee80211/Makefile
> index 71ca5d9..45704f8 100644
> --- a/drivers/staging/rtl8192u/ieee80211/Makefile
> +++ b/drivers/staging/rtl8192u/ieee80211/Makefile
> @@ -5,22 +5,22 @@ MODDESTDIR := /lib/modules/$(KVER)/kernel/drivers/net/wireless/$(NIC_SELECT)
>  
>  CC = gcc

does this mean we can compile with gcc only ? where are the icc users ?

>  ifneq ($(shell uname -r|cut -d. -f1,2), 2.4)

I can guess what the author intended but this will only check *on*
what system i am compiling, not what linux version i try *to conpile*.
see: KERNEL_VERSION macro



> -EXTRA_CFLAGS += -I$(TOPDIR)/drivers/net/wireless
> -EXTRA_CFLAGS += -O2

no optimisation, please

> -EXTRA_CFLAGS += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
> +ccflags-y := -I$(TOPDIR)/drivers/net/wireless
> +ccflags-y += -O2
> +ccflags-y += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX
>  
>  #it will fail to compile in suse linux enterprise 10 sp2. This flag is to solve this problem.
>  ifeq ($(shell uname -r | cut -d. -f1,2,3,4), 2.6.16.60-0)
> -EXTRA_CFLAGS += -DOPENSUSE_SLED
> +ccflags-y := -DOPENSUSE_SLED
>  endif

this should be something like .....

# if LINUX_VERSION_CODE = KERNEL_VERSION(2,6,16)
#define OPENSUSE_SLED
#endif

>  ifeq ($(NIC_SELECT),RTL8192U)
> -#EXTRA_CFLAGS += -DUSB_TX_DRIVER_AGGREGATION_ENABLE
> -#EXTRA_CFLAGS += -DUSB_RX_AGGREGATION_SUPPORT
> +#ccflags-y := -DUSB_TX_DRIVER_AGGREGATION_ENABLE
> +#ccflags-y := -DUSB_RX_AGGREGATION_SUPPORT
>  endif
> -#EXTRA_CFLAGS += -DJOHN_NOCPY
> +#ccflags-y := -DJOHN_NOCPY
>  #flags to enable or disble 80211D feature
> -EXTRA_CFLAGS += -DENABLE_DOT11D
> +ccflags-y += -DENABLE_DOT11D
>  ieee80211-rsl-objs := ieee80211_rx.o \
>  		      ieee80211_softmac.o \
>  		      ieee80211_tx.o \


just my 2 cents,
 wh

Re: [PATCH v3 18/20] Staging: vt6656: Makefile: cleaned up Makefile

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/vt6656/Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile
> index 582a35197..41ed06b 100644
> --- a/drivers/staging/vt6656/Makefile
> +++ b/drivers/staging/vt6656/Makefile
> @@ -1,6 +1,6 @@
>  # TODO: all of these should be removed
> -EXTRA_CFLAGS += -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__
> -EXTRA_CFLAGS += -DHOSTAP
> +ccflags-y := -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__
> +ccflags-y += -DHOSTAP
>  
>  vt6656_stage-y +=	main_usb.o \
>  			card.o  \


I am wondering what will happen when we remove -DLINUX will it think we are _DOS_ ?
re,
 wh

Re: [PATCH v3 18/20] Staging: vt6656: Makefile: cleaned up Makefile cflag lines

[walter harms]

Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/vt6656/Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile
> index 582a35197..41ed06b 100644
> --- a/drivers/staging/vt6656/Makefile
> +++ b/drivers/staging/vt6656/Makefile
> @@ -1,6 +1,6 @@
>  # TODO: all of these should be removed
> -EXTRA_CFLAGS += -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__
> -EXTRA_CFLAGS += -DHOSTAP
> +ccflags-y := -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__
> +ccflags-y += -DHOSTAP
>  
>  vt6656_stage-y +=	main_usb.o \
>  			card.o  \


I am wondering what will happen when we remove -DLINUX will it think we are _DOS_ ?
re,
 wh

Re: [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up

[T Dent]

On 10/3/10, walter harms <wharms@bfs.de> wrote:
>
>
> Tracey Dent schrieb:
>> Changed to use the proper ccflags-y option
>>
>> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
>> ---
>>  drivers/staging/rtl8192su/Makefile |   10 +++++-----
>>  1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8192su/Makefile
>> b/drivers/staging/rtl8192su/Makefile
>> index 7133894..1120c04 100644
>> --- a/drivers/staging/rtl8192su/Makefile
>> +++ b/drivers/staging/rtl8192su/Makefile
>> @@ -1,12 +1,12 @@
>>  NIC_SELECT = RTL8192SU
>>
>> -EXTRA_CFLAGS += -std=gnu89
>> -EXTRA_CFLAGS += -O2
>> +ccflags-y := -std=gnu89
>> +ccflags-y += -O2
>>
>
>
> I still do not think that -O2 belongs here.
> it should simply be removed.

True it should, but all i did was change the EXTRA_CFLAGS to ccflags-y.

>
> re,
>  wh
>
>
>
>> -EXTRA_CFLAGS += -DJACKSON_NEW_RX
>> -EXTRA_CFLAGS += -DTHOMAS_BEACON
>> +ccflags-y += -DJACKSON_NEW_RX
>> +ccflags-y += -DTHOMAS_BEACON
>>
>> -#EXTRA_CFLAGS += -DMUTIPLE_BULK_OUT
>> +#ccflags-y += -DMUTIPLE_BULK_OUT
>>
>>  r8192s_usb-objs :=		\
>>  	r8192U_wx.o		\
>


            TD

Re: [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile cflag lines

[T Dent]

On 10/3/10, walter harms <wharms@bfs.de> wrote:
>
>
> Tracey Dent schrieb:
>> Changed to use the proper ccflags-y option
>>
>> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
>> ---
>>  drivers/staging/rtl8192su/Makefile |   10 +++++-----
>>  1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8192su/Makefile
>> b/drivers/staging/rtl8192su/Makefile
>> index 7133894..1120c04 100644
>> --- a/drivers/staging/rtl8192su/Makefile
>> +++ b/drivers/staging/rtl8192su/Makefile
>> @@ -1,12 +1,12 @@
>>  NIC_SELECT = RTL8192SU
>>
>> -EXTRA_CFLAGS += -std=gnu89
>> -EXTRA_CFLAGS += -O2
>> +ccflags-y := -std=gnu89
>> +ccflags-y += -O2
>>
>
>
> I still do not think that -O2 belongs here.
> it should simply be removed.

True it should, but all i did was change the EXTRA_CFLAGS to ccflags-y.

>
> re,
>  wh
>
>
>
>> -EXTRA_CFLAGS += -DJACKSON_NEW_RX
>> -EXTRA_CFLAGS += -DTHOMAS_BEACON
>> +ccflags-y += -DJACKSON_NEW_RX
>> +ccflags-y += -DTHOMAS_BEACON
>>
>> -#EXTRA_CFLAGS += -DMUTIPLE_BULK_OUT
>> +#ccflags-y += -DMUTIPLE_BULK_OUT
>>
>>  r8192s_usb-objs :=		\
>>  	r8192U_wx.o		\
>


            TD

Re: [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up

[Sam Ravnborg]

On Sun, Oct 03, 2010 at 02:40:01PM +0200, walter harms wrote:
> 
> 
> Tracey Dent schrieb:
> > Changed to use the proper ccflags-y option
> > 
> > Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> > ---
> >  drivers/staging/cx25821/Makefile |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/staging/cx25821/Makefile b/drivers/staging/cx25821/Makefile
> > index d0eb16e..6448364 100644
> > --- a/drivers/staging/cx25821/Makefile
> > +++ b/drivers/staging/cx25821/Makefile
> > @@ -7,7 +7,7 @@ cx25821-objs   := cx25821-core.o cx25821-cards.o cx25821-i2c.o \
> >  obj-$(CONFIG_VIDEO_CX25821) += cx25821.o
> >  obj-$(CONFIG_VIDEO_CX25821_ALSA) += cx25821-alsa.o
> >  
> > -EXTRA_CFLAGS += -Idrivers/media/video
> > -EXTRA_CFLAGS += -Idrivers/media/common/tuners
> > -EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
> > -EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
> > +ccflags-y := -Idrivers/media/video
> > +ccflags-y += -Idrivers/media/common/tuners
> > +ccflags-y += -Idrivers/media/dvb/dvb-core
> > +ccflags-y += -Idrivers/media/dvb/frontends
> 
> they have invented vpath for this, did they ?
> note: I am not familiar with the linux makefile.
vpath is not the answer here.

Note that Tracy dent did the simple replacement of EXTRA_CFLAGS with ccflags-y.
The Makefiles could in many cases benefit from general cleanups - which many
of your futher comments is a good indicator of.

	Sam

Re: [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines

[Sam Ravnborg]

On Sun, Oct 03, 2010 at 02:40:01PM +0200, walter harms wrote:
> 
> 
> Tracey Dent schrieb:
> > Changed to use the proper ccflags-y option
> > 
> > Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> > ---
> >  drivers/staging/cx25821/Makefile |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/staging/cx25821/Makefile b/drivers/staging/cx25821/Makefile
> > index d0eb16e..6448364 100644
> > --- a/drivers/staging/cx25821/Makefile
> > +++ b/drivers/staging/cx25821/Makefile
> > @@ -7,7 +7,7 @@ cx25821-objs   := cx25821-core.o cx25821-cards.o cx25821-i2c.o \
> >  obj-$(CONFIG_VIDEO_CX25821) += cx25821.o
> >  obj-$(CONFIG_VIDEO_CX25821_ALSA) += cx25821-alsa.o
> >  
> > -EXTRA_CFLAGS += -Idrivers/media/video
> > -EXTRA_CFLAGS += -Idrivers/media/common/tuners
> > -EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
> > -EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
> > +ccflags-y := -Idrivers/media/video
> > +ccflags-y += -Idrivers/media/common/tuners
> > +ccflags-y += -Idrivers/media/dvb/dvb-core
> > +ccflags-y += -Idrivers/media/dvb/frontends
> 
> they have invented vpath for this, did they ?
> note: I am not familiar with the linux makefile.
vpath is not the answer here.

Note that Tracy dent did the simple replacement of EXTRA_CFLAGS with ccflags-y.
The Makefiles could in many cases benefit from general cleanups - which many
of your futher comments is a good indicator of.

	Sam

Re: [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up

[matt mooney]

On 22:51 Sun 03 Oct     , Sam Ravnborg wrote:
> On Sun, Oct 03, 2010 at 02:40:01PM +0200, walter harms wrote:
> > 
> > 
> > Tracey Dent schrieb:
> > > Changed to use the proper ccflags-y option
> > > 
> > > Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> > > ---
> > >  drivers/staging/cx25821/Makefile |    8 ++++----
> > >  1 files changed, 4 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/staging/cx25821/Makefile b/drivers/staging/cx25821/Makefile
> > > index d0eb16e..6448364 100644
> > > --- a/drivers/staging/cx25821/Makefile
> > > +++ b/drivers/staging/cx25821/Makefile
> > > @@ -7,7 +7,7 @@ cx25821-objs   := cx25821-core.o cx25821-cards.o cx25821-i2c.o \
> > >  obj-$(CONFIG_VIDEO_CX25821) += cx25821.o
> > >  obj-$(CONFIG_VIDEO_CX25821_ALSA) += cx25821-alsa.o
> > >  
> > > -EXTRA_CFLAGS += -Idrivers/media/video
> > > -EXTRA_CFLAGS += -Idrivers/media/common/tuners
> > > -EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
> > > -EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
> > > +ccflags-y := -Idrivers/media/video
> > > +ccflags-y += -Idrivers/media/common/tuners
> > > +ccflags-y += -Idrivers/media/dvb/dvb-core
> > > +ccflags-y += -Idrivers/media/dvb/frontends
> > 
> > they have invented vpath for this, did they ?
> > note: I am not familiar with the linux makefile.
> vpath is not the answer here.
> 
> Note that Tracy dent did the simple replacement of EXTRA_CFLAGS with ccflags-y.
> The Makefiles could in many cases benefit from general cleanups - which many
> of your futher comments is a good indicator of.

Hi Sam,

I happen to have sent out a RFC patch for media/ a little over a week ago.
Mauro Chehab has not commented on it yet, but I am curious to hear your
opinion.

http://marc.info/?l=linux-kernel&m\x128553496013767&w=2

Thanks,
mfm

Re: [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines

[matt mooney]

On 22:51 Sun 03 Oct     , Sam Ravnborg wrote:
> On Sun, Oct 03, 2010 at 02:40:01PM +0200, walter harms wrote:
> > 
> > 
> > Tracey Dent schrieb:
> > > Changed to use the proper ccflags-y option
> > > 
> > > Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> > > ---
> > >  drivers/staging/cx25821/Makefile |    8 ++++----
> > >  1 files changed, 4 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/staging/cx25821/Makefile b/drivers/staging/cx25821/Makefile
> > > index d0eb16e..6448364 100644
> > > --- a/drivers/staging/cx25821/Makefile
> > > +++ b/drivers/staging/cx25821/Makefile
> > > @@ -7,7 +7,7 @@ cx25821-objs   := cx25821-core.o cx25821-cards.o cx25821-i2c.o \
> > >  obj-$(CONFIG_VIDEO_CX25821) += cx25821.o
> > >  obj-$(CONFIG_VIDEO_CX25821_ALSA) += cx25821-alsa.o
> > >  
> > > -EXTRA_CFLAGS += -Idrivers/media/video
> > > -EXTRA_CFLAGS += -Idrivers/media/common/tuners
> > > -EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
> > > -EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
> > > +ccflags-y := -Idrivers/media/video
> > > +ccflags-y += -Idrivers/media/common/tuners
> > > +ccflags-y += -Idrivers/media/dvb/dvb-core
> > > +ccflags-y += -Idrivers/media/dvb/frontends
> > 
> > they have invented vpath for this, did they ?
> > note: I am not familiar with the linux makefile.
> vpath is not the answer here.
> 
> Note that Tracy dent did the simple replacement of EXTRA_CFLAGS with ccflags-y.
> The Makefiles could in many cases benefit from general cleanups - which many
> of your futher comments is a good indicator of.

Hi Sam,

I happen to have sent out a RFC patch for media/ a little over a week ago.
Mauro Chehab has not commented on it yet, but I am curious to hear your
opinion.

http://marc.info/?l=linux-kernel&m=128553496013767&w=2

Thanks,
mfm

Re: [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile:

[Greg KH]

On Sat, Oct 02, 2010 at 12:38:01PM -0400, Tracey Dent wrote:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192su/ieee80211/Makefile |   10 +++++-----

This file is no longer in linux-next.

thanks,

greg k-h

Re: [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines

[Greg KH]

On Sat, Oct 02, 2010 at 12:38:01PM -0400, Tracey Dent wrote:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192su/ieee80211/Makefile |   10 +++++-----

This file is no longer in linux-next.

thanks,

greg k-h

Re: [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up

[Greg KH]

On Sat, Oct 02, 2010 at 12:38:00PM -0400, Tracey Dent wrote:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192su/Makefile |   10 +++++-----

This file is no longer in linux-next.

thanks,

greg k-h

Re: [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile cflag lines

[Greg KH]

On Sat, Oct 02, 2010 at 12:38:00PM -0400, Tracey Dent wrote:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192su/Makefile |   10 +++++-----

This file is no longer in linux-next.

thanks,

greg k-h

Re: [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned

[T Dent]

On 10/5/10, Greg KH <greg@kroah.com> wrote:
> On Sat, Oct 02, 2010 at 12:38:01PM -0400, Tracey Dent wrote:
>> Changed to use the proper ccflags-y option
>>
>> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
>> ---
>>  drivers/staging/rtl8192su/ieee80211/Makefile |   10 +++++-----
>
> This file is no longer in linux-next.

I Didn't know that. I guess because I did the patches based on the
current linus tree.
So you want me to resend it without this driver?
>
> thanks,
>
> greg k-h
>

Thanks,

Tracey D

Re: [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines

[T Dent]

On 10/5/10, Greg KH <greg@kroah.com> wrote:
> On Sat, Oct 02, 2010 at 12:38:01PM -0400, Tracey Dent wrote:
>> Changed to use the proper ccflags-y option
>>
>> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
>> ---
>>  drivers/staging/rtl8192su/ieee80211/Makefile |   10 +++++-----
>
> This file is no longer in linux-next.

I Didn't know that. I guess because I did the patches based on the
current linus tree.
So you want me to resend it without this driver?
>
> thanks,
>
> greg k-h
>

Thanks,

Tracey D

Re: [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned

[T Dent]

On 10/5/10, T Dent <tdent48227@gmail.com> wrote:
> On 10/5/10, Greg KH <greg@kroah.com> wrote:
>> On Sat, Oct 02, 2010 at 12:38:01PM -0400, Tracey Dent wrote:
>>> Changed to use the proper ccflags-y option
>>>
>>> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
>>> ---
>>>  drivers/staging/rtl8192su/ieee80211/Makefile |   10 +++++-----
>>
>> This file is no longer in linux-next.
>
> I Didn't know that. I guess because I did the patches based on the
> current linus tree.
> So you want me to resend it without this driver?

Never mind, I just seen the message you sent me. Got a lot of messages
and must have skip over it , Sorry.
>>
>> thanks,
>>
>> greg k-h
>>
>
> Thanks,
>
> Tracey D
>

Thanks,

Tracey D

Re: [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines

[T Dent]

On 10/5/10, T Dent <tdent48227@gmail.com> wrote:
> On 10/5/10, Greg KH <greg@kroah.com> wrote:
>> On Sat, Oct 02, 2010 at 12:38:01PM -0400, Tracey Dent wrote:
>>> Changed to use the proper ccflags-y option
>>>
>>> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
>>> ---
>>>  drivers/staging/rtl8192su/ieee80211/Makefile |   10 +++++-----
>>
>> This file is no longer in linux-next.
>
> I Didn't know that. I guess because I did the patches based on the
> current linus tree.
> So you want me to resend it without this driver?

Never mind, I just seen the message you sent me. Got a lot of messages
and must have skip over it , Sorry.
>>
>> thanks,
>>
>> greg k-h
>>
>
> Thanks,
>
> Tracey D
>

Thanks,

Tracey D

Re: [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile:

[Greg KH]

On Tue, Oct 05, 2010 at 05:47:23PM -0400, T Dent wrote:
> On 10/5/10, Greg KH <greg@kroah.com> wrote:
> > On Sat, Oct 02, 2010 at 12:38:01PM -0400, Tracey Dent wrote:
> >> Changed to use the proper ccflags-y option
> >>
> >> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> >> ---
> >>  drivers/staging/rtl8192su/ieee80211/Makefile |   10 +++++-----
> >
> > This file is no longer in linux-next.
> 
> I Didn't know that. I guess because I did the patches based on the
> current linus tree.

You should always send patches against the linux-next tree, as it
contains the accumulated patches that will be sent to Linus next time
around.

> So you want me to resend it without this driver?

Nope, I got your other ones.

thanks,

greg k-h

Re: [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines

[Greg KH]

On Tue, Oct 05, 2010 at 05:47:23PM -0400, T Dent wrote:
> On 10/5/10, Greg KH <greg@kroah.com> wrote:
> > On Sat, Oct 02, 2010 at 12:38:01PM -0400, Tracey Dent wrote:
> >> Changed to use the proper ccflags-y option
> >>
> >> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> >> ---
> >>  drivers/staging/rtl8192su/ieee80211/Makefile |   10 +++++-----
> >
> > This file is no longer in linux-next.
> 
> I Didn't know that. I guess because I did the patches based on the
> current linus tree.

You should always send patches against the linux-next tree, as it
contains the accumulated patches that will be sent to Linus next time
around.

> So you want me to resend it without this driver?

Nope, I got your other ones.

thanks,

greg k-h