From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: -global option parsing
Date: Tue, 05 Oct 2010 13:18:32 +0200 [thread overview]
Message-ID: <4CAB0988.60501@redhat.com> (raw)
In-Reply-To: <20101005105943.GA17394@redhat.com>
On 10/05/10 12:59, Michael S. Tsirkin wrote:
> -global virtio_net_pci.hahah=0
>
> seems to be run, with an invalid option being
> silently ignored. Is this intentional?
It is a invalid driver which is ignored ...
Invalid options *are* catched (try "virtio-net-pci.foo=42").
> I think failing with an error would be better ...
Indeed. I think this needs a separate verification pass; IIRC the list
of drivers (and busses, remember PCI.prop=something works too) doesn't
exist yet at command line option parsing time.
cheers,
Gerd
prev parent reply other threads:[~2010-10-05 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 10:59 [Qemu-devel] -global option parsing Michael S. Tsirkin
2010-10-05 11:18 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAB0988.60501@redhat.com \
--to=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.