* [Qemu-devel] -global option parsing
@ 2010-10-05 10:59 Michael S. Tsirkin
2010-10-05 11:18 ` [Qemu-devel] " Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2010-10-05 10:59 UTC (permalink / raw)
To: qemu-devel, kraxel
-global virtio_net_pci.hahah=0
seems to be run, with an invalid option being
silently ignored. Is this intentional?
I think failing with an error would be better ...
--
MST
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: -global option parsing
2010-10-05 10:59 [Qemu-devel] -global option parsing Michael S. Tsirkin
@ 2010-10-05 11:18 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2010-10-05 11:18 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel
On 10/05/10 12:59, Michael S. Tsirkin wrote:
> -global virtio_net_pci.hahah=0
>
> seems to be run, with an invalid option being
> silently ignored. Is this intentional?
It is a invalid driver which is ignored ...
Invalid options *are* catched (try "virtio-net-pci.foo=42").
> I think failing with an error would be better ...
Indeed. I think this needs a separate verification pass; IIRC the list
of drivers (and busses, remember PCI.prop=something works too) doesn't
exist yet at command line option parsing time.
cheers,
Gerd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-05 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-05 10:59 [Qemu-devel] -global option parsing Michael S. Tsirkin
2010-10-05 11:18 ` [Qemu-devel] " Gerd Hoffmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.