All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 05/11] Delete write only variables
Date: Thu, 07 Oct 2010 09:27:44 +0200	[thread overview]
Message-ID: <4CAD7670.10808@redhat.com> (raw)
In-Reply-To: <AANLkTingc+SFvEk0TEY8kej27RmrmQU7eweui4Qmb2XQ@mail.gmail.com>

On 10/06/2010 11:32 PM, Blue Swirl wrote:
> @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env)
>           env->gpr[3] = 0;
>           break;
>       case 39: /* video_ctrl */
> -        if (env->gpr[6] == 0 || env->gpr[6] == 1)
> -            vga_vbl_enabled = env->gpr[6];
>           env->gpr[3] = 0;
>           break;
>       case 47:

NACK, this smells like an incomplete emulation.

Paolo

  reply	other threads:[~2010-10-07  7:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06 21:32 [Qemu-devel] [PATCH 05/11] Delete write only variables Blue Swirl
2010-10-07  7:27 ` Paolo Bonzini [this message]
2010-10-07 17:24   ` [Qemu-devel] " Blue Swirl
2010-10-08 17:28     ` Paolo Bonzini
2010-10-08 17:30       ` Alexander Graf
2010-10-08 18:06         ` Blue Swirl
2010-10-08 18:09           ` Alexander Graf
2010-10-09 14:27           ` Andreas Färber
2010-10-09 14:31             ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CAD7670.10808@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.