[Qemu-devel] Re: [PATCH 05/11] Delete write only variables

[Paolo Bonzini <pbonzini@redhat.com>]

On 10/07/2010 07:24 PM, Blue Swirl wrote:
>> >  On 10/06/2010 11:32 PM, Blue Swirl wrote:
>>> >>
>>> >>  @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env)
>>> >>            env->gpr[3] = 0;
>>> >>            break;
>>> >>        case 39: /* video_ctrl */
>>> >>  -        if (env->gpr[6] == 0 || env->gpr[6] == 1)
>>> >>  -            vga_vbl_enabled = env->gpr[6];
>>> >>            env->gpr[3] = 0;
>>> >>            break;
>>> >>        case 47:
>> >
>> >  NACK, this smells like an incomplete emulation.
> Why would we care about unfinished temporary Mac-on-Linux hack for
> video.x? Perhaps the correct fix is to remove vga_osi_call function
> and env->osi_call field entirely.

CCing the person who could answer.

Paolo