All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] lvconvert: provide useful error when snapshot-merge target missing
Date: Wed, 13 Oct 2010 21:06:53 +0200	[thread overview]
Message-ID: <4CB6034D.5080603@redhat.com> (raw)
In-Reply-To: <20101013185302.GA2944@redhat.com>

On 10/13/2010 08:53 PM, Mike Snitzer wrote:
> Convey need for snapshot-merge target in lvconvert error message and man
> page.

> --- a/lib/metadata/segtype.h
> +++ b/lib/metadata/segtype.h
> @@ -66,6 +66,7 @@ struct segment_type {
>  
>  struct segtype_handler {
>  	const char *(*name) (const struct lv_segment * seg);
> +	const char *(*target_name) (const struct lv_segment * seg);
>  	void (*display) (const struct lv_segment * seg);
>  	int (*text_export) (const struct lv_segment * seg,
>  			    struct formatter * f);

I think this will break shared (external) segment module ABI.
Nobody uses that but worth to mention it.
(See e.g. lib/mirror and --with-mirrors=shared)

Otherwise ack.

Milan



  reply	other threads:[~2010-10-13 19:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-13 18:53 [PATCH] lvconvert: provide useful error when snapshot-merge target missing Mike Snitzer
2010-10-13 19:06 ` Milan Broz [this message]
2010-10-13 19:55   ` Mike Snitzer
2010-10-13 20:20     ` Milan Broz
2010-10-13 21:42   ` [PATCH] " Alasdair G Kergon
2010-10-14  9:04     ` Zdenek Kabelac
2010-10-14 11:24       ` Alasdair G Kergon
2010-10-14 12:45         ` Zdenek Kabelac
2010-10-14 12:53       ` Mike Snitzer
2010-10-14 12:57         ` Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB6034D.5080603@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.