From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] lvconvert: provide useful error when snapshot-merge target missing
Date: Thu, 14 Oct 2010 14:45:36 +0200 [thread overview]
Message-ID: <4CB6FB70.8030501@redhat.com> (raw)
In-Reply-To: <20101014112426.GD32395@agk-dp.fab.redhat.com>
Dne 14.10.2010 13:24, Alasdair G Kergon napsal(a):
> On Thu, Oct 14, 2010 at 11:04:02AM +0200, Zdenek Kabelac wrote:
>> I'd propose to drop/turn off this feature completely - targets usually cannot
>> work without heavy tweaking through the rest of the code anyway. So in fact we
>> rather 'pretend' there is such functionality.
>
> The reason for the shared libraries is so that a distro can ship support
> for older formats like LVM1 or pool but people who know they don't need
> it don't have to have it loaded it all the time.
>
Those object files take like 30KB and we are memory locking a lot of MB of
various glibc and other libs wasteful code...
The main problem I can see is - that things like support of snapshot are not
concentrated in one little object file - but in a lot of other places. So we
do not have clean enough border for this API.
And in effect we would actually consume quite few KB more in case those libs
would be used dynamically and while we extend lvm library with user API - we
actually waste probably far more space - which is not commonly needed.
Zdenek
next prev parent reply other threads:[~2010-10-14 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 18:53 [PATCH] lvconvert: provide useful error when snapshot-merge target missing Mike Snitzer
2010-10-13 19:06 ` Milan Broz
2010-10-13 19:55 ` Mike Snitzer
2010-10-13 20:20 ` Milan Broz
2010-10-13 21:42 ` [PATCH] " Alasdair G Kergon
2010-10-14 9:04 ` Zdenek Kabelac
2010-10-14 11:24 ` Alasdair G Kergon
2010-10-14 12:45 ` Zdenek Kabelac [this message]
2010-10-14 12:53 ` Mike Snitzer
2010-10-14 12:57 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB6FB70.8030501@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.