From: Mike Snitzer <snitzer@redhat.com>
To: lvm-devel@redhat.com
Subject: lvconvert: provide useful error when snapshot-merge target missing
Date: Thu, 14 Oct 2010 08:53:49 -0400 [thread overview]
Message-ID: <20101014125349.GA8079@redhat.com> (raw)
In-Reply-To: <4CB6C782.6020501@redhat.com>
On Thu, Oct 14 2010 at 5:04am -0400,
Zdenek Kabelac <zkabelac@redhat.com> wrote:
> Dne 13.10.2010 23:42, Alasdair G Kergon napsal(a):
> > On Wed, Oct 13, 2010 at 09:06:53PM +0200, Milan Broz wrote:
> >> I think this will break shared (external) segment module ABI.
> >
> > Indeed - we make no guarantees for that ABI and don't even bother
> > versioning it. We don't believe there are any out-of-tree users.
> >
>
> I'd propose to drop/turn off this feature completely - targets usually cannot
> work without heavy tweaking through the rest of the code anyway. So in fact we
> rather 'pretend' there is such functionality.
I'm not following what you're saying. There is no pretending here...
The feature fails gracefully with an informative error message.
What's the problem?
Mike
next prev parent reply other threads:[~2010-10-14 12:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 18:53 [PATCH] lvconvert: provide useful error when snapshot-merge target missing Mike Snitzer
2010-10-13 19:06 ` Milan Broz
2010-10-13 19:55 ` Mike Snitzer
2010-10-13 20:20 ` Milan Broz
2010-10-13 21:42 ` [PATCH] " Alasdair G Kergon
2010-10-14 9:04 ` Zdenek Kabelac
2010-10-14 11:24 ` Alasdair G Kergon
2010-10-14 12:45 ` Zdenek Kabelac
2010-10-14 12:53 ` Mike Snitzer [this message]
2010-10-14 12:57 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101014125349.GA8079@redhat.com \
--to=snitzer@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.