* [PATCH v2.6.36-rc7] isdn/eicon: don't call flush_scheduled_work() from diva_os_remove_soft_isr()
@ 2010-10-15 12:57 Tejun Heo
2010-10-16 12:42 ` Armin Schindler
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2010-10-15 12:57 UTC (permalink / raw)
To: Karsten Keil, Armin Schindler, lkml, Andrew Morton
diva doesn't use workqueue and there is no reason to flush the system
workqueue from diva_os_remove_soft_isr(). Remove it.
This is to prepare for the deprecation and removal of
flush_scheduled_work().
Signed-off-by: Tejun Heo <tj@kernel.org>
---
drivers/isdn/hardware/eicon/divasmain.c | 2 --
1 file changed, 2 deletions(-)
Index: work/drivers/isdn/hardware/eicon/divasmain.c
===================================================================
--- work.orig/drivers/isdn/hardware/eicon/divasmain.c
+++ work/drivers/isdn/hardware/eicon/divasmain.c
@@ -15,7 +15,6 @@
#include <asm/uaccess.h>
#include <asm/io.h>
#include <linux/ioport.h>
-#include <linux/workqueue.h>
#include <linux/pci.h>
#include <linux/interrupt.h>
#include <linux/list.h>
@@ -546,7 +545,6 @@ void diva_os_remove_soft_isr(diva_os_sof
void *mem;
tasklet_kill(&pdpc->divas_task);
- flush_scheduled_work();
mem = psoft_isr->object;
psoft_isr->object = NULL;
diva_os_free(0, mem);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2.6.36-rc7] isdn/eicon: don't call flush_scheduled_work() from diva_os_remove_soft_isr()
2010-10-15 12:57 [PATCH v2.6.36-rc7] isdn/eicon: don't call flush_scheduled_work() from diva_os_remove_soft_isr() Tejun Heo
@ 2010-10-16 12:42 ` Armin Schindler
2010-10-16 13:11 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Armin Schindler @ 2010-10-16 12:42 UTC (permalink / raw)
To: Tejun Heo; +Cc: Karsten Keil, lkml, Andrew Morton
On Fri, 15 Oct 2010, Tejun Heo wrote:
> diva doesn't use workqueue and there is no reason to flush the system
> workqueue from diva_os_remove_soft_isr(). Remove it.
>
> This is to prepare for the deprecation and removal of
> flush_scheduled_work().
This is a leftover. Thanks.
Acked-by: Armin Schindler <armin@melware.de>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> drivers/isdn/hardware/eicon/divasmain.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: work/drivers/isdn/hardware/eicon/divasmain.c
> ===================================================================
> --- work.orig/drivers/isdn/hardware/eicon/divasmain.c
> +++ work/drivers/isdn/hardware/eicon/divasmain.c
> @@ -15,7 +15,6 @@
> #include <asm/uaccess.h>
> #include <asm/io.h>
> #include <linux/ioport.h>
> -#include <linux/workqueue.h>
> #include <linux/pci.h>
> #include <linux/interrupt.h>
> #include <linux/list.h>
> @@ -546,7 +545,6 @@ void diva_os_remove_soft_isr(diva_os_sof
> void *mem;
>
> tasklet_kill(&pdpc->divas_task);
> - flush_scheduled_work();
> mem = psoft_isr->object;
> psoft_isr->object = NULL;
> diva_os_free(0, mem);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2.6.36-rc7] isdn/eicon: don't call flush_scheduled_work() from diva_os_remove_soft_isr()
2010-10-16 12:42 ` Armin Schindler
@ 2010-10-16 13:11 ` Tejun Heo
2010-10-16 22:32 ` Armin Schindler
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2010-10-16 13:11 UTC (permalink / raw)
To: Armin Schindler; +Cc: Karsten Keil, lkml, Andrew Morton
Hello,
On 10/16/2010 02:42 PM, Armin Schindler wrote:
> On Fri, 15 Oct 2010, Tejun Heo wrote:
>> diva doesn't use workqueue and there is no reason to flush the system
>> workqueue from diva_os_remove_soft_isr(). Remove it.
>>
>> This is to prepare for the deprecation and removal of
>> flush_scheduled_work().
>
> This is a leftover. Thanks.
>
> Acked-by: Armin Schindler <armin@melware.de>
Thank you. Are you gonna route this patch or shall I push it through
wq tree?
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2.6.36-rc7] isdn/eicon: don't call flush_scheduled_work() from diva_os_remove_soft_isr()
2010-10-16 13:11 ` Tejun Heo
@ 2010-10-16 22:32 ` Armin Schindler
2010-10-17 9:26 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Armin Schindler @ 2010-10-16 22:32 UTC (permalink / raw)
To: Tejun Heo; +Cc: Karsten Keil, lkml, Andrew Morton
On Sat, 16 Oct 2010, Tejun Heo wrote:
> Hello,
>
> On 10/16/2010 02:42 PM, Armin Schindler wrote:
>> On Fri, 15 Oct 2010, Tejun Heo wrote:
>>> diva doesn't use workqueue and there is no reason to flush the system
>>> workqueue from diva_os_remove_soft_isr(). Remove it.
>>>
>>> This is to prepare for the deprecation and removal of
>>> flush_scheduled_work().
>>
>> This is a leftover. Thanks.
>>
>> Acked-by: Armin Schindler <armin@melware.de>
>
> Thank you. Are you gonna route this patch or shall I push it through
> wq tree?
It's your patch ;-)
Armin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-10-17 9:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-15 12:57 [PATCH v2.6.36-rc7] isdn/eicon: don't call flush_scheduled_work() from diva_os_remove_soft_isr() Tejun Heo
2010-10-16 12:42 ` Armin Schindler
2010-10-16 13:11 ` Tejun Heo
2010-10-16 22:32 ` Armin Schindler
2010-10-17 9:26 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.