[PULL] at: Non root install patch is not necessary (Bug 246)

[PULL] at: Non root install patch is not necessary (Bug 246)

[Mei, Lei]

meta/recipes-extended/at/at_3.1.12.bb               |    1
 meta/recipes-extended/at/files/nonrootinstall.patch |   75 --------------------
 2 files changed, 76 deletions(-)

Mei Lei (1):
      at: Non root install patch is not necessary (Bug 246) Pull URL: 

http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro

commit 22a1491482bdd0b8fe1bac3f89a2b4dad0a94a8c
Author: Mei Lei <lei.mei@intel.com>
Date:   Tue Oct 19 14:23:51 2010 +0800

   at: Non root install patch is not necessary (Bug 246)

   Removed nonrootinstall patch and modified the file which used this patch

   Fix [BUGID #246]

   Signed-off-by: Mei Lei <lei.mei@intel.com>



---
Mei, Lei
Email: lei.mei@intel.com

Re: [PULL] at: Non root install patch is not necessary (Bug 246)

[Richard Purdie]

On Tue, 2010-10-19 at 17:07 +0800, Mei, Lei wrote:
> meta/recipes-extended/at/at_3.1.12.bb               |    1
>  meta/recipes-extended/at/files/nonrootinstall.patch |   75 --------------------
>  2 files changed, 76 deletions(-)
> 
> Mei Lei (1):
>       at: Non root install patch is not necessary (Bug 246) Pull URL: 
> 
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro
> 
> commit 22a1491482bdd0b8fe1bac3f89a2b4dad0a94a8c
> Author: Mei Lei <lei.mei@intel.com>
> Date:   Tue Oct 19 14:23:51 2010 +0800
> 
>    at: Non root install patch is not necessary (Bug 246)
> 
>    Removed nonrootinstall patch and modified the file which used this patch
> 
>    Fix [BUGID #246]
> 
>    Signed-off-by: Mei Lei <lei.mei@intel.com>

This change illustrates a problem we need to be very careful to watch
for when doing this. The patch you've removed not only handles root
install but also handles stripping of the binaries.

Note this bit:

-+ifeq ($(IROOT),)
- chown $(DAEMON_USERNAME):$(DAEMON_GROUPNAME) $(IROOT)$(LFILE)
-- test -f $(IROOT)$(etcdir)/at.allow || test -f $(IROOT)$(etcdir)/at.deny || $(INSTALL) -o root -g $(DAEMON_GROUPNAME) -m 640 at.deny $(IROOT)$(etcdir)/
-- $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 6755 -s at $(IROOT)$(bindir)
-+endif
-+ test -f $(IROOT)$(etcdir)/at.allow || test -f $(IROOT)$(etcdir)/at.deny || $(INSTALL) $(INSTALLOWN) -m 600 at.deny $(IROOT)$(etcdir)/
-+ $(INSTALL) $(INSTALLOWN) -m 4755 at $(IROOT)$(bindir)

The -s option is removed from the install command.

Whilst we can remove the user ownership part of the patch, the -s option
needs to remain present as we expect unstripped binaries to be
installed.

Regards,

Richard

Re: [PULL] at: Non root install patch is not necessary (Bug 246)

[Mei, Lei]

Hi Richard,
   I have re-fixed this bug, please check it, thank you~

 meta/recipes-extended/at/at_3.1.12.bb                 |    2 
 meta/recipes-extended/at/files/nonrootinstall.patch   |   75 ------------------
 meta/recipes-extended/at/files/nonstripbinaries.patch |   21 +++++
 3 files changed, 22 insertions(+), 76 deletions(-)

Mei Lei (1):
      at: remove nonrootinstall patch and modify relevant files

Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro

commit 4cc54ea87c5167af0da207e5cea856d16e2b88f6
Author: Mei Lei <lei.mei@intel.com>
Date:   Wed Oct 20 16:20:36 2010 +0800

    at: remove nonrootinstall patch and modify relevant files
    
    remove nonrootinstall patch, and use a patch named nonstripbinaries to modify the /at-3.1.10.2/Makefile.in, so it can also handles stripping of the binaries.
    
    Fix [BUGID #246]
    
    Signed-off-by: Mei Lei <lei.mei@intel.com>



Thanks
Lei 

-----Original Message-----
From: Richard Purdie [mailto:rpurdie@linux.intel.com] 
Sent: Tuesday, October 19, 2010 8:03 PM
To: Mei, Lei
Cc: yocto@yoctoproject.org
Subject: Re: [yocto] [PULL] at: Non root install patch is not necessary (Bug 246)

On Tue, 2010-10-19 at 17:07 +0800, Mei, Lei wrote:
> meta/recipes-extended/at/at_3.1.12.bb               |    1
>  meta/recipes-extended/at/files/nonrootinstall.patch |   75 --------------------
>  2 files changed, 76 deletions(-)
> 
> Mei Lei (1):
>       at: Non root install patch is not necessary (Bug 246) Pull URL: 
> 
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro
> 
> commit 22a1491482bdd0b8fe1bac3f89a2b4dad0a94a8c
> Author: Mei Lei <lei.mei@intel.com>
> Date:   Tue Oct 19 14:23:51 2010 +0800
> 
>    at: Non root install patch is not necessary (Bug 246)
> 
>    Removed nonrootinstall patch and modified the file which used this patch
> 
>    Fix [BUGID #246]
> 
>    Signed-off-by: Mei Lei <lei.mei@intel.com>

This change illustrates a problem we need to be very careful to watch
for when doing this. The patch you've removed not only handles root
install but also handles stripping of the binaries.

Note this bit:

-+ifeq ($(IROOT),)
- chown $(DAEMON_USERNAME):$(DAEMON_GROUPNAME) $(IROOT)$(LFILE)
-- test -f $(IROOT)$(etcdir)/at.allow || test -f $(IROOT)$(etcdir)/at.deny || $(INSTALL) -o root -g $(DAEMON_GROUPNAME) -m 640 at.deny $(IROOT)$(etcdir)/
-- $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 6755 -s at $(IROOT)$(bindir)
-+endif
-+ test -f $(IROOT)$(etcdir)/at.allow || test -f $(IROOT)$(etcdir)/at.deny || $(INSTALL) $(INSTALLOWN) -m 600 at.deny $(IROOT)$(etcdir)/
-+ $(INSTALL) $(INSTALLOWN) -m 4755 at $(IROOT)$(bindir)

The -s option is removed from the install command.

Whilst we can remove the user ownership part of the patch, the -s option
needs to remain present as we expect unstripped binaries to be
installed.

Regards,

Richard

Re: [PULL] at: Non root install patch is not necessary (Bug 246)

[Richard Purdie]

On Wed, 2010-10-20 at 17:05 +0800, Mei, Lei wrote:
> Hi Richard,
>    I have re-fixed this bug, please check it, thank you~
> 
>  meta/recipes-extended/at/at_3.1.12.bb                 |    2 
>  meta/recipes-extended/at/files/nonrootinstall.patch   |   75 ------------------
>  meta/recipes-extended/at/files/nonstripbinaries.patch |   21 +++++
>  3 files changed, 22 insertions(+), 76 deletions(-)
> 
> Mei Lei (1):
>       at: remove nonrootinstall patch and modify relevant files

Thanks, much better. One more small thing though - could you add a
header to the patch with a description of what it does, why and who made
the change. In this case its fairly obvious but its a good idea in
general as when you come back to a patch six months later you can
remember why its there!

Also, poky pull requests like this should be going to the Poky mailing
list.

Cheers,

Richard

Re: [PULL] at: Non root install patch is not necessary (Bug 246)

[Mei, Lei]

Hi Richard,
    I have added the description to the nonstripbinaries.patch, please check it, thank you~

 meta/recipes-extended/at/at_3.1.12.bb                 |    2 
 meta/recipes-extended/at/files/nonrootinstall.patch   |   75 ------------------
 meta/recipes-extended/at/files/nonstripbinaries.patch |   25 ++++++
 3 files changed, 26 insertions(+), 76 deletions(-)

Mei Lei (1):
      at: remove nonrootinstall patch and modify some relevant files

Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro

commit 3c695d5d210227c5744fa90736feb7c308c6bf15
Author: Mei Lei <lei.mei@intel.com>
Date:   Thu Oct 21 12:36:51 2010 +0800

    at: remove nonrootinstall patch and modify some relevant files
    
    remove nonrootinstall patch, and use a patch named nonstripbinaries to modify the /at-3.1.10.2/Makefile.in, so it can also handles stripping of the binaries
    
    Fix [BUG 246]
    
    Signed-off-by: Mei Lei <lei.mei@intel.com>

Thanks
Lei

-----Original Message-----
From: Richard Purdie [mailto:rpurdie@linux.intel.com] 
Sent: Wednesday, October 20, 2010 5:25 PM
To: Mei, Lei
Subject: RE: [PULL] at: Non root install patch is not necessary (Bug 246)

On Wed, 2010-10-20 at 17:05 +0800, Mei, Lei wrote:
> Hi Richard,
>    I have re-fixed this bug, please check it, thank you~
> 
>  meta/recipes-extended/at/at_3.1.12.bb                 |    2 
>  meta/recipes-extended/at/files/nonrootinstall.patch   |   75 ------------------
>  meta/recipes-extended/at/files/nonstripbinaries.patch |   21 +++++
>  3 files changed, 22 insertions(+), 76 deletions(-)
> 
> Mei Lei (1):
>       at: remove nonrootinstall patch and modify relevant files

Thanks, much better. One more small thing though - could you add a
header to the patch with a description of what it does, why and who made
the change. In this case its fairly obvious but its a good idea in
general as when you come back to a patch six months later you can
remember why its there!

Also, poky pull requests like this should be going to the Poky mailing
list.

Cheers,

Richard

Re: [PULL] at: Non root install patch is not necessary (Bug 246)

[Richard Purdie]

On Thu, 2010-10-21 at 13:17 +0800, Mei, Lei wrote:
> Hi Richard,
>     I have added the description to the nonstripbinaries.patch, please check it, thank you~
> 
>  meta/recipes-extended/at/at_3.1.12.bb                 |    2 
>  meta/recipes-extended/at/files/nonrootinstall.patch   |   75 ------------------
>  meta/recipes-extended/at/files/nonstripbinaries.patch |   25 ++++++
>  3 files changed, 26 insertions(+), 76 deletions(-)
> 
> Mei Lei (1):
>       at: remove nonrootinstall patch and modify some relevant files
> 
> Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro

Merged to master, thanks.

As a note for future, no # to comment lines is needed in a patch header.

Cheers,

Richard

[PULL] Fix at -- was Re: [PULL] at: Non root install patch is not necessary (Bug246)

[Mark Hatle]

This commit introduced a bug, the following fixes the issue:

Pull request follows....

The following changes since commit f1a209b142d2319d2594b051c01d9997184bfcb4:

   busybox/sysklogd: syslog.conf files (2010-10-21 14:05:57 +0100)

are available in the git repository at:
   git://git.pokylinux.org/poky-contrib.git mhatle/at

Mark Hatle (1):
       at: Fix nonstripbinaries.patch

  .../at/files/nonstripbinaries.patch                |    6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)


On 10/21/10 7:51 AM, Richard Purdie wrote:
> On Thu, 2010-10-21 at 13:17 +0800, Mei, Lei wrote:
>> Hi Richard,
>>      I have added the description to the nonstripbinaries.patch, please check it, thank you~
>>
>>   meta/recipes-extended/at/at_3.1.12.bb                 |    2
>>   meta/recipes-extended/at/files/nonrootinstall.patch   |   75 ------------------
>>   meta/recipes-extended/at/files/nonstripbinaries.patch |   25 ++++++
>>   3 files changed, 26 insertions(+), 76 deletions(-)
>>
>> Mei Lei (1):
>>        at: remove nonrootinstall patch and modify some relevant files
>>
>> Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro
>
> Merged to master, thanks.
>
> As a note for future, no # to comment lines is needed in a patch header.
>
> Cheers,
>
> Richard
>
> _______________________________________________
> poky mailing list
> poky@pokylinux.org
> https://lists.pokylinux.org/listinfo/poky

Re: [PULL] Fix at -- was Re: [PULL] at: Non root install patch is not necessary (Bug246)

[Richard Purdie]

On Thu, 2010-10-21 at 12:27 -0500, Mark Hatle wrote:
> This commit introduced a bug, the following fixes the issue:
> 
> Pull request follows....
> 
> The following changes since commit f1a209b142d2319d2594b051c01d9997184bfcb4:
> 
>    busybox/sysklogd: syslog.conf files (2010-10-21 14:05:57 +0100)
> 
> are available in the git repository at:
>    git://git.pokylinux.org/poky-contrib.git mhatle/at
> 
> Mark Hatle (1):
>        at: Fix nonstripbinaries.patch
> 
>   .../at/files/nonstripbinaries.patch                |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)

Merged into master, thanks.

Richard