From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Daein Moon <moon9124@samsung.com>,
ben-linux@fluff.org
Subject: Re: [PATCH] ARM: SAMSUNG: Add the missed s3c_gpio_getpull() API
Date: Thu, 21 Oct 2010 21:47:46 +0400 [thread overview]
Message-ID: <4CC07CC2.50206@mvista.com> (raw)
In-Reply-To: <1287648286-7202-1-git-send-email-kgene.kim@samsung.com>
Hello.
On 21-10-2010 12:04, Kukjin Kim wrote:
> From: Daein Moon<moon9124@samsung.com>
> This patch adds the s3c_gpio_getpull() API that has been missed in the
> plat-samsung/gpio-config.c and actullay there is its extern declaration
> in plat/gpio-cfg.h.
> Signed-off-by: Daein Moon<moon9124@samsung.com>
> Cc: Ben Dooks<ben-linux@fluff.org>
> Signed-off-by: Kukjin Kim<kgene.kim@samsung.com>
> ---
> NOTE:
> - already issued about this
> arch/arm/plat-samsung/gpio-config.c | 19 +++++++++++++++++++
> .../plat-samsung/include/plat/gpio-cfg-helpers.h | 6 ++++++
> 2 files changed, 25 insertions(+), 0 deletions(-)
> diff --git a/arch/arm/plat-samsung/gpio-config.c b/arch/arm/plat-samsung/gpio-config.c
> index 8a37211..b732b77 100644
> --- a/arch/arm/plat-samsung/gpio-config.c
> +++ b/arch/arm/plat-samsung/gpio-config.c
[...]
> diff --git a/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h b/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> index 3e21c75..c417f85 100644
> --- a/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> +++ b/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> @@ -42,6 +42,12 @@ static inline int s3c_gpio_do_setpull(struct s3c_gpio_chip *chip,
> return (chip->config->set_pull)(chip, off, pull);
> }
>
> +static inline unsigned s3c_gpio_do_getpull(struct s3c_gpio_chip *chip,
> + unsigned int off)
> +{
> + return (chip->config->get_pull)(chip, off);
Parens are not necessary here.
> +}
> +
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: SAMSUNG: Add the missed s3c_gpio_getpull() API
Date: Thu, 21 Oct 2010 21:47:46 +0400 [thread overview]
Message-ID: <4CC07CC2.50206@mvista.com> (raw)
In-Reply-To: <1287648286-7202-1-git-send-email-kgene.kim@samsung.com>
Hello.
On 21-10-2010 12:04, Kukjin Kim wrote:
> From: Daein Moon<moon9124@samsung.com>
> This patch adds the s3c_gpio_getpull() API that has been missed in the
> plat-samsung/gpio-config.c and actullay there is its extern declaration
> in plat/gpio-cfg.h.
> Signed-off-by: Daein Moon<moon9124@samsung.com>
> Cc: Ben Dooks<ben-linux@fluff.org>
> Signed-off-by: Kukjin Kim<kgene.kim@samsung.com>
> ---
> NOTE:
> - already issued about this
> arch/arm/plat-samsung/gpio-config.c | 19 +++++++++++++++++++
> .../plat-samsung/include/plat/gpio-cfg-helpers.h | 6 ++++++
> 2 files changed, 25 insertions(+), 0 deletions(-)
> diff --git a/arch/arm/plat-samsung/gpio-config.c b/arch/arm/plat-samsung/gpio-config.c
> index 8a37211..b732b77 100644
> --- a/arch/arm/plat-samsung/gpio-config.c
> +++ b/arch/arm/plat-samsung/gpio-config.c
[...]
> diff --git a/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h b/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> index 3e21c75..c417f85 100644
> --- a/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> +++ b/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> @@ -42,6 +42,12 @@ static inline int s3c_gpio_do_setpull(struct s3c_gpio_chip *chip,
> return (chip->config->set_pull)(chip, off, pull);
> }
>
> +static inline unsigned s3c_gpio_do_getpull(struct s3c_gpio_chip *chip,
> + unsigned int off)
> +{
> + return (chip->config->get_pull)(chip, off);
Parens are not necessary here.
> +}
> +
WBR, Sergei
next prev parent reply other threads:[~2010-10-21 19:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 8:04 [PATCH] ARM: SAMSUNG: Add the missed s3c_gpio_getpull() API Kukjin Kim
2010-10-21 8:04 ` Kukjin Kim
2010-10-21 17:47 ` Sergei Shtylyov [this message]
2010-10-21 17:47 ` Sergei Shtylyov
2010-10-22 8:05 ` Kukjin Kim
2010-10-22 8:05 ` Kukjin Kim
2010-10-21 22:17 ` Ben Dooks
2010-10-21 22:17 ` Ben Dooks
2010-10-22 5:22 ` Kukjin Kim
2010-10-22 5:22 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC07CC2.50206@mvista.com \
--to=sshtylyov@mvista.com \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=moon9124@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.