Re: [PATCH] ARM: SAMSUNG: Add the missed s3c_gpio_getpull() API

[Ben Dooks <ben-linux@fluff.org>]

On 21/10/10 09:04, Kukjin Kim wrote:
> From: Daein Moon <moon9124@samsung.com>
> 
> This patch adds the s3c_gpio_getpull() API that has been missed in the
> plat-samsung/gpio-config.c and actullay there is its extern declaration
> in plat/gpio-cfg.h.
> 
> Signed-off-by: Daein Moon <moon9124@samsung.com>
> Cc: Ben Dooks <ben-linux@fluff.org>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> NOTE:
> - already issued about this
> 
>  arch/arm/plat-samsung/gpio-config.c                |   19 +++++++++++++++++++
>  .../plat-samsung/include/plat/gpio-cfg-helpers.h   |    6 ++++++
>  2 files changed, 25 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/gpio-config.c b/arch/arm/plat-samsung/gpio-config.c
> index 8a37211..b732b77 100644
> --- a/arch/arm/plat-samsung/gpio-config.c
> +++ b/arch/arm/plat-samsung/gpio-config.c
> @@ -111,6 +111,25 @@ int s3c_gpio_setpull(unsigned int pin, s3c_gpio_pull_t pull)
>  }
>  EXPORT_SYMBOL(s3c_gpio_setpull);
>  
> +s3c_gpio_pull_t s3c_gpio_getpull(unsigned int pin)
> +{
> +	struct s3c_gpio_chip *chip = s3c_gpiolib_getchip(pin);
> +	unsigned long flags;
> +	int offset;
> +	u32 pup = 0;

would the result of s3c_gpio_do_getpull() should be a s3c_gpio_pull_t?

> +	if (chip) {
> +		offset = pin - chip->chip.base;
> +
> +		s3c_gpio_lock(chip, flags);
> +		pup = s3c_gpio_do_getpull(chip, offset);
> +		s3c_gpio_unlock(chip, flags);
> +	}
> +
> +	return (__force s3c_gpio_pull_t)pup;
> +}
> +EXPORT_SYMBOL(s3c_gpio_getpull);