From: Jeff Garzik <jgarzik@pobox.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Nicolas Kaiser <nikai@nikai.net>,
Antonino Daplas <adaplas@gmail.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rivafb: dubious assignment
Date: Fri, 22 Oct 2010 17:18:52 +0000 [thread overview]
Message-ID: <4CC1C77C.1000700@pobox.com> (raw)
In-Reply-To: <AANLkTimAb_gjx7m6pKvYHL=SjB9DousdUJA2K9uyPt1F@mail.gmail.com>
On 10/22/2010 10:47 AM, Geert Uytterhoeven wrote:
> On Fri, Oct 22, 2010 at 13:31, Nicolas Kaiser<nikai@nikai.net> wrote:
>> A duplicated assignment unconditionally changes max_gfsize to
>> GFIFO_SIZE.
>>
>> It looks to me like this might not be intended, or is it?
>>
>> Signed-off-by: Nicolas Kaiser<nikai@nikai.net>
>> ---
>> drivers/video/riva/riva_hw.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
>> index 78fdbf5..936abfa 100644
>> --- a/drivers/video/riva/riva_hw.c
>> +++ b/drivers/video/riva/riva_hw.c
>> @@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
>> vmisses = 2;
>> if (ainfo->gburst_size = 128) max_gfsize = GFIFO_SIZE_128;
>> else max_gfsize = GFIFO_SIZE;
>> - max_gfsize = GFIFO_SIZE;
>> while (1)
>> {
>> if (ainfo->vid_en)
>> --
>> 1.7.2.2
>
> According to full-history-linux, this comes from the initial drop in 2.3.49pre2,
> from nVidia code(?), imported by Jeff Garzik.
Yep, came straight from X.org driver code... Patch certainly looks
correct, but who knows but NV for sure :)
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Nicolas Kaiser <nikai@nikai.net>,
Antonino Daplas <adaplas@gmail.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rivafb: dubious assignment
Date: Fri, 22 Oct 2010 13:18:52 -0400 [thread overview]
Message-ID: <4CC1C77C.1000700@pobox.com> (raw)
In-Reply-To: <AANLkTimAb_gjx7m6pKvYHL=SjB9DousdUJA2K9uyPt1F@mail.gmail.com>
On 10/22/2010 10:47 AM, Geert Uytterhoeven wrote:
> On Fri, Oct 22, 2010 at 13:31, Nicolas Kaiser<nikai@nikai.net> wrote:
>> A duplicated assignment unconditionally changes max_gfsize to
>> GFIFO_SIZE.
>>
>> It looks to me like this might not be intended, or is it?
>>
>> Signed-off-by: Nicolas Kaiser<nikai@nikai.net>
>> ---
>> drivers/video/riva/riva_hw.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
>> index 78fdbf5..936abfa 100644
>> --- a/drivers/video/riva/riva_hw.c
>> +++ b/drivers/video/riva/riva_hw.c
>> @@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
>> vmisses = 2;
>> if (ainfo->gburst_size == 128) max_gfsize = GFIFO_SIZE_128;
>> else max_gfsize = GFIFO_SIZE;
>> - max_gfsize = GFIFO_SIZE;
>> while (1)
>> {
>> if (ainfo->vid_en)
>> --
>> 1.7.2.2
>
> According to full-history-linux, this comes from the initial drop in 2.3.49pre2,
> from nVidia code(?), imported by Jeff Garzik.
Yep, came straight from X.org driver code... Patch certainly looks
correct, but who knows but NV for sure :)
next prev parent reply other threads:[~2010-10-22 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 11:31 [PATCH] rivafb: dubious assignment Nicolas Kaiser
2010-10-22 11:31 ` Nicolas Kaiser
2010-10-22 14:47 ` Geert Uytterhoeven
2010-10-22 14:47 ` Geert Uytterhoeven
2010-10-22 17:18 ` Jeff Garzik [this message]
2010-10-22 17:18 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC1C77C.1000700@pobox.com \
--to=jgarzik@pobox.com \
--cc=adaplas@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikai@nikai.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.