* [PATCH] rivafb: dubious assignment
@ 2010-10-22 11:31 ` Nicolas Kaiser
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Kaiser @ 2010-10-22 11:31 UTC (permalink / raw)
To: Antonino Daplas; +Cc: linux-fbdev, linux-kernel
A duplicated assignment unconditionally changes max_gfsize to
GFIFO_SIZE.
It looks to me like this might not be intended, or is it?
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/video/riva/riva_hw.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
index 78fdbf5..936abfa 100644
--- a/drivers/video/riva/riva_hw.c
+++ b/drivers/video/riva/riva_hw.c
@@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
vmisses = 2;
if (ainfo->gburst_size = 128) max_gfsize = GFIFO_SIZE_128;
else max_gfsize = GFIFO_SIZE;
- max_gfsize = GFIFO_SIZE;
while (1)
{
if (ainfo->vid_en)
--
1.7.2.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] rivafb: dubious assignment
@ 2010-10-22 11:31 ` Nicolas Kaiser
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Kaiser @ 2010-10-22 11:31 UTC (permalink / raw)
To: Antonino Daplas; +Cc: linux-fbdev, linux-kernel
A duplicated assignment unconditionally changes max_gfsize to
GFIFO_SIZE.
It looks to me like this might not be intended, or is it?
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/video/riva/riva_hw.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
index 78fdbf5..936abfa 100644
--- a/drivers/video/riva/riva_hw.c
+++ b/drivers/video/riva/riva_hw.c
@@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
vmisses = 2;
if (ainfo->gburst_size == 128) max_gfsize = GFIFO_SIZE_128;
else max_gfsize = GFIFO_SIZE;
- max_gfsize = GFIFO_SIZE;
while (1)
{
if (ainfo->vid_en)
--
1.7.2.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] rivafb: dubious assignment
2010-10-22 11:31 ` Nicolas Kaiser
@ 2010-10-22 14:47 ` Geert Uytterhoeven
-1 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2010-10-22 14:47 UTC (permalink / raw)
To: Nicolas Kaiser, Jeff Garzik; +Cc: Antonino Daplas, linux-fbdev, linux-kernel
On Fri, Oct 22, 2010 at 13:31, Nicolas Kaiser <nikai@nikai.net> wrote:
> A duplicated assignment unconditionally changes max_gfsize to
> GFIFO_SIZE.
>
> It looks to me like this might not be intended, or is it?
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> ---
> drivers/video/riva/riva_hw.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
> index 78fdbf5..936abfa 100644
> --- a/drivers/video/riva/riva_hw.c
> +++ b/drivers/video/riva/riva_hw.c
> @@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
> vmisses = 2;
> if (ainfo->gburst_size = 128) max_gfsize = GFIFO_SIZE_128;
> else max_gfsize = GFIFO_SIZE;
> - max_gfsize = GFIFO_SIZE;
> while (1)
> {
> if (ainfo->vid_en)
> --
> 1.7.2.2
According to full-history-linux, this comes from the initial drop in 2.3.49pre2,
from nVidia code(?), imported by Jeff Garzik.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rivafb: dubious assignment
@ 2010-10-22 14:47 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2010-10-22 14:47 UTC (permalink / raw)
To: Nicolas Kaiser, Jeff Garzik; +Cc: Antonino Daplas, linux-fbdev, linux-kernel
On Fri, Oct 22, 2010 at 13:31, Nicolas Kaiser <nikai@nikai.net> wrote:
> A duplicated assignment unconditionally changes max_gfsize to
> GFIFO_SIZE.
>
> It looks to me like this might not be intended, or is it?
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> ---
> drivers/video/riva/riva_hw.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
> index 78fdbf5..936abfa 100644
> --- a/drivers/video/riva/riva_hw.c
> +++ b/drivers/video/riva/riva_hw.c
> @@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
> vmisses = 2;
> if (ainfo->gburst_size == 128) max_gfsize = GFIFO_SIZE_128;
> else max_gfsize = GFIFO_SIZE;
> - max_gfsize = GFIFO_SIZE;
> while (1)
> {
> if (ainfo->vid_en)
> --
> 1.7.2.2
According to full-history-linux, this comes from the initial drop in 2.3.49pre2,
from nVidia code(?), imported by Jeff Garzik.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rivafb: dubious assignment
2010-10-22 14:47 ` Geert Uytterhoeven
@ 2010-10-22 17:18 ` Jeff Garzik
-1 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2010-10-22 17:18 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Nicolas Kaiser, Antonino Daplas, linux-fbdev, linux-kernel
On 10/22/2010 10:47 AM, Geert Uytterhoeven wrote:
> On Fri, Oct 22, 2010 at 13:31, Nicolas Kaiser<nikai@nikai.net> wrote:
>> A duplicated assignment unconditionally changes max_gfsize to
>> GFIFO_SIZE.
>>
>> It looks to me like this might not be intended, or is it?
>>
>> Signed-off-by: Nicolas Kaiser<nikai@nikai.net>
>> ---
>> drivers/video/riva/riva_hw.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
>> index 78fdbf5..936abfa 100644
>> --- a/drivers/video/riva/riva_hw.c
>> +++ b/drivers/video/riva/riva_hw.c
>> @@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
>> vmisses = 2;
>> if (ainfo->gburst_size = 128) max_gfsize = GFIFO_SIZE_128;
>> else max_gfsize = GFIFO_SIZE;
>> - max_gfsize = GFIFO_SIZE;
>> while (1)
>> {
>> if (ainfo->vid_en)
>> --
>> 1.7.2.2
>
> According to full-history-linux, this comes from the initial drop in 2.3.49pre2,
> from nVidia code(?), imported by Jeff Garzik.
Yep, came straight from X.org driver code... Patch certainly looks
correct, but who knows but NV for sure :)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rivafb: dubious assignment
@ 2010-10-22 17:18 ` Jeff Garzik
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2010-10-22 17:18 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Nicolas Kaiser, Antonino Daplas, linux-fbdev, linux-kernel
On 10/22/2010 10:47 AM, Geert Uytterhoeven wrote:
> On Fri, Oct 22, 2010 at 13:31, Nicolas Kaiser<nikai@nikai.net> wrote:
>> A duplicated assignment unconditionally changes max_gfsize to
>> GFIFO_SIZE.
>>
>> It looks to me like this might not be intended, or is it?
>>
>> Signed-off-by: Nicolas Kaiser<nikai@nikai.net>
>> ---
>> drivers/video/riva/riva_hw.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
>> index 78fdbf5..936abfa 100644
>> --- a/drivers/video/riva/riva_hw.c
>> +++ b/drivers/video/riva/riva_hw.c
>> @@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
>> vmisses = 2;
>> if (ainfo->gburst_size == 128) max_gfsize = GFIFO_SIZE_128;
>> else max_gfsize = GFIFO_SIZE;
>> - max_gfsize = GFIFO_SIZE;
>> while (1)
>> {
>> if (ainfo->vid_en)
>> --
>> 1.7.2.2
>
> According to full-history-linux, this comes from the initial drop in 2.3.49pre2,
> from nVidia code(?), imported by Jeff Garzik.
Yep, came straight from X.org driver code... Patch certainly looks
correct, but who knows but NV for sure :)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-22 17:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-22 11:31 [PATCH] rivafb: dubious assignment Nicolas Kaiser
2010-10-22 11:31 ` Nicolas Kaiser
2010-10-22 14:47 ` Geert Uytterhoeven
2010-10-22 14:47 ` Geert Uytterhoeven
2010-10-22 17:18 ` Jeff Garzik
2010-10-22 17:18 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.