All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	b43-dev@lists.infradead.org
Subject: [PATCH] b43: rfkill: use status register based on core revision not (PHY's)
Date: Fri, 22 Oct 2010 17:31:31 -0500	[thread overview]
Message-ID: <4CC210C3.7010602@lwfinger.net> (raw)
In-Reply-To: <AANLkTika4wVhH=rGc=qgZozgbe9j-+-zzPkb1KGWLHJC@mail.gmail.com>

On 10/22/2010 04:57 PM, Rafa? Mi?ecki wrote:
> W dniu 22 pa?dziernika 2010 23:38 u?ytkownik Larry Finger
> <Larry.Finger@lwfinger.net> napisa?:
>> On 10/22/2010 03:24 PM, Rafa? Mi?ecki wrote:
>>
>> As that register is present only when the core revision >= 3, this change should
>> not cause a regression. Perhaps this was an error in the RE from the start and
>> testing the phy.rev has always been wrong.
> 
> Do not blame RE team ;) It was described correctly since "ever", you
> can check it in history of:
> http://bcm-specs.sipsolutions.net/MMIO
> 
> I actually suspect this may be source of self-switching-on-off-radio
> issue described in:
> "b43legacy-phy3: Radio hardware status changed to XXX" thread.
> 
> I already mailed reporter to ask if he still has access to problematic card.

I have two cards that use b43legacy, but their physical format (PCI and Cardbus)
do not include an RFKILL switch, thus I have never tested this code with b43legacy.

Larry

WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	b43-dev@lists.infradead.org
Subject: Re: [PATCH] b43: rfkill: use status register based on core revision not (PHY's)
Date: Fri, 22 Oct 2010 17:31:31 -0500	[thread overview]
Message-ID: <4CC210C3.7010602@lwfinger.net> (raw)
In-Reply-To: <AANLkTika4wVhH=rGc=qgZozgbe9j-+-zzPkb1KGWLHJC@mail.gmail.com>

On 10/22/2010 04:57 PM, Rafał Miłecki wrote:
> W dniu 22 października 2010 23:38 użytkownik Larry Finger
> <Larry.Finger@lwfinger.net> napisał:
>> On 10/22/2010 03:24 PM, Rafał Miłecki wrote:
>>
>> As that register is present only when the core revision >= 3, this change should
>> not cause a regression. Perhaps this was an error in the RE from the start and
>> testing the phy.rev has always been wrong.
> 
> Do not blame RE team ;) It was described correctly since "ever", you
> can check it in history of:
> http://bcm-specs.sipsolutions.net/MMIO
> 
> I actually suspect this may be source of self-switching-on-off-radio
> issue described in:
> "b43legacy-phy3: Radio hardware status changed to XXX" thread.
> 
> I already mailed reporter to ask if he still has access to problematic card.

I have two cards that use b43legacy, but their physical format (PCI and Cardbus)
do not include an RFKILL switch, thus I have never tested this code with b43legacy.

Larry




  reply	other threads:[~2010-10-22 22:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-22 20:24 [PATCH] b43: rfkill: use status register based on core revision not (PHY's) Rafał Miłecki
2010-10-22 20:24 ` Rafał Miłecki
2010-10-22 20:25 ` Rafał Miłecki
2010-10-22 20:25   ` Rafał Miłecki
2010-10-22 21:38 ` Larry Finger
2010-10-22 21:38   ` Larry Finger
2010-10-22 21:57   ` Rafał Miłecki
2010-10-22 21:57     ` Rafał Miłecki
2010-10-22 22:31     ` Larry Finger [this message]
2010-10-22 22:31       ` Larry Finger
2010-10-25 12:39 ` Larry Finger
2010-10-25 12:39   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC210C3.7010602@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.