[PATCH] xl: fix ballooning

[PATCH] xl: fix ballooning

[Andre Przywara]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

Hi,

we should only check the value of new_target_memkb _after_ it has
been properly setup. This fixes ballooning Dom0, which
was broken since 22200:49a3c1721734.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12

[-- Attachment #2: fix_xl_ballooning.patch --]
[-- Type: text/x-patch, Size: 877 bytes --]

diff -r cd193fa265b8 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c	Tue Oct 26 12:22:52 2010 +0100
+++ b/tools/libxl/libxl.c	Wed Oct 27 13:47:05 2010 +0200
@@ -2927,6 +2927,11 @@
         abort = 1;
         goto out;
     }
+    if (relative)
+        new_target_memkb = current_target_memkb + target_memkb;
+    else
+        new_target_memkb = target_memkb;
+
     if (!domid && new_target_memkb < LIBXL_MIN_DOM0_MEM) {
         LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
                 "new target for dom0 is below the minimum threshold\n");
@@ -2934,10 +2939,6 @@
         goto out;
     }
 
-    if (relative)
-        new_target_memkb = current_target_memkb + target_memkb;
-    else
-        new_target_memkb = target_memkb;
     if (new_target_memkb > memorykb) {
         LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
                 "memory_dynamic_max must be less than or equal to"

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] xl: fix ballooning

[Gianni Tedesco]

On Wed, 2010-10-27 at 14:46 +0100, Andre Przywara wrote:
> Hi,
> 
> we should only check the value of new_target_memkb _after_ it has
> been properly setup. This fixes ballooning Dom0, which
> was broken since 22200:49a3c1721734.
> 
> Signed-off-by: Andre Przywara <andre.przywara@amd.com>

Again? I thought my fix for this was already applied?! :P

Gianni

Re: [PATCH] xl: fix ballooning

[Andre Przywara]

Gianni Tedesco wrote:
> On Wed, 2010-10-27 at 14:46 +0100, Andre Przywara wrote:
>> Hi,
>>
>> we should only check the value of new_target_memkb _after_ it has
>> been properly setup. This fixes ballooning Dom0, which
>> was broken since 22200:49a3c1721734.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@amd.com>
> 
> Again? I thought my fix for this was already applied?! :P
I didn't find one. I used the latest staging tip and the problem was 
still there. Is there a separate xl repository or branch I should know of?

Andre.

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12

Re: [PATCH] xl: fix ballooning

[Ian Jackson]

Andre Przywara writes ("Re: [Xen-devel] [PATCH] xl: fix ballooning"):
> Gianni Tedesco wrote:
> > Again? I thought my fix for this was already applied?! :P
>
> I didn't find one. I used the latest staging tip and the problem was 
> still there. Is there a separate xl repository or branch I should know of?

I've been holding off putting more tools patches into xen-unstable
staging because I wanted to see Ian C's hypercall buffers series pass
the tests first.  That's worked so I'll apply the backlog patches
today.

Ian.