All of lore.kernel.org
 help / color / mirror / Atom feed
From: "\"潘卫平(Peter Pan)\"" <wppan@redflag-linux.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] ext4:memset is needless in ext4_ext_remove_space()
Date: Mon, 08 Nov 2010 09:19:47 +0800	[thread overview]
Message-ID: <4CD75033.7080902@redflag-linux.com> (raw)


memset is needless because path is allocated by kzalloc.

Signed-off-by: Peter Pan(潘卫平) <wppan@redflag-linux.com>
---
  fs/ext4/extents.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 0554c48..37cdb6e 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2375,7 +2375,6 @@ again:
  			/* go to the next level */
  			ext_debug("move to level %d (block %llu)\n",
  				  i + 1, ext4_idx_pblock(path[i].p_idx));
-			memset(path + i + 1, 0, sizeof(*path));
  			bh = sb_bread(sb, ext4_idx_pblock(path[i].p_idx));
  			if (!bh) {
  				/* should we reset i_size? */
-- 
1.6.6


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "\"潘卫平(Peter Pan)\"" <wppan@redflag-linux.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] ext4:memset is needless in ext4_ext_remove_space()
Date: Mon, 08 Nov 2010 09:19:47 +0800	[thread overview]
Message-ID: <4CD75033.7080902@redflag-linux.com> (raw)


memset is needless because path is allocated by kzalloc.

Signed-off-by: Peter Pan(潘卫平) <wppan@redflag-linux.com>
---
  fs/ext4/extents.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 0554c48..37cdb6e 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2375,7 +2375,6 @@ again:
  			/* go to the next level */
  			ext_debug("move to level %d (block %llu)\n",
  				  i + 1, ext4_idx_pblock(path[i].p_idx));
-			memset(path + i + 1, 0, sizeof(*path));
  			bh = sb_bread(sb, ext4_idx_pblock(path[i].p_idx));
  			if (!bh) {
  				/* should we reset i_size? */
-- 
1.6.6



             reply	other threads:[~2010-11-08  1:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-08  1:19 "潘卫平(Peter Pan)" [this message]
2010-11-08  1:19 ` [PATCH] ext4:memset is needless in ext4_ext_remove_space() "潘卫平(Peter Pan)"
2010-11-08  4:37 ` Dan Carpenter
2010-11-08  4:37   ` Dan Carpenter
2010-11-08  6:24   ` 
2010-11-08  6:24     ` "Peter Pan(潘卫平)"
2010-11-08  6:24     ` "Peter Pan(潘卫平)"

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD75033.7080902@redflag-linux.com \
    --to=wppan@redflag-linux.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.