To: "Dan Carpenter" <error27@gmail.com>,
"\"潘卫平(Peter Pan)\"" <wppan@redflag-linux.com>,
tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kerne
Subject: Re: [PATCH] ext4:memset is needless in ext4_ext_remove_space()
Date: Mon, 08 Nov 2010 06:24:06 +0000 [thread overview]
Message-ID: <4CD79786.9000303@gmail.com> (raw)
In-Reply-To: <20101108043752.GB5563@bicker>
On 2010年11月08日 12:37, Dan Carpenter wrote:
> This is inside a loop and sometimes we do i++ and sometimes i--. Are
> you absolutely positive that path + i isn't initialized?
>
> I haven't followed this code through all the way but my instinct is
> that the memset is there for a reason.
>
I know that I misunderstood it.
Thank you!
Regards
Peter Pan
WARNING: multiple messages have this Message-ID (diff)
From: "\"Peter Pan(潘卫平)\"" <panweiping3@gmail.com>
To: "Dan Carpenter" <error27@gmail.com>,
"\"潘卫平(Peter Pan)\"" <wppan@redflag-linux.com>,
tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kerne
Subject: Re: [PATCH] ext4:memset is needless in ext4_ext_remove_space()
Date: Mon, 08 Nov 2010 14:24:06 +0800 [thread overview]
Message-ID: <4CD79786.9000303@gmail.com> (raw)
In-Reply-To: <20101108043752.GB5563@bicker>
On 2010年11月08日 12:37, Dan Carpenter wrote:
> This is inside a loop and sometimes we do i++ and sometimes i--. Are
> you absolutely positive that path + i isn't initialized?
>
> I haven't followed this code through all the way but my instinct is
> that the memset is there for a reason.
>
I know that I misunderstood it.
Thank you!
Regards
Peter Pan
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "\"Peter Pan(潘卫平)\"" <panweiping3@gmail.com>
To: "Dan Carpenter" <error27@gmail.com>,
"\"潘卫平(Peter Pan)\"" <wppan@redflag-linux.com>,
tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4:memset is needless in ext4_ext_remove_space()
Date: Mon, 08 Nov 2010 14:24:06 +0800 [thread overview]
Message-ID: <4CD79786.9000303@gmail.com> (raw)
In-Reply-To: <20101108043752.GB5563@bicker>
On 2010年11月08日 12:37, Dan Carpenter wrote:
> This is inside a loop and sometimes we do i++ and sometimes i--. Are
> you absolutely positive that path + i isn't initialized?
>
> I haven't followed this code through all the way but my instinct is
> that the memset is there for a reason.
>
I know that I misunderstood it.
Thank you!
Regards
Peter Pan
next prev parent reply other threads:[~2010-11-08 6:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 1:19 [PATCH] ext4:memset is needless in ext4_ext_remove_space() "潘卫平(Peter Pan)"
2010-11-08 1:19 ` "潘卫平(Peter Pan)"
2010-11-08 4:37 ` Dan Carpenter
2010-11-08 4:37 ` Dan Carpenter
2010-11-08 6:24 ` [this message]
2010-11-08 6:24 ` "Peter Pan(潘卫平)"
2010-11-08 6:24 ` "Peter Pan(潘卫平)"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD79786.9000303@gmail.com \
--to=error27@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kerne \
--cc=tytso@mit.edu \
--cc=wppan@redflag-linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.