[PATCH] pkgconfig.bbclass: don't blindly install every .pc file

[PATCH] pkgconfig.bbclass: don't blindly install every .pc file

[Andreas Oberritter]

* Instead of installing the file, print a log message. Later,
  this function could be removed.
* .pc files must be installed explicitly to avoid causing
  build problems. E.g. libsoup-2.4-gnome.pc must not be
  installed if libsoup-2.4 is built without gnome support,
  because gstreamer would try to link against libsoup-2.4-gnome.
* Fixes for lua5.1 and libid3tag, which install their own .pc
  files from OE, have been submitted.

Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
---
 classes/pkgconfig.bbclass |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/classes/pkgconfig.bbclass b/classes/pkgconfig.bbclass
index 23ab453..d96b708 100644
--- a/classes/pkgconfig.bbclass
+++ b/classes/pkgconfig.bbclass
@@ -16,6 +16,8 @@ pkgconfig_sysroot_preprocess () {
 	install -d ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}
 	for pc in `find ${S} -name '*.pc' -type f | grep -v -- '-uninstalled.pc$'`; do
 		pcname=`basename $pc`
-		cat $pc > ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname
+		if [ ! -f ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname ]; then
+			oenote "$pcname was not installed."
+		fi
 	done
 }
-- 
1.7.1

Re: [PATCH] pkgconfig.bbclass: don't blindly install every .pc file

[Andreas Oberritter]

Ping

On 10/25/2010 04:20 PM, Andreas Oberritter wrote:
> * Instead of installing the file, print a log message. Later,
>   this function could be removed.
> * .pc files must be installed explicitly to avoid causing
>   build problems. E.g. libsoup-2.4-gnome.pc must not be
>   installed if libsoup-2.4 is built without gnome support,
>   because gstreamer would try to link against libsoup-2.4-gnome.
> * Fixes for lua5.1 and libid3tag, which install their own .pc
>   files from OE, have been submitted.
> 
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
> ---
>  classes/pkgconfig.bbclass |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/classes/pkgconfig.bbclass b/classes/pkgconfig.bbclass
> index 23ab453..d96b708 100644
> --- a/classes/pkgconfig.bbclass
> +++ b/classes/pkgconfig.bbclass
> @@ -16,6 +16,8 @@ pkgconfig_sysroot_preprocess () {
>  	install -d ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}
>  	for pc in `find ${S} -name '*.pc' -type f | grep -v -- '-uninstalled.pc$'`; do
>  		pcname=`basename $pc`
> -		cat $pc > ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname
> +		if [ ! -f ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname ]; then
> +			oenote "$pcname was not installed."
> +		fi
>  	done
>  }

Re: [PATCH] pkgconfig.bbclass: don't blindly install every .pc file

[Andreas Oberritter]

I think I need to draw some more attention to this patch, because the
current way of installing all .pc files from a source tree to sysroot
causes build breakage.

I'd really prefer this being merged now, so it will make it into the
planned december release. Potential problems caused by the patch can
still be fixed before release, which means adding an install rule where
packages don't install their .pc files themselves.

Any opinions?

Regards,
Andreas

On 11/13/2010 05:27 PM, Andreas Oberritter wrote:
> Ping
> 
> On 10/25/2010 04:20 PM, Andreas Oberritter wrote:
>> * Instead of installing the file, print a log message. Later,
>>   this function could be removed.
>> * .pc files must be installed explicitly to avoid causing
>>   build problems. E.g. libsoup-2.4-gnome.pc must not be
>>   installed if libsoup-2.4 is built without gnome support,
>>   because gstreamer would try to link against libsoup-2.4-gnome.
>> * Fixes for lua5.1 and libid3tag, which install their own .pc
>>   files from OE, have been submitted.
>>
>> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
>> ---
>>  classes/pkgconfig.bbclass |    4 +++-
>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/classes/pkgconfig.bbclass b/classes/pkgconfig.bbclass
>> index 23ab453..d96b708 100644
>> --- a/classes/pkgconfig.bbclass
>> +++ b/classes/pkgconfig.bbclass
>> @@ -16,6 +16,8 @@ pkgconfig_sysroot_preprocess () {
>>  	install -d ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}
>>  	for pc in `find ${S} -name '*.pc' -type f | grep -v -- '-uninstalled.pc$'`; do
>>  		pcname=`basename $pc`
>> -		cat $pc > ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname
>> +		if [ ! -f ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname ]; then
>> +			oenote "$pcname was not installed."
>> +		fi
>>  	done
>>  }
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel