All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: tj@kernel.org, Joerg Roedel <Joerg.Roedel@amd.com>,
	Roland Elek <elek.roland@gmail.com>,
	QEMU-devel Developers <qemu-devel@nongnu.org>,
	Sebastian Herbszt <herbszt@gmx.de>
Subject: Re: [Qemu-devel] [PATCH 03/10] ide: add support for ide extenders
Date: Wed, 17 Nov 2010 09:57:36 +0100	[thread overview]
Message-ID: <4CE39900.4050306@redhat.com> (raw)
In-Reply-To: <1289955937-24121-4-git-send-email-agraf@suse.de>

   Hi,

> +/* This struct represents a device that uses an IDE bus, but requires
> + * modifications to how it works. An example is AHCI. */
> +struct IDEExtender {
> +    TransferStartFunc *transfer_start_fn;
> +    IRQSetFunc *irq_set_fn;
> +    DMAStartFunc *dma_start_fn;
> +};

Hmm, I'd call that IDEBusOps or simliar.

>   struct IDEBus {
>       BusState qbus;
>       IDEDevice *master;
>       IDEDevice *slave;
>       BMDMAState *bmdma;
>       IDEState ifs[2];
> +    IDEExtender extender;
         IDEBusOps *ops;

Note this is a pointer now, so you can have static IDEBusOps structs and 
just set the ops pointer instead of filling in three function pointers.

cheers,
   Gerd

  reply	other threads:[~2010-11-17  8:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  1:05 [Qemu-devel] [PATCH 00/10] AHCI emulation support Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 01/10] ide: split ide command interpretation off Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 02/10] ide: fix whitespace gap in ide_exec_cmd Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 03/10] ide: add support for ide extenders Alexander Graf
2010-11-17  8:57   ` Gerd Hoffmann [this message]
2010-11-17  1:05 ` [Qemu-devel] [PATCH 04/10] ide: enable preallocated sg lists Alexander Graf
2010-11-17  8:59   ` Gerd Hoffmann
2010-11-17  9:21   ` Stefan Hajnoczi
2010-11-17  1:05 ` [Qemu-devel] [PATCH 05/10] ide: add ncq identify data for ahci sata drives Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 06/10] pci: add storage class for sata Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 07/10] pci: add ich7 pci id Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation Alexander Graf
2010-11-17  9:08   ` Gerd Hoffmann
2010-11-17 12:21     ` Alexander Graf
2010-11-17 13:56       ` Gerd Hoffmann
2010-11-17  1:05 ` [Qemu-devel] [PATCH 09/10] ahci: add -drive support Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 10/10] ahci: spawn controller on demand Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE39900.4050306@redhat.com \
    --to=kraxel@redhat.com \
    --cc=Joerg.Roedel@amd.com \
    --cc=agraf@suse.de \
    --cc=elek.roland@gmail.com \
    --cc=herbszt@gmx.de \
    --cc=qemu-devel@nongnu.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.