All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: tj@kernel.org, Joerg Roedel <Joerg.Roedel@amd.com>,
	Roland Elek <elek.roland@gmail.com>,
	QEMU-devel Developers <qemu-devel@nongnu.org>,
	Sebastian Herbszt <herbszt@gmx.de>
Subject: Re: [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation
Date: Wed, 17 Nov 2010 14:56:51 +0100	[thread overview]
Message-ID: <4CE3DF23.60501@redhat.com> (raw)
In-Reply-To: <F9A98CD8-888C-4667-9CE3-58BEC0B68452@suse.de>

   Hi,

>> Hmm, no bus registered anywhere.  Dunno whenever it makes sense to
>> register ide bus(es) here or whenever we should create a new sata
>> bus.
>
> I'm not sure I understand this comment :).

The ahci controller should register one or more busses where you can 
hook up devices to via -device.  Right now the code seems to use one ide 
bus per sata port, with ide drives being attached to the master channel 
only.  The ide bus isn't registered though, so it isn't visible via 
qdev.  Thus you can't construct a machine with ahci using -device.

Also a ide bus as it works currently isn't exactly a good fit, there is 
no such thing as master/slave in sata.  Dunno whenever it is better to 
create a new sata bus or to extend the current ide bus code so it can 
handle both pata and sata.

Hope it is more clear now ;)

cheers,
   Gerd

  reply	other threads:[~2010-11-17 13:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  1:05 [Qemu-devel] [PATCH 00/10] AHCI emulation support Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 01/10] ide: split ide command interpretation off Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 02/10] ide: fix whitespace gap in ide_exec_cmd Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 03/10] ide: add support for ide extenders Alexander Graf
2010-11-17  8:57   ` Gerd Hoffmann
2010-11-17  1:05 ` [Qemu-devel] [PATCH 04/10] ide: enable preallocated sg lists Alexander Graf
2010-11-17  8:59   ` Gerd Hoffmann
2010-11-17  9:21   ` Stefan Hajnoczi
2010-11-17  1:05 ` [Qemu-devel] [PATCH 05/10] ide: add ncq identify data for ahci sata drives Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 06/10] pci: add storage class for sata Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 07/10] pci: add ich7 pci id Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation Alexander Graf
2010-11-17  9:08   ` Gerd Hoffmann
2010-11-17 12:21     ` Alexander Graf
2010-11-17 13:56       ` Gerd Hoffmann [this message]
2010-11-17  1:05 ` [Qemu-devel] [PATCH 09/10] ahci: add -drive support Alexander Graf
2010-11-17  1:05 ` [Qemu-devel] [PATCH 10/10] ahci: spawn controller on demand Alexander Graf
  -- strict thread matches above, loose matches on Subject: below --
2010-11-18  3:27 [Qemu-devel] [PATCH 00/10] AHCI emulation support v2 Alexander Graf
2010-11-18  3:27 ` [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation Alexander Graf
2010-12-01 19:17 [Qemu-devel] [PATCH 00/10] AHCI emulation support v7 Alexander Graf
2010-12-01 19:17 ` [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE3DF23.60501@redhat.com \
    --to=kraxel@redhat.com \
    --cc=Joerg.Roedel@amd.com \
    --cc=agraf@suse.de \
    --cc=elek.roland@gmail.com \
    --cc=herbszt@gmx.de \
    --cc=qemu-devel@nongnu.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.