From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: tj@kernel.org, Joerg Roedel <Joerg.Roedel@amd.com>,
Roland Elek <elek.roland@gmail.com>,
QEMU-devel Developers <qemu-devel@nongnu.org>,
Sebastian Herbszt <herbszt@gmx.de>
Subject: Re: [Qemu-devel] [PATCH 04/10] ide: enable preallocated sg lists
Date: Wed, 17 Nov 2010 09:59:33 +0100 [thread overview]
Message-ID: <4CE39975.7020101@redhat.com> (raw)
In-Reply-To: <1289955937-24121-5-git-send-email-agraf@suse.de>
Hi,
> + if (s->sg_third_party) {
> + /* We've already parsed the guest RAM PRDT.
> + * This is essential for AHCI, where the PRDT is in a different
> + * format than in IDE BMDMA.
> + */
> + memcpy((uint8_t *)&prd, s->sg.sg, sizeof(prd));
> + s->sg.sg++;
> + } else {
> + cpu_physical_memory_read(bm->cur_addr, (uint8_t *)&prd, 8);
> + bm->cur_addr += 8;
> + prd.addr = le32_to_cpu(prd.addr);
> + prd.size = le32_to_cpu(prd.size);
> + }
Does it make sense to handle this via IDEBusOps too?
cheers,
Gerd
next prev parent reply other threads:[~2010-11-17 9:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 1:05 [Qemu-devel] [PATCH 00/10] AHCI emulation support Alexander Graf
2010-11-17 1:05 ` [Qemu-devel] [PATCH 01/10] ide: split ide command interpretation off Alexander Graf
2010-11-17 1:05 ` [Qemu-devel] [PATCH 02/10] ide: fix whitespace gap in ide_exec_cmd Alexander Graf
2010-11-17 1:05 ` [Qemu-devel] [PATCH 03/10] ide: add support for ide extenders Alexander Graf
2010-11-17 8:57 ` Gerd Hoffmann
2010-11-17 1:05 ` [Qemu-devel] [PATCH 04/10] ide: enable preallocated sg lists Alexander Graf
2010-11-17 8:59 ` Gerd Hoffmann [this message]
2010-11-17 9:21 ` Stefan Hajnoczi
2010-11-17 1:05 ` [Qemu-devel] [PATCH 05/10] ide: add ncq identify data for ahci sata drives Alexander Graf
2010-11-17 1:05 ` [Qemu-devel] [PATCH 06/10] pci: add storage class for sata Alexander Graf
2010-11-17 1:05 ` [Qemu-devel] [PATCH 07/10] pci: add ich7 pci id Alexander Graf
2010-11-17 1:05 ` [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation Alexander Graf
2010-11-17 9:08 ` Gerd Hoffmann
2010-11-17 12:21 ` Alexander Graf
2010-11-17 13:56 ` Gerd Hoffmann
2010-11-17 1:05 ` [Qemu-devel] [PATCH 09/10] ahci: add -drive support Alexander Graf
2010-11-17 1:05 ` [Qemu-devel] [PATCH 10/10] ahci: spawn controller on demand Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE39975.7020101@redhat.com \
--to=kraxel@redhat.com \
--cc=Joerg.Roedel@amd.com \
--cc=agraf@suse.de \
--cc=elek.roland@gmail.com \
--cc=herbszt@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.