* [PATCH] call-volume: Minor coding style fix
@ 2010-11-26 14:57 Jeevaka Badrappan
2010-11-26 21:03 ` Denis Kenzior
0 siblings, 1 reply; 4+ messages in thread
From: Jeevaka Badrappan @ 2010-11-26 14:57 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 428 bytes --]
---
src/call-volume.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/call-volume.c b/src/call-volume.c
index dd1be92..0accdf2 100644
--- a/src/call-volume.c
+++ b/src/call-volume.c
@@ -114,7 +114,6 @@ static DBusMessage *cv_get_properties(DBusConnection *conn,
dbus_bool_t muted;
reply = dbus_message_new_method_return(msg);
-
if (!reply)
return NULL;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] call-volume: Minor coding style fix
2010-11-26 14:57 [PATCH] call-volume: Minor coding style fix Jeevaka Badrappan
@ 2010-11-26 21:03 ` Denis Kenzior
2010-11-26 21:21 ` Jeevaka Badrappan
0 siblings, 1 reply; 4+ messages in thread
From: Denis Kenzior @ 2010-11-26 21:03 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
Hi Jeevaka,
On 11/26/2010 08:57 AM, Jeevaka Badrappan wrote:
> ---
> src/call-volume.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/src/call-volume.c b/src/call-volume.c
> index dd1be92..0accdf2 100644
> --- a/src/call-volume.c
> +++ b/src/call-volume.c
> @@ -114,7 +114,6 @@ static DBusMessage *cv_get_properties(DBusConnection *conn,
> dbus_bool_t muted;
>
> reply = dbus_message_new_method_return(msg);
> -
> if (!reply)
> return NULL;
>
Style wise this is actually OK, but if you really want to be
style-pedantic :) then this should be:
reply = ...
if (reply == NULL)
return NULL
Regards,
-Denis
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] call-volume: Minor coding style fix
2010-11-26 21:03 ` Denis Kenzior
@ 2010-11-26 21:21 ` Jeevaka Badrappan
2010-11-26 21:24 ` Denis Kenzior
0 siblings, 1 reply; 4+ messages in thread
From: Jeevaka Badrappan @ 2010-11-26 21:21 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
---
src/call-volume.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/call-volume.c b/src/call-volume.c
index 6411467..6f692f3 100644
--- a/src/call-volume.c
+++ b/src/call-volume.c
@@ -114,8 +114,7 @@ static DBusMessage *cv_get_properties(DBusConnection *conn,
dbus_bool_t muted;
reply = dbus_message_new_method_return(msg);
-
- if (!reply)
+ if (reply == NULL)
return NULL;
dbus_message_iter_init_append(reply, &iter);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] call-volume: Minor coding style fix
2010-11-26 21:21 ` Jeevaka Badrappan
@ 2010-11-26 21:24 ` Denis Kenzior
0 siblings, 0 replies; 4+ messages in thread
From: Denis Kenzior @ 2010-11-26 21:24 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
Hi Jeevaka,
On 11/26/2010 03:21 PM, Jeevaka Badrappan wrote:
> ---
> src/call-volume.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-26 21:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-26 14:57 [PATCH] call-volume: Minor coding style fix Jeevaka Badrappan
2010-11-26 21:03 ` Denis Kenzior
2010-11-26 21:21 ` Jeevaka Badrappan
2010-11-26 21:24 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.