From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Igor Plyatov <plyatov@gmail.com>
Cc: sshtylyov@mvista.com, jgarzik@pobox.com,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
geomatsi@gmail.com, nicolas.ferre@atmel.com, linux@maxim.org.za,
linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
christian.glindkamp@taskit.de, ryan@bluewatersys.com,
pgsellmann@portner-elektronik.at
Subject: Re: [PATCH v2] ata: pata_at91.c bugfix for high master clock
Date: Sun, 12 Dec 2010 16:49:22 +0300 [thread overview]
Message-ID: <4D04D2E2.20100@ru.mvista.com> (raw)
In-Reply-To: <1292099846-24528-1-git-send-email-plyatov@gmail.com>
Hello.
On 11-12-2010 23:37, Igor Plyatov wrote:
> The AT91SAM9 microcontrollers with master clock higher then 105 MHz
> and PIO0, have overflow of the NCS_RD_PULSE value in the MSB. This
> lead to "NCS_RD_PULSE" pulse longer then "NRD_CYCLE" pulse and driver
> does not detect ATA device.
> Signed-off-by: Igor Plyatov<plyatov@gmail.com>
[...]
> diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> index 0da0dcc..a462405 100644
> --- a/drivers/ata/pata_at91.c
> +++ b/drivers/ata/pata_at91.c
[...]
> @@ -50,7 +52,7 @@ struct at91_ide_info {
> };
>
> static const struct ata_timing initial_timing =
> - {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0};
> + {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 0, 600, 0};
BTW, you haven't described this in the changelog...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ata: pata_at91.c bugfix for high master clock
Date: Sun, 12 Dec 2010 16:49:22 +0300 [thread overview]
Message-ID: <4D04D2E2.20100@ru.mvista.com> (raw)
In-Reply-To: <1292099846-24528-1-git-send-email-plyatov@gmail.com>
Hello.
On 11-12-2010 23:37, Igor Plyatov wrote:
> The AT91SAM9 microcontrollers with master clock higher then 105 MHz
> and PIO0, have overflow of the NCS_RD_PULSE value in the MSB. This
> lead to "NCS_RD_PULSE" pulse longer then "NRD_CYCLE" pulse and driver
> does not detect ATA device.
> Signed-off-by: Igor Plyatov<plyatov@gmail.com>
[...]
> diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> index 0da0dcc..a462405 100644
> --- a/drivers/ata/pata_at91.c
> +++ b/drivers/ata/pata_at91.c
[...]
> @@ -50,7 +52,7 @@ struct at91_ide_info {
> };
>
> static const struct ata_timing initial_timing =
> - {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0};
> + {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 0, 600, 0};
BTW, you haven't described this in the changelog...
WBR, Sergei
next prev parent reply other threads:[~2010-12-12 13:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-11 20:37 [PATCH v2] ata: pata_at91.c bugfix for high master clock Igor Plyatov
2010-12-11 20:37 ` Igor Plyatov
2010-12-11 22:10 ` Jeff Garzik
2010-12-11 22:10 ` Jeff Garzik
2010-12-12 13:49 ` Sergei Shtylyov [this message]
2010-12-12 13:49 ` Sergei Shtylyov
2010-12-12 19:02 ` Igor Plyatov
2010-12-12 19:02 ` Igor Plyatov
2010-12-13 11:02 ` Sergei Shtylyov
2010-12-13 11:02 ` Sergei Shtylyov
2010-12-24 18:30 ` Jeff Garzik
2010-12-24 18:30 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D04D2E2.20100@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=christian.glindkamp@taskit.de \
--cc=geomatsi@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@maxim.org.za \
--cc=nicolas.ferre@atmel.com \
--cc=pgsellmann@portner-elektronik.at \
--cc=plyatov@gmail.com \
--cc=ryan@bluewatersys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.