Re: [PATCH] exofs: Remove redundant unlikely()

[Boaz Harrosh <bharrosh@panasas.com>]

On 12/09/2010 04:55 PM, Tobias Klauser wrote:
> IS_ERR() already implies unlikely(), so it can be omitted here.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  fs/exofs/super.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
> index 79c3ae6..b2b12a8 100644
> --- a/fs/exofs/super.c
> +++ b/fs/exofs/super.c
> @@ -488,7 +488,7 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi,
>  		}
>  
>  		od = osduld_info_lookup(&odi);
> -		if (unlikely(IS_ERR(od))) {
> +		if (IS_ERR(od)) {
>  			ret = PTR_ERR(od);
>  			EXOFS_ERR("ERROR: device requested is not found "
>  				  "osd_name-%s =>%d\n", odi.osdname, ret);

I've applied it in my local tree, it'll be included in the next linux-next
version I release. For the next merge window.

Thanks. Good catch
Boaz