* [PATCH] exofs: Remove redundant unlikely()
@ 2010-12-09 14:55 Tobias Klauser
2010-12-12 14:50 ` Boaz Harrosh
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2010-12-09 14:55 UTC (permalink / raw)
To: kernel-janitors
IS_ERR() already implies unlikely(), so it can be omitted here.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
fs/exofs/super.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/exofs/super.c b/fs/exofs/super.c
index 79c3ae6..b2b12a8 100644
--- a/fs/exofs/super.c
+++ b/fs/exofs/super.c
@@ -488,7 +488,7 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi,
}
od = osduld_info_lookup(&odi);
- if (unlikely(IS_ERR(od))) {
+ if (IS_ERR(od)) {
ret = PTR_ERR(od);
EXOFS_ERR("ERROR: device requested is not found "
"osd_name-%s =>%d\n", odi.osdname, ret);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] exofs: Remove redundant unlikely()
2010-12-09 14:55 [PATCH] exofs: Remove redundant unlikely() Tobias Klauser
@ 2010-12-12 14:50 ` Boaz Harrosh
0 siblings, 0 replies; 2+ messages in thread
From: Boaz Harrosh @ 2010-12-12 14:50 UTC (permalink / raw)
To: kernel-janitors
On 12/09/2010 04:55 PM, Tobias Klauser wrote:
> IS_ERR() already implies unlikely(), so it can be omitted here.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> fs/exofs/super.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
> index 79c3ae6..b2b12a8 100644
> --- a/fs/exofs/super.c
> +++ b/fs/exofs/super.c
> @@ -488,7 +488,7 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi,
> }
>
> od = osduld_info_lookup(&odi);
> - if (unlikely(IS_ERR(od))) {
> + if (IS_ERR(od)) {
> ret = PTR_ERR(od);
> EXOFS_ERR("ERROR: device requested is not found "
> "osd_name-%s =>%d\n", odi.osdname, ret);
I've applied it in my local tree, it'll be included in the next linux-next
version I release. For the next merge window.
Thanks. Good catch
Boaz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-12 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-09 14:55 [PATCH] exofs: Remove redundant unlikely() Tobias Klauser
2010-12-12 14:50 ` Boaz Harrosh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.