From: "Cousson, Benoit" <b-cousson@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: "Bergsagel, Jonathan" <jbergsagel@ti.com>,
"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Nayak, Rajendra" <rnayak@ti.com>
Subject: Re: [PATCH v2 4/8] OMAP4: clock data: Add missing fields in iva_hsd_byp_clk_mux_ck
Date: Mon, 13 Dec 2010 14:14:10 +0100 [thread overview]
Message-ID: <4D061C22.9020405@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1012101732320.13430@utopia.booyaka.com>
Hi Paul,
On 12/11/2010 1:34 AM, Paul Walmsley wrote:
> On Thu, 9 Dec 2010, Benoit Cousson wrote:
>
>> From: Jonathan Bergsagel<jbergsagel@ti.com>
>>
>> Add register address, mask and link to the clksel structure that
>> were missing in the IVA DPLL mux clock node.
>>
>> Signed-off-by: Jonathan Bergsagel<jbergsagel@ti.com>
>> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
>
> This patch results in a checkpatch warning:
>
> ---
>
> WARNING: please, no space before tabs
> #23: FILE: arch/arm/mach-omap2/clock44xx_data.c:639:
> +^I.clksel ^I= iva_hsd_byp_clk_mux_sel,$
>
> total: 0 errors, 1 warnings, 0 checks, 13 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> ---
>
> I've fixed it in the copy in my local branch, but next time, please run
> checkpatch.pl and fix any problems before submitting.
Oops, that's my mistake. the original patch was good, and I messed it up
during the merge conflict resolution.
And then on top of that I completely missed this warning due to the
important number of "line over 80 characters" warnings in this series.
I have now a "filter for dummies" to remove that and avoid missing real
warnings in the future.
Thanks,
Benoit
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/8] OMAP4: clock data: Add missing fields in iva_hsd_byp_clk_mux_ck
Date: Mon, 13 Dec 2010 14:14:10 +0100 [thread overview]
Message-ID: <4D061C22.9020405@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1012101732320.13430@utopia.booyaka.com>
Hi Paul,
On 12/11/2010 1:34 AM, Paul Walmsley wrote:
> On Thu, 9 Dec 2010, Benoit Cousson wrote:
>
>> From: Jonathan Bergsagel<jbergsagel@ti.com>
>>
>> Add register address, mask and link to the clksel structure that
>> were missing in the IVA DPLL mux clock node.
>>
>> Signed-off-by: Jonathan Bergsagel<jbergsagel@ti.com>
>> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
>
> This patch results in a checkpatch warning:
>
> ---
>
> WARNING: please, no space before tabs
> #23: FILE: arch/arm/mach-omap2/clock44xx_data.c:639:
> +^I.clksel ^I= iva_hsd_byp_clk_mux_sel,$
>
> total: 0 errors, 1 warnings, 0 checks, 13 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> ---
>
> I've fixed it in the copy in my local branch, but next time, please run
> checkpatch.pl and fix any problems before submitting.
Oops, that's my mistake. the original patch was good, and I messed it up
during the merge conflict resolution.
And then on top of that I completely missed this warning due to the
important number of "line over 80 characters" warnings in this series.
I have now a "filter for dummies" to remove that and avoid missing real
warnings in the future.
Thanks,
Benoit
next prev parent reply other threads:[~2010-12-13 13:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 22:13 [PATCH v2 0/8] OMAP3&4: clock data: Fixes and add new clocks nodes Benoit Cousson
2010-12-09 22:13 ` Benoit Cousson
2010-12-09 22:13 ` [PATCH v2 1/8] OMAP4: clock data: Add control for pad_clks_ck and slimbus_clk Benoit Cousson
2010-12-09 22:13 ` Benoit Cousson
2010-12-09 22:13 ` [PATCH v2 2/8] OMAP3: clock data: Add "wkup_clkdm" in sr1_fck and sr2_fck Benoit Cousson
2010-12-09 22:13 ` Benoit Cousson
2010-12-09 22:13 ` [PATCH v2 3/8] OMAP4: clock data: Add missing DPLL x2 clock nodes Benoit Cousson
2010-12-09 22:13 ` Benoit Cousson
2010-12-09 22:13 ` [PATCH v2 4/8] OMAP4: clock data: Add missing fields in iva_hsd_byp_clk_mux_ck Benoit Cousson
2010-12-09 22:13 ` Benoit Cousson
2010-12-11 0:34 ` Paul Walmsley
2010-12-11 0:34 ` Paul Walmsley
2010-12-13 13:14 ` Cousson, Benoit [this message]
2010-12-13 13:14 ` Cousson, Benoit
2010-12-09 22:13 ` [PATCH v2 5/8] OMAP4: PRCM: Add SCRM header file Benoit Cousson
2010-12-09 22:13 ` Benoit Cousson
2010-12-09 22:13 ` [PATCH v2 6/8] OMAP4: clock data: Add SCRM auxiliary clock nodes Benoit Cousson
2010-12-09 22:13 ` Benoit Cousson
2010-12-09 22:13 ` [PATCH v2 7/8] OMAP4: clock data: Export control to enable/disable CORE/PER M3 clocks Benoit Cousson
2010-12-09 22:13 ` Benoit Cousson
2010-12-09 22:13 ` [PATCH v2 8/8] OMAP4: clock data: Add missing fixed divisors Benoit Cousson
2010-12-09 22:13 ` Benoit Cousson
2010-12-22 17:21 ` Paul Walmsley
2010-12-22 17:21 ` Paul Walmsley
2010-12-10 0:35 ` [PATCH v2 0/8] OMAP3&4: clock data: Fixes and add new clocks nodes Kevin Hilman
2010-12-10 0:35 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D061C22.9020405@ti.com \
--to=b-cousson@ti.com \
--cc=jbergsagel@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.