Re: [PATCH] msm: trout: add keypad support

[Trilok Soni <tsoni@codeaurora.org>]

Hi Daniel,

On 12/14/2010 12:11 AM, Daniel Walker wrote:
> On Fri, 2010-12-10 at 13:02 +0530, Trilok Soni wrote:
>> Hi Daniel,
>>
>> On 12/10/2010 3:33 AM, Daniel Walker wrote:
>>> On Thu, 2010-12-09 at 14:01 -0800, Arve Hjønnevåg wrote:
>>>> On Thu, Dec 9, 2010 at 9:45 AM, Daniel Walker <dwalker@codeaurora.org> wrote:
>>>>> On Thu, 2010-12-09 at 12:36 +0530, Trilok Soni wrote:
>>>>>
>>>>>>> +static char *keycaps = "--qwerty";
>>>>>>> +#undef MODULE_PARAM_PREFIX
>>>>>>> +#define MODULE_PARAM_PREFIX "board_trout."
>>>>>>> +module_param_named(keycaps, keycaps, charp, 0);
>>>>>>
>>>>>> I would like to know what is the use of this param?
>>>>>
>>>>> No idea .. It was part of Google's implementation ..
>>>>>
>>>>
>>>> You removed the code that uses it. If you look at the original file
>>>> you can see how it is used:
>>>> http://android.git.kernel.org/?p=kernel/msm.git;a=blob;f=arch/arm/mach-msm/board-trout-keypad.c;hb=refs/heads/android-msm-2.6.35
>>>> It is set by the bootloader according to the hardware version.
>>>>
>>>> You can also see that the "/* userspace needs to know about these
>>>> changes as well */" comments refer to the code that changes the name
>>>> of the input device.
>>>>
>>>> I don't think this change will work correctly with our existing
>>>> user-space code though since you are now reporting the power-key,
>>>> camera-key and slide-switch from a separate input device.
>>>
>>> Yeah, I did remove those parts.. I'm not sure where to put that stuff in
>>> this new implementation. I can try to find an appropriate place , unless
>>> you have some suggestions ?
>>
>> To support this, we need to override the input device .name and submit the patches
>> for matrix keypad and gpio keys and let the name come through platform data. 
>>
>> You can refer how I am doing in PM8058 keypad driver patch.
> 
> Not sure what your talking about .. I'm not making a new driver. I'm
> just using the matrix keypad driver.

I am just referring about changing the .name part of input device, which you will
need in-order to get the userspace working. For that to happen you need to change
gpio-keys and matrix keypad driver. I am not asking about creating a new driver.

---Trilok Soni

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.