pipe control notify removed?

pipe control notify removed?

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 610 bytes --]


Chris, just notice you removed pipe control notify entirely on -next,
that seems wrong to me. In Ironlake time, we've seen interrupt stall issue
with user interrupt, and be warned user interrupt is deprecated, so we moved
on to use pipe control notify, although there's a workaround later covered
that's required on Ironlake. But it's stable finally. And for sandybridge, 
there's no such workaround needed.

btw, could you also send mails for changes on -next? It'll be easy to be
notified.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: pipe control notify removed?

[Shuang He]

[-- Attachment #1.1: Type: text/plain, Size: 838 bytes --]

Yeah, I also met this issue, and bisection point to this as well :)

32402 <https://bugs.freedesktop.org/show_bug.cgi?id=32402> 	19:05:15 
cri 	hig 	chris@chris-wilson.co.uk 	shuang.he@intel.com 	NEW 	
	[piketon -next bisected] Many tests make GPU hang and reset


Thanks
     --Shuang

On 2010-12-15 11:14, Zhenyu Wang wrote:
> Chris, just notice you removed pipe control notify entirely on -next,
> that seems wrong to me. In Ironlake time, we've seen interrupt stall issue
> with user interrupt, and be warned user interrupt is deprecated, so we moved
> on to use pipe control notify, although there's a workaround later covered
> that's required on Ironlake. But it's stable finally. And for sandybridge,
> there's no such workaround needed.
>
> btw, could you also send mails for changes on -next? It'll be easy to be
> notified.
>


[-- Attachment #1.2: Type: text/html, Size: 2418 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: pipe control notify removed?

[Chris Wilson]

On Wed, 15 Dec 2010 11:14:53 +0800, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> 
> Chris, just notice you removed pipe control notify entirely on -next,
> that seems wrong to me. In Ironlake time, we've seen interrupt stall issue
> with user interrupt, and be warned user interrupt is deprecated, so we moved
> on to use pipe control notify, although there's a workaround later covered
> that's required on Ironlake. But it's stable finally. And for sandybridge, 
> there's no such workaround needed.

The answer to this is to make sure that such details are kept in the
code comments, especially if such information is not readily available
in the documentation.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: pipe control notify removed?

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 962 bytes --]

On 2010.12.15 10:05:01 +0000, Chris Wilson wrote:
> On Wed, 15 Dec 2010 11:14:53 +0800, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> > 
> > Chris, just notice you removed pipe control notify entirely on -next,
> > that seems wrong to me. In Ironlake time, we've seen interrupt stall issue
> > with user interrupt, and be warned user interrupt is deprecated, so we moved
> > on to use pipe control notify, although there's a workaround later covered
> > that's required on Ironlake. But it's stable finally. And for sandybridge, 
> > there's no such workaround needed.
> 
> The answer to this is to make sure that such details are kept in the
> code comments, especially if such information is not readily available
> in the documentation.

yeah, also our spec might not have been updated as well...I'll send the BUN
doc for that to you.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: pipe control notify removed?

[Fu Michael]

On 2010/12/16 9:59, Zhenyu Wang wrote:
> On 2010.12.15 10:05:01 +0000, Chris Wilson wrote:
>> On Wed, 15 Dec 2010 11:14:53 +0800, Zhenyu Wang<zhenyuw@linux.intel.com>  wrote:
>>>
>>> Chris, just notice you removed pipe control notify entirely on -next,
>>> that seems wrong to me. In Ironlake time, we've seen interrupt stall issue
>>> with user interrupt, and be warned user interrupt is deprecated, so we moved
>>> on to use pipe control notify, although there's a workaround later covered
>>> that's required on Ironlake. But it's stable finally. And for sandybridge,
>>> there's no such workaround needed.
>>
>> The answer to this is to make sure that such details are kept in the
>> code comments, especially if such information is not readily available
>> in the documentation.
>
> yeah, also our spec might not have been updated as well...I'll send the BUN
> doc for that to you.
>

I guess what Chris really want is to leave some comments in the code for 
such workaround - BUN id isn't very useful to most people anyway. ;)

>
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx