All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: balbi@ti.com
Cc: "Gupta, Ajay Kumar" <ajay.gupta@ti.com>,
	"davinci-linux-open-source@linux.davincidsp.com"
	<davinci-linux-open-source@linux.davincidsp.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support
Date: Tue, 04 Jan 2011 16:06:39 +0300	[thread overview]
Message-ID: <4D231B5F.7030607@mvista.com> (raw)
In-Reply-To: <20110103204416.GA2240@legolas.emea.dhcp.ti.com>

Hello.

On 03-01-2011 23:44, Felipe Balbi wrote:

>>> > Moreover, even Felipe also seems to move other musb
>>> > DMAs (Inventra, CPPI3.0, TUSB) to drivers/dma.

>>> Frankly speaking, I doubt that drivers/dma/ will have place for the
>>> purely MUSB specific DMA engines such as the named ones (there's no TUSB
>>> DMA BTW it uses OMAP DMA).

>> I think we will get more clarity once we start on this activity.

> I agree, but I personally don't see that many limiting factors.
> dmaengine is just a generic API for doing DMA transfers. If it's not
> enough for us currently, we extend it.

    Putting MUSB DMA enignes into drivers/dma/ is the same as taking *any* 
chip capable of bus-mastering DMA, "separating" its bus mastering related code 
from its driver and putting this code into drivers/dma/. This doesn't make 
sense, in my opinion. drivers/dma/ is for the dedicated DMA controllers (which 
can *optionally* serve the slave devices).

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support
Date: Tue, 04 Jan 2011 16:06:39 +0300	[thread overview]
Message-ID: <4D231B5F.7030607@mvista.com> (raw)
In-Reply-To: <20110103204416.GA2240@legolas.emea.dhcp.ti.com>

Hello.

On 03-01-2011 23:44, Felipe Balbi wrote:

>>> > Moreover, even Felipe also seems to move other musb
>>> > DMAs (Inventra, CPPI3.0, TUSB) to drivers/dma.

>>> Frankly speaking, I doubt that drivers/dma/ will have place for the
>>> purely MUSB specific DMA engines such as the named ones (there's no TUSB
>>> DMA BTW it uses OMAP DMA).

>> I think we will get more clarity once we start on this activity.

> I agree, but I personally don't see that many limiting factors.
> dmaengine is just a generic API for doing DMA transfers. If it's not
> enough for us currently, we extend it.

    Putting MUSB DMA enignes into drivers/dma/ is the same as taking *any* 
chip capable of bus-mastering DMA, "separating" its bus mastering related code 
from its driver and putting this code into drivers/dma/. This doesn't make 
sense, in my opinion. drivers/dma/ is for the dedicated DMA controllers (which 
can *optionally* serve the slave devices).

WBR, Sergei

  reply	other threads:[~2011-01-04 13:07 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-15 18:14 [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support Sergei Shtylyov
2010-05-28 20:55 ` Sergei Shtylyov
2010-09-28  9:13 ` Linus Walleij
2010-09-28  9:13   ` Linus Walleij
2010-09-28 10:13   ` Sergei Shtylyov
2010-09-28 10:13     ` Sergei Shtylyov
2011-01-03 16:06 ` Sergei Shtylyov
2011-01-03 16:34   ` Russell King - ARM Linux
2011-01-03 16:34     ` Russell King - ARM Linux
2011-01-03 17:01     ` Gupta, Ajay Kumar
2011-01-03 17:01       ` Gupta, Ajay Kumar
2011-01-03 17:07       ` Sergei Shtylyov
2011-01-03 17:07         ` Sergei Shtylyov
     [not found]         ` <4D220246.5020303-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2011-01-03 17:15           ` Gupta, Ajay Kumar
2011-01-03 17:15             ` Gupta, Ajay Kumar
2011-01-03 20:44             ` Felipe Balbi
2011-01-03 20:44               ` Felipe Balbi
2011-01-04 13:06               ` Sergei Shtylyov [this message]
2011-01-04 13:06                 ` Sergei Shtylyov
2011-01-04 14:06                 ` Felipe Balbi
2011-01-04 14:06                   ` Felipe Balbi
2011-01-04 14:40                   ` Ming Lei
2011-01-04 14:40                     ` Ming Lei
2011-01-04 14:56                     ` Felipe Balbi
2011-01-04 14:56                       ` Felipe Balbi
2011-01-04 15:41                       ` Ming Lei
2011-01-04 15:41                         ` Ming Lei
2011-01-04 18:42                         ` Felipe Balbi
2011-01-04 18:42                           ` Felipe Balbi
2011-01-04 18:50                           ` Sergei Shtylyov
2011-01-04 18:50                             ` Sergei Shtylyov
2011-01-04 16:37                   ` Sergei Shtylyov
2011-01-04 16:37                     ` Sergei Shtylyov
2011-01-05 22:03                 ` Russell King - ARM Linux
2011-01-05 22:03                   ` Russell King - ARM Linux
2011-01-03 17:19         ` Russell King - ARM Linux
2011-01-03 17:19           ` Russell King - ARM Linux
2011-01-03 20:49           ` Felipe Balbi
2011-01-03 20:49             ` Felipe Balbi
2011-01-04 19:12             ` Tony Lindgren
2011-01-04 19:12               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D231B5F.7030607@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=ajay.gupta@ti.com \
    --cc=balbi@ti.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.