From: Nishanth Menon <nm@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, khilman@ti.com, tony@atomide.com,
linux-arm-kernel@lists.infradead.org,
Thara Gopinath <thara@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH 3/5] omap2plus: voltage: Trivial warning fix 'no return statement'
Date: Tue, 04 Jan 2011 12:43:41 -0600 [thread overview]
Message-ID: <4D236A5D.9040803@ti.com> (raw)
In-Reply-To: <1294165576-15628-4-git-send-email-santosh.shilimkar@ti.com>
Santosh Shilimkar had written, on 01/04/2011 12:26 PM, the following:
[..]
> diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/arch/arm/plat-omap/include/plat/voltage.h
> index 0ff1233..710f4ea 100644
> --- a/arch/arm/plat-omap/include/plat/voltage.h
> +++ b/arch/arm/plat-omap/include/plat/voltage.h
> @@ -134,7 +134,10 @@ void omap_change_voltscale_method(struct voltagedomain *voltdm,
> int omap_voltage_late_init(void);
> #else
> static inline int omap_voltage_register_pmic(struct voltagedomain *voltdm,
> - struct omap_volt_pmic_info *pmic_info) {}
> + struct omap_volt_pmic_info *pmic_info)
> +{
> + return 0;
since we dont really succeed registering the pmic to voltage layer,
return -EINVAL?
[..]
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] omap2plus: voltage: Trivial warning fix 'no return statement'
Date: Tue, 04 Jan 2011 12:43:41 -0600 [thread overview]
Message-ID: <4D236A5D.9040803@ti.com> (raw)
In-Reply-To: <1294165576-15628-4-git-send-email-santosh.shilimkar@ti.com>
Santosh Shilimkar had written, on 01/04/2011 12:26 PM, the following:
[..]
> diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/arch/arm/plat-omap/include/plat/voltage.h
> index 0ff1233..710f4ea 100644
> --- a/arch/arm/plat-omap/include/plat/voltage.h
> +++ b/arch/arm/plat-omap/include/plat/voltage.h
> @@ -134,7 +134,10 @@ void omap_change_voltscale_method(struct voltagedomain *voltdm,
> int omap_voltage_late_init(void);
> #else
> static inline int omap_voltage_register_pmic(struct voltagedomain *voltdm,
> - struct omap_volt_pmic_info *pmic_info) {}
> + struct omap_volt_pmic_info *pmic_info)
> +{
> + return 0;
since we dont really succeed registering the pmic to voltage layer,
return -EINVAL?
[..]
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2011-01-04 18:43 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 18:26 [PATCH 0/5] omap2plus: Trivial build break fixes Santosh Shilimkar
2011-01-04 18:26 ` Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 1/5] omap2plus: clockdomain: Trivial fix for build break because of clktrctrl_mask Santosh Shilimkar
2011-01-04 18:26 ` Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 2/5] omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg' Santosh Shilimkar
2011-01-04 18:26 ` Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 3/5] omap2plus: voltage: Trivial warning fix 'no return statement' Santosh Shilimkar
2011-01-04 18:26 ` Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference' Santosh Shilimkar
2011-01-04 18:26 ` Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 5/5] omap2plus: voltage: Trivial linking fix for 'EINVAL' undeclared Santosh Shilimkar
2011-01-04 18:26 ` Santosh Shilimkar
2011-01-04 18:49 ` Nishanth Menon
2011-01-04 18:49 ` Nishanth Menon
2011-01-04 18:51 ` Santosh Shilimkar
2011-01-04 18:51 ` Santosh Shilimkar
2011-01-04 18:56 ` Nishanth Menon
2011-01-04 18:56 ` Nishanth Menon
2011-01-04 18:46 ` [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference' Nishanth Menon
2011-01-04 18:46 ` Nishanth Menon
2011-01-04 18:48 ` Santosh Shilimkar
2011-01-04 18:48 ` Santosh Shilimkar
2011-01-04 18:50 ` Santosh Shilimkar
2011-01-04 18:50 ` Santosh Shilimkar
2011-01-04 18:52 ` Nishanth Menon
2011-01-04 18:52 ` Nishanth Menon
2011-01-04 18:43 ` Nishanth Menon [this message]
2011-01-04 18:43 ` [PATCH 3/5] omap2plus: voltage: Trivial warning fix 'no return statement' Nishanth Menon
2011-01-04 18:46 ` Santosh Shilimkar
2011-01-04 18:46 ` Santosh Shilimkar
2011-01-04 18:41 ` [PATCH 2/5] omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg' Paul Walmsley
2011-01-04 18:41 ` Paul Walmsley
2011-01-04 18:43 ` Santosh Shilimkar
2011-01-04 18:43 ` Santosh Shilimkar
2011-01-05 0:32 ` Kevin Hilman
2011-01-05 0:32 ` Kevin Hilman
2011-01-05 8:18 ` Santosh Shilimkar
2011-01-05 8:18 ` Santosh Shilimkar
2011-01-04 18:43 ` [PATCH 1/5] omap2plus: clockdomain: Trivial fix for build break because of clktrctrl_mask Paul Walmsley
2011-01-04 18:43 ` Paul Walmsley
2011-01-04 18:45 ` Santosh Shilimkar
2011-01-04 18:45 ` Santosh Shilimkar
2011-01-05 0:37 ` [PATCH 0/5] omap2plus: Trivial build break fixes Kevin Hilman
2011-01-05 0:37 ` Kevin Hilman
2011-01-05 10:58 ` Santosh Shilimkar
2011-01-05 10:58 ` Santosh Shilimkar
2011-01-05 17:20 ` Kevin Hilman
2011-01-05 17:20 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D236A5D.9040803@ti.com \
--to=nm@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=thara@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.