From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap@vger.kernel.org, Kevin Hilman <khilman@ti.com>,
tony@atomide.com, linux-arm-kernel@lists.infradead.org,
Thara Gopinath <thara@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: RE: [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference'
Date: Wed, 5 Jan 2011 00:20:02 +0530 [thread overview]
Message-ID: <d7800f7a785b294a089ea8772607d232@mail.gmail.com> (raw)
In-Reply-To: <2a7055e7c506648a2a48a0454756687b@mail.gmail.com>
> -----Original Message-----
> From: Santosh Shilimkar [mailto:santosh.shilimkar@ti.com]
> Sent: Wednesday, January 05, 2011 12:18 AM
> To: Nishanth Menon
> Cc: linux-omap@vger.kernel.org; Kevin Hilman; tony@atomide.com;
> linux-arm-kernel@lists.infradead.org; Thara Gopinath; Kevin Hilman
> Subject: RE: [PATCH 4/5] omap2plus: voltage: Trivial linking fix
> 'undefined reference'
>
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> > owner@vger.kernel.org] On Behalf Of Nishanth Menon
> > Sent: Wednesday, January 05, 2011 12:16 AM
> > To: Santosh Shilimkar
> > Cc: linux-omap@vger.kernel.org; khilman@ti.com; tony@atomide.com;
> > linux-arm-kernel@lists.infradead.org; Thara Gopinath; Kevin Hilman
> > Subject: Re: [PATCH 4/5] omap2plus: voltage: Trivial linking fix
> > 'undefined reference'
> >
> > Santosh Shilimkar had written, on 01/04/2011 12:26 PM, the
> > following:
> > [..]
> >
[..]
> > > +static inline struct voltagedomain
> > *omap_voltage_domain_lookup(char *name)
> > > +{
> > > + return NULL;
> > the omap_voltage_domain_lookup uses ERR_PTR() for all return
> values
> > which are handled by the callers with IS_ERR()
> >
> > I think you should return ERR_PTR(-EINVAL)
> >
> The expected return value is pointer type and hence used
> NULL.
'ERR_PTR(-EINVAL)' is also ok.
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference'
Date: Wed, 5 Jan 2011 00:20:02 +0530 [thread overview]
Message-ID: <d7800f7a785b294a089ea8772607d232@mail.gmail.com> (raw)
In-Reply-To: <2a7055e7c506648a2a48a0454756687b@mail.gmail.com>
> -----Original Message-----
> From: Santosh Shilimkar [mailto:santosh.shilimkar at ti.com]
> Sent: Wednesday, January 05, 2011 12:18 AM
> To: Nishanth Menon
> Cc: linux-omap at vger.kernel.org; Kevin Hilman; tony at atomide.com;
> linux-arm-kernel at lists.infradead.org; Thara Gopinath; Kevin Hilman
> Subject: RE: [PATCH 4/5] omap2plus: voltage: Trivial linking fix
> 'undefined reference'
>
> > -----Original Message-----
> > From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
> > owner at vger.kernel.org] On Behalf Of Nishanth Menon
> > Sent: Wednesday, January 05, 2011 12:16 AM
> > To: Santosh Shilimkar
> > Cc: linux-omap at vger.kernel.org; khilman at ti.com; tony at atomide.com;
> > linux-arm-kernel at lists.infradead.org; Thara Gopinath; Kevin Hilman
> > Subject: Re: [PATCH 4/5] omap2plus: voltage: Trivial linking fix
> > 'undefined reference'
> >
> > Santosh Shilimkar had written, on 01/04/2011 12:26 PM, the
> > following:
> > [..]
> >
[..]
> > > +static inline struct voltagedomain
> > *omap_voltage_domain_lookup(char *name)
> > > +{
> > > + return NULL;
> > the omap_voltage_domain_lookup uses ERR_PTR() for all return
> values
> > which are handled by the callers with IS_ERR()
> >
> > I think you should return ERR_PTR(-EINVAL)
> >
> The expected return value is pointer type and hence used
> NULL.
'ERR_PTR(-EINVAL)' is also ok.
next prev parent reply other threads:[~2011-01-04 18:50 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 18:26 [PATCH 0/5] omap2plus: Trivial build break fixes Santosh Shilimkar
2011-01-04 18:26 ` Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 1/5] omap2plus: clockdomain: Trivial fix for build break because of clktrctrl_mask Santosh Shilimkar
2011-01-04 18:26 ` Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 2/5] omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg' Santosh Shilimkar
2011-01-04 18:26 ` Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 3/5] omap2plus: voltage: Trivial warning fix 'no return statement' Santosh Shilimkar
2011-01-04 18:26 ` Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference' Santosh Shilimkar
2011-01-04 18:26 ` Santosh Shilimkar
2011-01-04 18:26 ` [PATCH 5/5] omap2plus: voltage: Trivial linking fix for 'EINVAL' undeclared Santosh Shilimkar
2011-01-04 18:26 ` Santosh Shilimkar
2011-01-04 18:49 ` Nishanth Menon
2011-01-04 18:49 ` Nishanth Menon
2011-01-04 18:51 ` Santosh Shilimkar
2011-01-04 18:51 ` Santosh Shilimkar
2011-01-04 18:56 ` Nishanth Menon
2011-01-04 18:56 ` Nishanth Menon
2011-01-04 18:46 ` [PATCH 4/5] omap2plus: voltage: Trivial linking fix 'undefined reference' Nishanth Menon
2011-01-04 18:46 ` Nishanth Menon
2011-01-04 18:48 ` Santosh Shilimkar
2011-01-04 18:48 ` Santosh Shilimkar
2011-01-04 18:50 ` Santosh Shilimkar [this message]
2011-01-04 18:50 ` Santosh Shilimkar
2011-01-04 18:52 ` Nishanth Menon
2011-01-04 18:52 ` Nishanth Menon
2011-01-04 18:43 ` [PATCH 3/5] omap2plus: voltage: Trivial warning fix 'no return statement' Nishanth Menon
2011-01-04 18:43 ` Nishanth Menon
2011-01-04 18:46 ` Santosh Shilimkar
2011-01-04 18:46 ` Santosh Shilimkar
2011-01-04 18:41 ` [PATCH 2/5] omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg' Paul Walmsley
2011-01-04 18:41 ` Paul Walmsley
2011-01-04 18:43 ` Santosh Shilimkar
2011-01-04 18:43 ` Santosh Shilimkar
2011-01-05 0:32 ` Kevin Hilman
2011-01-05 0:32 ` Kevin Hilman
2011-01-05 8:18 ` Santosh Shilimkar
2011-01-05 8:18 ` Santosh Shilimkar
2011-01-04 18:43 ` [PATCH 1/5] omap2plus: clockdomain: Trivial fix for build break because of clktrctrl_mask Paul Walmsley
2011-01-04 18:43 ` Paul Walmsley
2011-01-04 18:45 ` Santosh Shilimkar
2011-01-04 18:45 ` Santosh Shilimkar
2011-01-05 0:37 ` [PATCH 0/5] omap2plus: Trivial build break fixes Kevin Hilman
2011-01-05 0:37 ` Kevin Hilman
2011-01-05 10:58 ` Santosh Shilimkar
2011-01-05 10:58 ` Santosh Shilimkar
2011-01-05 17:20 ` Kevin Hilman
2011-01-05 17:20 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7800f7a785b294a089ea8772607d232@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=thara@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.