* [PATCH] TWD: enable one-shot mode
@ 2010-12-24 19:18 ` Russell King - ARM Linux
0 siblings, 0 replies; 11+ messages in thread
From: Russell King - ARM Linux @ 2010-12-24 19:18 UTC (permalink / raw)
To: linux-arm-kernel
Allow one shot timer mode to be used with the TWD. This allows
NOHZ mode to be used on SMP systems using the TWD localtimer.
Tested on Versatile Express.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
Acks/Tested-by's would be appreciated, thanks.
Merry Christmas.
arch/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 5634dce..4a6c4d7 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1282,6 +1282,7 @@ config HAVE_ARM_SCU
config HAVE_ARM_TWD
bool
depends on SMP
+ select TICK_ONESHOT
help
This options enables support for the ARM timer and watchdog unit
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] TWD: enable one-shot mode
@ 2010-12-24 19:18 ` Russell King - ARM Linux
0 siblings, 0 replies; 11+ messages in thread
From: Russell King - ARM Linux @ 2010-12-24 19:18 UTC (permalink / raw)
To: Catalin Marinas, Bryan Huntsman, Colin Cross, Daniel Walker,
David Brown
Cc: linux-arm-kernel, linux-arm-msm, linux-omap, linux-samsung-soc,
linux-tegra
Allow one shot timer mode to be used with the TWD. This allows
NOHZ mode to be used on SMP systems using the TWD localtimer.
Tested on Versatile Express.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
Acks/Tested-by's would be appreciated, thanks.
Merry Christmas.
arch/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 5634dce..4a6c4d7 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1282,6 +1282,7 @@ config HAVE_ARM_SCU
config HAVE_ARM_TWD
bool
depends on SMP
+ select TICK_ONESHOT
help
This options enables support for the ARM timer and watchdog unit
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] TWD: enable one-shot mode
2010-12-24 19:18 ` Russell King - ARM Linux
@ 2010-12-28 1:17 ` Linus Walleij
-1 siblings, 0 replies; 11+ messages in thread
From: Linus Walleij @ 2010-12-28 1:17 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Catalin Marinas, Bryan Huntsman, Colin Cross, Daniel Walker,
David Brown, Erik Gilling, Kukjin Kim, Olof Johansson,
Srinidhi Kasagar, Tony Lindgren, linux-tegra, linux-arm-msm,
linux-samsung-soc, linux-omap, linux-arm-kernel
2010/12/24 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> Allow one shot timer mode to be used with the TWD. This allows
> NOHZ mode to be used on SMP systems using the TWD localtimer.
>
> Tested on Versatile Express.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> Acks/Tested-by's would be appreciated, thanks.
Tested on the U8500 and doesn't seem to break anything...
Local interrupts after a few minutes of use before patching
(and enabling NO_HZ):
LOC: 8203 8224
After patching;
LOC: 233 322
Looks like it's working, too.
Tested-by: Linus Walleij <linus.walleij@stericsson.com>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] TWD: enable one-shot mode
@ 2010-12-28 1:17 ` Linus Walleij
0 siblings, 0 replies; 11+ messages in thread
From: Linus Walleij @ 2010-12-28 1:17 UTC (permalink / raw)
To: linux-arm-kernel
2010/12/24 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> Allow one shot timer mode to be used with the TWD. ?This allows
> NOHZ mode to be used on SMP systems using the TWD localtimer.
>
> Tested on Versatile Express.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> Acks/Tested-by's would be appreciated, thanks.
Tested on the U8500 and doesn't seem to break anything...
Local interrupts after a few minutes of use before patching
(and enabling NO_HZ):
LOC: 8203 8224
After patching;
LOC: 233 322
Looks like it's working, too.
Tested-by: Linus Walleij <linus.walleij@stericsson.com>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] TWD: enable one-shot mode
2010-12-24 19:18 ` Russell King - ARM Linux
@ 2011-01-11 5:12 ` Stephen Boyd
-1 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2011-01-11 5:12 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Catalin Marinas, Bryan Huntsman, Colin Cross, Daniel Walker,
David Brown, Erik Gilling, Kukjin Kim, Linus Walleij,
Olof Johansson, Srinidhi Kasagar, Tony Lindgren, linux-tegra,
linux-arm-msm, linux-samsung-soc, linux-omap, linux-arm-kernel
On 12/24/2010 11:18 AM, Russell King - ARM Linux wrote:
> Allow one shot timer mode to be used with the TWD. This allows
> NOHZ mode to be used on SMP systems using the TWD localtimer.
>
> Tested on Versatile Express.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> Acks/Tested-by's would be appreciated, thanks.
>
I see this patch was already tested and merged but can you elaborate on
why this was done? From what I understand, NOHZ selects one-shot (like
is done in this patch), so why don't the machines with a TWD choose NOHZ
or high res timers?
Putting it another way, if my machine supports a oneshot capable
clockevent device should I be selecting oneshot regardless of the NOHZ
and high res config option being chosen?
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] TWD: enable one-shot mode
@ 2011-01-11 5:12 ` Stephen Boyd
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2011-01-11 5:12 UTC (permalink / raw)
To: linux-arm-kernel
On 12/24/2010 11:18 AM, Russell King - ARM Linux wrote:
> Allow one shot timer mode to be used with the TWD. This allows
> NOHZ mode to be used on SMP systems using the TWD localtimer.
>
> Tested on Versatile Express.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> Acks/Tested-by's would be appreciated, thanks.
>
I see this patch was already tested and merged but can you elaborate on
why this was done? From what I understand, NOHZ selects one-shot (like
is done in this patch), so why don't the machines with a TWD choose NOHZ
or high res timers?
Putting it another way, if my machine supports a oneshot capable
clockevent device should I be selecting oneshot regardless of the NOHZ
and high res config option being chosen?
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] TWD: enable one-shot mode
2011-01-11 5:12 ` Stephen Boyd
@ 2011-01-11 11:52 ` Russell King - ARM Linux
-1 siblings, 0 replies; 11+ messages in thread
From: Russell King - ARM Linux @ 2011-01-11 11:52 UTC (permalink / raw)
To: Stephen Boyd
Cc: Catalin Marinas, Bryan Huntsman, Colin Cross, Daniel Walker,
David Brown, Erik Gilling, Kukjin Kim, Linus Walleij,
Olof Johansson, Srinidhi Kasagar, Tony Lindgren, linux-tegra,
linux-arm-msm, linux-samsung-soc, linux-omap, linux-arm-kernel
On Mon, Jan 10, 2011 at 09:12:36PM -0800, Stephen Boyd wrote:
> On 12/24/2010 11:18 AM, Russell King - ARM Linux wrote:
> > Allow one shot timer mode to be used with the TWD. This allows
> > NOHZ mode to be used on SMP systems using the TWD localtimer.
> >
> > Tested on Versatile Express.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > ---
> > Acks/Tested-by's would be appreciated, thanks.
> >
>
> I see this patch was already tested and merged but can you elaborate on
> why this was done? From what I understand, NOHZ selects one-shot (like
> is done in this patch), so why don't the machines with a TWD choose NOHZ
> or high res timers?
You're right - so it's not actually required. It should probably be
reverted, though it does no damage...
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] TWD: enable one-shot mode
@ 2011-01-11 11:52 ` Russell King - ARM Linux
0 siblings, 0 replies; 11+ messages in thread
From: Russell King - ARM Linux @ 2011-01-11 11:52 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 10, 2011 at 09:12:36PM -0800, Stephen Boyd wrote:
> On 12/24/2010 11:18 AM, Russell King - ARM Linux wrote:
> > Allow one shot timer mode to be used with the TWD. This allows
> > NOHZ mode to be used on SMP systems using the TWD localtimer.
> >
> > Tested on Versatile Express.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > ---
> > Acks/Tested-by's would be appreciated, thanks.
> >
>
> I see this patch was already tested and merged but can you elaborate on
> why this was done? From what I understand, NOHZ selects one-shot (like
> is done in this patch), so why don't the machines with a TWD choose NOHZ
> or high res timers?
You're right - so it's not actually required. It should probably be
reverted, though it does no damage...
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] TWD: enable one-shot mode
2011-01-11 11:52 ` Russell King - ARM Linux
@ 2011-01-14 18:45 ` Stephen Boyd
-1 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2011-01-14 18:45 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Catalin Marinas, Bryan Huntsman, Colin Cross, Daniel Walker,
David Brown, Erik Gilling, Kukjin Kim, Linus Walleij,
Olof Johansson, Srinidhi Kasagar, Tony Lindgren, linux-tegra,
linux-arm-msm, linux-samsung-soc, linux-omap, linux-arm-kernel
On 01/11/2011 03:52 AM, Russell King - ARM Linux wrote:
> On Mon, Jan 10, 2011 at 09:12:36PM -0800, Stephen Boyd wrote:
>>
>> I see this patch was already tested and merged but can you elaborate on
>> why this was done? From what I understand, NOHZ selects one-shot (like
>> is done in this patch), so why don't the machines with a TWD choose NOHZ
>> or high res timers?
>
> You're right - so it's not actually required. It should probably be
> reverted, though it does no damage...
Now I'm wondering why there are other 'select TICK_ONESHOT' lines in
arch/arm/Kconfig. Can we just remove them all? Otherwise it feels like
we're making it confusing for others later on.
----->8---[cut here]----8<-----
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e2f8011..7750a78 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -532,7 +532,6 @@ config ARCH_MMP
select CLKDEV_LOOKUP
select GENERIC_CLOCKEVENTS
select HAVE_SCHED_CLOCK
- select TICK_ONESHOT
select PLAT_PXA
select SPARSE_IRQ
help
@@ -613,7 +612,6 @@ config ARCH_PXA
select ARCH_REQUIRE_GPIOLIB
select GENERIC_CLOCKEVENTS
select HAVE_SCHED_CLOCK
- select TICK_ONESHOT
select PLAT_PXA
select SPARSE_IRQ
help
@@ -668,7 +666,6 @@ config ARCH_SA1100
select GENERIC_CLOCKEVENTS
select HAVE_CLK
select HAVE_SCHED_CLOCK
- select TICK_ONESHOT
select ARCH_REQUIRE_GPIOLIB
help
Support for StrongARM 11x0 based boards.
@@ -1300,7 +1297,6 @@ config HAVE_ARM_SCU
config HAVE_ARM_TWD
bool
depends on SMP
- select TICK_ONESHOT
help
This options enables support for the ARM timer and watchdog unit
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH] TWD: enable one-shot mode
@ 2011-01-14 18:45 ` Stephen Boyd
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2011-01-14 18:45 UTC (permalink / raw)
To: linux-arm-kernel
On 01/11/2011 03:52 AM, Russell King - ARM Linux wrote:
> On Mon, Jan 10, 2011 at 09:12:36PM -0800, Stephen Boyd wrote:
>>
>> I see this patch was already tested and merged but can you elaborate on
>> why this was done? From what I understand, NOHZ selects one-shot (like
>> is done in this patch), so why don't the machines with a TWD choose NOHZ
>> or high res timers?
>
> You're right - so it's not actually required. It should probably be
> reverted, though it does no damage...
Now I'm wondering why there are other 'select TICK_ONESHOT' lines in
arch/arm/Kconfig. Can we just remove them all? Otherwise it feels like
we're making it confusing for others later on.
----->8---[cut here]----8<-----
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e2f8011..7750a78 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -532,7 +532,6 @@ config ARCH_MMP
select CLKDEV_LOOKUP
select GENERIC_CLOCKEVENTS
select HAVE_SCHED_CLOCK
- select TICK_ONESHOT
select PLAT_PXA
select SPARSE_IRQ
help
@@ -613,7 +612,6 @@ config ARCH_PXA
select ARCH_REQUIRE_GPIOLIB
select GENERIC_CLOCKEVENTS
select HAVE_SCHED_CLOCK
- select TICK_ONESHOT
select PLAT_PXA
select SPARSE_IRQ
help
@@ -668,7 +666,6 @@ config ARCH_SA1100
select GENERIC_CLOCKEVENTS
select HAVE_CLK
select HAVE_SCHED_CLOCK
- select TICK_ONESHOT
select ARCH_REQUIRE_GPIOLIB
help
Support for StrongARM 11x0 based boards.
@@ -1300,7 +1297,6 @@ config HAVE_ARM_SCU
config HAVE_ARM_TWD
bool
depends on SMP
- select TICK_ONESHOT
help
This options enables support for the ARM timer and watchdog unit
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply related [flat|nested] 11+ messages in thread