From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Zang Roy-R61911 <R61911@freescale.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
Xu Lei-B33228 <B33228@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Gala Kumar-B11780 <B11780@freescale.com>,
"jgarzik@pobox.com" <jgarzik@pobox.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] ATA: Add FSL sata v2 controller support
Date: Tue, 18 Jan 2011 14:27:20 +0300 [thread overview]
Message-ID: <4D357918.4040001@ru.mvista.com> (raw)
In-Reply-To: <2239AC579C7D3646A720227A37E0268109001B@039-SN1MPN1-004.039d.mgd.msft.net>
Hello.
On 18-01-2011 6:01, Zang Roy-R61911 wrote:
>>> In FSL sata v2 block, the snoop bit of PRDT Word3 description
>>> information is at bit28 instead of bit22.
>>> This patch adds FSL sata v2 probe and resolve this difference.
>>> Signed-off-by: Xulei<B33228@freescale.com>
> [snip]
>>> diff --git a/arch/powerpc/boot/dts/p1022ds.dts
>> b/arch/powerpc/boot/dts/p1022ds.dts
>>> index 2bbecbb..9ad41dd 100644
>>> --- a/arch/powerpc/boot/dts/p1022ds.dts
>>> +++ b/arch/powerpc/boot/dts/p1022ds.dts
>>> @@ -475,14 +475,14 @@
>>> };
>>>
>>> sata@18000 {
>>> - compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
>>> + compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
>>> reg =<0x18000 0x1000>;
>>> cell-index =<1>;
>>> interrupts =<74 0x2>;
>>> };
>>>
>>> sata@19000 {
>>> - compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
>>> + compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
>>> reg =<0x19000 0x1000>;
>>> cell-index =<2>;
>>> interrupts =<41 0x2>;
>> Please put this into the separate patch and push thru the PPC tree.
> I agree to put to them to separate patches, but should we
> pull in the separate patches to one candidate tree to make
> the function work?
I don't understand. What is "candidate tree"?
> Thanks.
> Roy
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Zang Roy-R61911 <R61911@freescale.com>
Cc: Xu Lei-B33228 <B33228@freescale.com>,
Sergei Shtylyov <sshtylyov@mvista.com>,
"jgarzik@pobox.com" <jgarzik@pobox.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Gala Kumar-B11780 <B11780@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] ATA: Add FSL sata v2 controller support
Date: Tue, 18 Jan 2011 14:27:20 +0300 [thread overview]
Message-ID: <4D357918.4040001@ru.mvista.com> (raw)
In-Reply-To: <2239AC579C7D3646A720227A37E0268109001B@039-SN1MPN1-004.039d.mgd.msft.net>
Hello.
On 18-01-2011 6:01, Zang Roy-R61911 wrote:
>>> In FSL sata v2 block, the snoop bit of PRDT Word3 description
>>> information is at bit28 instead of bit22.
>>> This patch adds FSL sata v2 probe and resolve this difference.
>>> Signed-off-by: Xulei<B33228@freescale.com>
> [snip]
>>> diff --git a/arch/powerpc/boot/dts/p1022ds.dts
>> b/arch/powerpc/boot/dts/p1022ds.dts
>>> index 2bbecbb..9ad41dd 100644
>>> --- a/arch/powerpc/boot/dts/p1022ds.dts
>>> +++ b/arch/powerpc/boot/dts/p1022ds.dts
>>> @@ -475,14 +475,14 @@
>>> };
>>>
>>> sata@18000 {
>>> - compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
>>> + compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
>>> reg =<0x18000 0x1000>;
>>> cell-index =<1>;
>>> interrupts =<74 0x2>;
>>> };
>>>
>>> sata@19000 {
>>> - compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
>>> + compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
>>> reg =<0x19000 0x1000>;
>>> cell-index =<2>;
>>> interrupts =<41 0x2>;
>> Please put this into the separate patch and push thru the PPC tree.
> I agree to put to them to separate patches, but should we
> pull in the separate patches to one candidate tree to make
> the function work?
I don't understand. What is "candidate tree"?
> Thanks.
> Roy
WBR, Sergei
next prev parent reply other threads:[~2011-01-18 11:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 7:10 [PATCH] ATA: Add FSL sata v2 controller support Xulei
2011-01-17 7:10 ` Xulei
2011-01-17 11:47 ` Sergei Shtylyov
2011-01-17 11:47 ` Sergei Shtylyov
2011-01-17 11:58 ` Aggrwal Poonam-B10812
2011-01-17 11:58 ` Aggrwal Poonam-B10812
2011-01-17 14:57 ` Kumar Gala
2011-01-17 14:57 ` Kumar Gala
2011-01-18 3:01 ` Zang Roy-R61911
2011-01-18 3:01 ` Zang Roy-R61911
2011-01-18 11:27 ` Sergei Shtylyov [this message]
2011-01-18 11:27 ` Sergei Shtylyov
2011-01-18 11:43 ` Zang Roy-R61911
2011-01-18 11:43 ` Zang Roy-R61911
2011-01-18 12:33 ` Sergei Shtylyov
2011-01-18 12:33 ` Sergei Shtylyov
2011-01-19 1:10 ` Jeff Garzik
2011-01-19 5:23 ` Kumar Gala
2011-01-19 5:23 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D357918.4040001@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=B11780@freescale.com \
--cc=B33228@freescale.com \
--cc=R61911@freescale.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.