From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
Glauber Costa <glommer@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Ulrich Obergfell <uobergfe@redhat.com>
Subject: Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift
Date: Mon, 07 Feb 2011 13:28:56 -0600 [thread overview]
Message-ID: <4D5047F8.4020308@codemonkey.ws> (raw)
In-Reply-To: <4D500DC8.5060301@siemens.com>
On 02/07/2011 09:20 AM, Jan Kiszka wrote:
> On 2011-02-07 16:13, Avi Kivity wrote:
>
>>> PeriodicTimer *periodic_timer_new(PeriodicTimerFunc *cb, void *opaque);
>>>
>>>
>> void periodic_timer_init(PeriodicTimer *timer, PeriodicTimerFunc *cb);
>>
>> It is better to embed than to reference.
>>
> And embedding means making the layout (at least the size) of
> PeriodicTimer public. I guess that's why QEMUTimer works via new.
>
Yeah, QEMU generally follows a construction-is-allocation model.
Regards,
Anthony Liguori
> Jan
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Ulrich Obergfell <uobergfe@redhat.com>,
Glauber Costa <glommer@redhat.com>, Avi Kivity <avi@redhat.com>,
kvm <kvm@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift
Date: Mon, 07 Feb 2011 13:28:56 -0600 [thread overview]
Message-ID: <4D5047F8.4020308@codemonkey.ws> (raw)
In-Reply-To: <4D500DC8.5060301@siemens.com>
On 02/07/2011 09:20 AM, Jan Kiszka wrote:
> On 2011-02-07 16:13, Avi Kivity wrote:
>
>>> PeriodicTimer *periodic_timer_new(PeriodicTimerFunc *cb, void *opaque);
>>>
>>>
>> void periodic_timer_init(PeriodicTimer *timer, PeriodicTimerFunc *cb);
>>
>> It is better to embed than to reference.
>>
> And embedding means making the layout (at least the size) of
> PeriodicTimer public. I guess that's why QEMUTimer works via new.
>
Yeah, QEMU generally follows a construction-is-allocation model.
Regards,
Anthony Liguori
> Jan
>
>
next prev parent reply other threads:[~2011-02-07 19:29 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <480481933.225059.1296734409954.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2011-02-03 13:43 ` [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift Ulrich Obergfell
2011-02-03 15:28 ` Jan Kiszka
2011-02-03 15:28 ` [Qemu-devel] " Jan Kiszka
2011-02-03 20:07 ` Anthony Liguori
2011-02-03 20:07 ` Anthony Liguori
2011-02-03 21:24 ` Jan Kiszka
2011-02-03 21:24 ` Jan Kiszka
2011-02-04 2:06 ` Anthony Liguori
2011-02-04 2:06 ` Anthony Liguori
2011-02-04 8:56 ` Jan Kiszka
2011-02-04 8:56 ` Jan Kiszka
2011-02-07 12:34 ` Avi Kivity
2011-02-07 12:34 ` Avi Kivity
2011-02-07 13:11 ` Anthony Liguori
2011-02-07 13:11 ` Anthony Liguori
2011-02-07 13:14 ` Avi Kivity
2011-02-07 13:14 ` Avi Kivity
2011-02-07 13:23 ` Anthony Liguori
2011-02-07 13:23 ` Anthony Liguori
2011-02-07 13:34 ` Avi Kivity
2011-02-07 13:34 ` Avi Kivity
2011-02-07 13:41 ` Gleb Natapov
2011-02-07 13:41 ` Gleb Natapov
2011-02-07 13:46 ` Avi Kivity
2011-02-07 13:46 ` Avi Kivity
2011-02-07 13:48 ` Gleb Natapov
2011-02-07 13:48 ` Gleb Natapov
2011-02-07 13:51 ` Avi Kivity
2011-02-07 13:51 ` Avi Kivity
2011-02-07 13:54 ` Gleb Natapov
2011-02-07 13:54 ` Gleb Natapov
2011-02-07 14:10 ` Jan Kiszka
2011-02-07 14:10 ` Jan Kiszka
2011-02-07 14:28 ` Anthony Liguori
2011-02-07 14:28 ` Anthony Liguori
2011-02-07 14:43 ` Jan Kiszka
2011-02-07 14:43 ` Jan Kiszka
2011-02-07 14:54 ` Anthony Liguori
2011-02-07 14:54 ` Anthony Liguori
2011-02-07 14:57 ` Jan Kiszka
2011-02-07 14:57 ` Jan Kiszka
2011-02-07 15:01 ` Anthony Liguori
2011-02-07 15:01 ` Anthony Liguori
2011-02-07 15:08 ` Jan Kiszka
2011-02-07 15:08 ` Jan Kiszka
2011-02-07 15:13 ` Avi Kivity
2011-02-07 15:13 ` Avi Kivity
2011-02-07 15:17 ` Jan Kiszka
2011-02-07 15:17 ` Jan Kiszka
2011-02-07 15:29 ` Avi Kivity
2011-02-07 15:29 ` Avi Kivity
2011-02-07 19:30 ` Anthony Liguori
2011-02-07 19:30 ` Anthony Liguori
2011-02-08 9:11 ` Avi Kivity
2011-02-08 9:11 ` Avi Kivity
2011-02-07 15:20 ` Jan Kiszka
2011-02-07 15:20 ` Jan Kiszka
2011-02-07 15:30 ` Avi Kivity
2011-02-07 15:30 ` Avi Kivity
2011-02-07 19:28 ` Anthony Liguori [this message]
2011-02-07 19:28 ` Anthony Liguori
2011-02-07 14:58 ` Avi Kivity
2011-02-07 14:58 ` Avi Kivity
2011-02-07 15:01 ` Jan Kiszka
2011-02-07 15:01 ` Jan Kiszka
2011-02-07 15:08 ` Avi Kivity
2011-02-07 15:08 ` Avi Kivity
2011-02-07 15:14 ` Jan Kiszka
2011-02-07 15:14 ` Jan Kiszka
2011-02-07 15:16 ` Avi Kivity
2011-02-07 15:16 ` Avi Kivity
2011-02-07 15:22 ` Anthony Liguori
2011-02-07 15:22 ` Anthony Liguori
2011-02-07 15:18 ` Anthony Liguori
2011-02-04 9:52 ` Ulrich Obergfell
2011-02-04 9:52 ` Ulrich Obergfell
2011-02-07 10:44 ` Ulrich Obergfell
2011-02-07 10:44 ` Ulrich Obergfell
2011-02-07 13:24 ` Anthony Liguori
2011-02-07 13:24 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5047F8.4020308@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.